Re: [PATCH -next] bus: ti-sysc: remove set but not used variable 'quirks'

2019-08-13 Thread Tony Lindgren
* YueHaibing  [190627 21:17]:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/bus/ti-sysc.c: In function sysc_reset:
> drivers/bus/ti-sysc.c:1452:50: warning: variable quirks set but not used 
> [-Wunused-but-set-variable]
> 
> It is never used since commit e0db94fe87da ("bus: ti-sysc: Make
> OCP reset work for sysstatus and sysconfig reset bits")

Applying into omap-for-v5.4/ti-sysc thanks.

Tony


[PATCH -next] bus: ti-sysc: remove set but not used variable 'quirks'

2019-06-27 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/bus/ti-sysc.c: In function sysc_reset:
drivers/bus/ti-sysc.c:1452:50: warning: variable quirks set but not used 
[-Wunused-but-set-variable]

It is never used since commit e0db94fe87da ("bus: ti-sysc: Make
OCP reset work for sysstatus and sysconfig reset bits")

Reported-by: Hulk Robot 
Signed-off-by: YueHaibing 
---
 drivers/bus/ti-sysc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/bus/ti-sysc.c b/drivers/bus/ti-sysc.c
index e6deabd..8cb5351 100644
--- a/drivers/bus/ti-sysc.c
+++ b/drivers/bus/ti-sysc.c
@@ -1558,12 +1558,11 @@ static int sysc_rstctrl_reset_deassert(struct sysc 
*ddata, bool reset)
  */
 static int sysc_reset(struct sysc *ddata)
 {
-   int sysc_offset, syss_offset, sysc_val, rstval, quirks, error = 0;
+   int sysc_offset, syss_offset, sysc_val, rstval, error = 0;
u32 sysc_mask, syss_done;
 
sysc_offset = ddata->offsets[SYSC_SYSCONFIG];
syss_offset = ddata->offsets[SYSC_SYSSTATUS];
-   quirks = ddata->cfg.quirks;
 
if (ddata->legacy_mode || sysc_offset < 0 ||
ddata->cap->regbits->srst_shift < 0 ||
-- 
2.7.4