Re: [PATCH -next] fsi/sbefifo: Add dependency on OF_ADDRESS
On Wed, Jul 04, 2018 at 12:23:20AM +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2018-07-03 at 06:43 -0700, Guenter Roeck wrote:
> > The driver calls of_platform_device_create() which is only available
> > if OF_ADDRESS is enabled. When building sparc64 images, this results
> > in
> >
> > ERROR: "of_platform_device_create" [drivers/fsi/fsi-sbefifo.ko] undefined!
> >
> > Fixes: 9f4a8a2d7f9d ("fsi/sbefifo: Add driver for the SBE FIFO")
> > Cc: Benjamin Herrenschmidt
> > Signed-off-by: Guenter Roeck
>
> Thanks Guenter ! I'll include this into the fsi tree.
>
> (I was wondering what that kbuild report on sparc64 was about... I must
> have misread the code, I didn't realize of_platform_device_create
> wasn't under CONFIG_OF alone).
>
No worries; pretty much everyone using one of the affected functions
falls into that trap.
Guenter
Re: [PATCH -next] fsi/sbefifo: Add dependency on OF_ADDRESS
On Wed, Jul 04, 2018 at 12:23:20AM +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2018-07-03 at 06:43 -0700, Guenter Roeck wrote:
> > The driver calls of_platform_device_create() which is only available
> > if OF_ADDRESS is enabled. When building sparc64 images, this results
> > in
> >
> > ERROR: "of_platform_device_create" [drivers/fsi/fsi-sbefifo.ko] undefined!
> >
> > Fixes: 9f4a8a2d7f9d ("fsi/sbefifo: Add driver for the SBE FIFO")
> > Cc: Benjamin Herrenschmidt
> > Signed-off-by: Guenter Roeck
>
> Thanks Guenter ! I'll include this into the fsi tree.
>
> (I was wondering what that kbuild report on sparc64 was about... I must
> have misread the code, I didn't realize of_platform_device_create
> wasn't under CONFIG_OF alone).
>
No worries; pretty much everyone using one of the affected functions
falls into that trap.
Guenter
Re: [PATCH -next] fsi/sbefifo: Add dependency on OF_ADDRESS
On Tue, 2018-07-03 at 06:43 -0700, Guenter Roeck wrote:
> The driver calls of_platform_device_create() which is only available
> if OF_ADDRESS is enabled. When building sparc64 images, this results
> in
>
> ERROR: "of_platform_device_create" [drivers/fsi/fsi-sbefifo.ko] undefined!
>
> Fixes: 9f4a8a2d7f9d ("fsi/sbefifo: Add driver for the SBE FIFO")
> Cc: Benjamin Herrenschmidt
> Signed-off-by: Guenter Roeck
Thanks Guenter ! I'll include this into the fsi tree.
(I was wondering what that kbuild report on sparc64 was about... I must
have misread the code, I didn't realize of_platform_device_create
wasn't under CONFIG_OF alone).
Cheers,
Ben.
> ---
> drivers/fsi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/fsi/Kconfig b/drivers/fsi/Kconfig
> index 24f84a96b8b9..9c08f467a7bb 100644
> --- a/drivers/fsi/Kconfig
> +++ b/drivers/fsi/Kconfig
> @@ -34,6 +34,7 @@ config FSI_SCOM
>
> config FSI_SBEFIFO
> tristate "SBEFIFO FSI client device driver"
> + depends on OF_ADDRESS
> ---help---
> This option enables an FSI based SBEFIFO device driver. The SBEFIFO is
> a pipe-like FSI device for communicating with the self boot engine
Re: [PATCH -next] fsi/sbefifo: Add dependency on OF_ADDRESS
On Tue, 2018-07-03 at 06:43 -0700, Guenter Roeck wrote:
> The driver calls of_platform_device_create() which is only available
> if OF_ADDRESS is enabled. When building sparc64 images, this results
> in
>
> ERROR: "of_platform_device_create" [drivers/fsi/fsi-sbefifo.ko] undefined!
>
> Fixes: 9f4a8a2d7f9d ("fsi/sbefifo: Add driver for the SBE FIFO")
> Cc: Benjamin Herrenschmidt
> Signed-off-by: Guenter Roeck
Thanks Guenter ! I'll include this into the fsi tree.
(I was wondering what that kbuild report on sparc64 was about... I must
have misread the code, I didn't realize of_platform_device_create
wasn't under CONFIG_OF alone).
Cheers,
Ben.
> ---
> drivers/fsi/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/fsi/Kconfig b/drivers/fsi/Kconfig
> index 24f84a96b8b9..9c08f467a7bb 100644
> --- a/drivers/fsi/Kconfig
> +++ b/drivers/fsi/Kconfig
> @@ -34,6 +34,7 @@ config FSI_SCOM
>
> config FSI_SBEFIFO
> tristate "SBEFIFO FSI client device driver"
> + depends on OF_ADDRESS
> ---help---
> This option enables an FSI based SBEFIFO device driver. The SBEFIFO is
> a pipe-like FSI device for communicating with the self boot engine
[PATCH -next] fsi/sbefifo: Add dependency on OF_ADDRESS
The driver calls of_platform_device_create() which is only available
if OF_ADDRESS is enabled. When building sparc64 images, this results
in
ERROR: "of_platform_device_create" [drivers/fsi/fsi-sbefifo.ko] undefined!
Fixes: 9f4a8a2d7f9d ("fsi/sbefifo: Add driver for the SBE FIFO")
Cc: Benjamin Herrenschmidt
Signed-off-by: Guenter Roeck
---
drivers/fsi/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/fsi/Kconfig b/drivers/fsi/Kconfig
index 24f84a96b8b9..9c08f467a7bb 100644
--- a/drivers/fsi/Kconfig
+++ b/drivers/fsi/Kconfig
@@ -34,6 +34,7 @@ config FSI_SCOM
config FSI_SBEFIFO
tristate "SBEFIFO FSI client device driver"
+ depends on OF_ADDRESS
---help---
This option enables an FSI based SBEFIFO device driver. The SBEFIFO is
a pipe-like FSI device for communicating with the self boot engine
--
2.7.4
[PATCH -next] fsi/sbefifo: Add dependency on OF_ADDRESS
The driver calls of_platform_device_create() which is only available
if OF_ADDRESS is enabled. When building sparc64 images, this results
in
ERROR: "of_platform_device_create" [drivers/fsi/fsi-sbefifo.ko] undefined!
Fixes: 9f4a8a2d7f9d ("fsi/sbefifo: Add driver for the SBE FIFO")
Cc: Benjamin Herrenschmidt
Signed-off-by: Guenter Roeck
---
drivers/fsi/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/fsi/Kconfig b/drivers/fsi/Kconfig
index 24f84a96b8b9..9c08f467a7bb 100644
--- a/drivers/fsi/Kconfig
+++ b/drivers/fsi/Kconfig
@@ -34,6 +34,7 @@ config FSI_SCOM
config FSI_SBEFIFO
tristate "SBEFIFO FSI client device driver"
+ depends on OF_ADDRESS
---help---
This option enables an FSI based SBEFIFO device driver. The SBEFIFO is
a pipe-like FSI device for communicating with the self boot engine
--
2.7.4
