Re: [PATCH -next] habanalabs: make some functions static

2020-07-29 Thread Greg Kroah-Hartman 
On Wed, Jul 29, 2020 at 11:59:25PM +0800, Wei Yongjun wrote:
> The sparse tool complains as follows:
> 
> drivers/misc/habanalabs/gaudi/gaudi.c:6275:5: warning:
>  symbol 'gaudi_ctx_init' was not declared. Should it be static?
> drivers/misc/habanalabs/goya/goya.c:5228:5: warning:
>  symbol 'goya_ctx_init' was not declared. Should it be static?
> 
> Those functions are not used outside of source file, so this
> commit marks them static.
> 
> Fixes: a04b7cd97eef ("habanalabs: create internal CB pool")
> Reported-by: Hulk Robot 
> Signed-off-by: Wei Yongjun 

0-day already sent this patch in earlier today, sorry.

greg k-h

[PATCH -next] habanalabs: make some functions static

2020-07-29 Thread Wei Yongjun 
The sparse tool complains as follows:

drivers/misc/habanalabs/gaudi/gaudi.c:6275:5: warning:
 symbol 'gaudi_ctx_init' was not declared. Should it be static?
drivers/misc/habanalabs/goya/goya.c:5228:5: warning:
 symbol 'goya_ctx_init' was not declared. Should it be static?

Those functions are not used outside of source file, so this
commit marks them static.

Fixes: a04b7cd97eef ("habanalabs: create internal CB pool")
Reported-by: Hulk Robot 
Signed-off-by: Wei Yongjun 
---
 drivers/misc/habanalabs/gaudi/gaudi.c | 2 +-
 drivers/misc/habanalabs/goya/goya.c | 2 +-
 2 file changed, 2 insertion(+), 2 deletion(-)

diff --git a/drivers/misc/habanalabs/gaudi/gaudi.c 
b/drivers/misc/habanalabs/gaudi/gaudi.c
index d4b3b995f69d..00a0a7238d81 100644
--- a/drivers/misc/habanalabs/gaudi/gaudi.c
+++ b/drivers/misc/habanalabs/gaudi/gaudi.c
@@ -6272,7 +6272,7 @@ static enum hl_device_hw_state gaudi_get_hw_state(struct 
hl_device *hdev)
return RREG32(mmHW_STATE);
 }
 
-int gaudi_ctx_init(struct hl_ctx *ctx)
+static int gaudi_ctx_init(struct hl_ctx *ctx)
 {
return 0;
 }
diff --git a/drivers/misc/habanalabs/goya/goya.c 
b/drivers/misc/habanalabs/goya/goya.c
index dedcd2211fb7..85030759b2af 100644
--- a/drivers/misc/habanalabs/goya/goya.c
+++ b/drivers/misc/habanalabs/goya/goya.c
@@ -5225,7 +5225,7 @@ static enum hl_device_hw_state goya_get_hw_state(struct 
hl_device *hdev)
return RREG32(mmHW_STATE);
 }
 
-int goya_ctx_init(struct hl_ctx *ctx)
+static int goya_ctx_init(struct hl_ctx *ctx)
 {
return 0;
 }