Re: [PATCH -next] media: ti-vpe: sc: remove redundant dev_err call in sc_create()

[Benoit Parrot]

Yang,

Thank you for the patch.

Yang Yingliang  wrote on Thu [2021-Apr-01 18:30:15 
+0800]:
> There is an error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
> 
> Reported-by: Hulk Robot 
> Signed-off-by: Yang Yingliang 
> ---
>  drivers/media/platform/ti-vpe/sc.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/media/platform/ti-vpe/sc.c 
> b/drivers/media/platform/ti-vpe/sc.c
> index 98f95082a6fd..0202d278523f 100644
> --- a/drivers/media/platform/ti-vpe/sc.c
> +++ b/drivers/media/platform/ti-vpe/sc.c
> @@ -294,10 +294,8 @@ struct sc_data *sc_create(struct platform_device *pdev, 
> const char *res_name)
>   }
>  
>   sc->base = devm_ioremap_resource(>dev, sc->res);
> - if (IS_ERR(sc->base)) {
> - dev_err(>dev, "failed to ioremap\n");
> + if (IS_ERR(sc->base))
>   return ERR_CAST(sc->base);
> - }

Reviewed-by: Benoit Parrot 

>  
>   return sc;
>  }
> -- 
> 2.25.1
> 

[PATCH -next] media: ti-vpe: sc: remove redundant dev_err call in sc_create()

[Yang Yingliang]

There is an error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot 
Signed-off-by: Yang Yingliang 
---
 drivers/media/platform/ti-vpe/sc.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/media/platform/ti-vpe/sc.c 
b/drivers/media/platform/ti-vpe/sc.c
index 98f95082a6fd..0202d278523f 100644
--- a/drivers/media/platform/ti-vpe/sc.c
+++ b/drivers/media/platform/ti-vpe/sc.c
@@ -294,10 +294,8 @@ struct sc_data *sc_create(struct platform_device *pdev, 
const char *res_name)
}
 
sc->base = devm_ioremap_resource(>dev, sc->res);
-   if (IS_ERR(sc->base)) {
-   dev_err(>dev, "failed to ioremap\n");
+   if (IS_ERR(sc->base))
return ERR_CAST(sc->base);
-   }
 
return sc;
 }
-- 
2.25.1