Re: [PATCH -next] mfd: arizona: Make some symbols static
On Wed, 10 Feb 2021, Wei Yongjun wrote: > The sparse tool complains as follows: > > drivers/mfd/arizona-spi.c:28:31: warning: > symbol 'reset_gpios' was not declared. Should it be static? > drivers/mfd/arizona-spi.c:29:31: warning: > symbol 'ldoena_gpios' was not declared. Should it be static? > > Those symbols are not used outside of arizona-spi.c, so this > commit marks them static. > > Fixes: e933836744a2 ("mfd: arizona: Add support for ACPI enumeration of > WM5102 connected over SPI") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > drivers/mfd/arizona-spi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied, thanks. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog
Re: [PATCH -next] mfd: arizona: Make some symbols static
On Wed, Feb 10, 2021 at 07:56:26AM +, Wei Yongjun wrote: > The sparse tool complains as follows: > > drivers/mfd/arizona-spi.c:28:31: warning: > symbol 'reset_gpios' was not declared. Should it be static? > drivers/mfd/arizona-spi.c:29:31: warning: > symbol 'ldoena_gpios' was not declared. Should it be static? > > Those symbols are not used outside of arizona-spi.c, so this > commit marks them static. > > Fixes: e933836744a2 ("mfd: arizona: Add support for ACPI enumeration of > WM5102 connected over SPI") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- Acked-by: Charles Keepax Thanks, Charles
Re: [PATCH -next] mfd: arizona: Make some symbols static
Hi, On 2/10/21 8:56 AM, Wei Yongjun wrote: > The sparse tool complains as follows: > > drivers/mfd/arizona-spi.c:28:31: warning: > symbol 'reset_gpios' was not declared. Should it be static? > drivers/mfd/arizona-spi.c:29:31: warning: > symbol 'ldoena_gpios' was not declared. Should it be static? > > Those symbols are not used outside of arizona-spi.c, so this > commit marks them static. > > Fixes: e933836744a2 ("mfd: arizona: Add support for ACPI enumeration of > WM5102 connected over SPI") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun Thank you for catching this. Patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/mfd/arizona-spi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mfd/arizona-spi.c b/drivers/mfd/arizona-spi.c > index 24a2c75d691a..aa1d6f94ae53 100644 > --- a/drivers/mfd/arizona-spi.c > +++ b/drivers/mfd/arizona-spi.c > @@ -25,8 +25,8 @@ > #include "arizona.h" > > #ifdef CONFIG_ACPI > -const struct acpi_gpio_params reset_gpios = { 1, 0, false }; > -const struct acpi_gpio_params ldoena_gpios = { 2, 0, false }; > +static const struct acpi_gpio_params reset_gpios = { 1, 0, false }; > +static const struct acpi_gpio_params ldoena_gpios = { 2, 0, false }; > > static const struct acpi_gpio_mapping arizona_acpi_gpios[] = { > { "reset-gpios", _gpios, 1, }, >
[PATCH -next] mfd: arizona: Make some symbols static
The sparse tool complains as follows: drivers/mfd/arizona-spi.c:28:31: warning: symbol 'reset_gpios' was not declared. Should it be static? drivers/mfd/arizona-spi.c:29:31: warning: symbol 'ldoena_gpios' was not declared. Should it be static? Those symbols are not used outside of arizona-spi.c, so this commit marks them static. Fixes: e933836744a2 ("mfd: arizona: Add support for ACPI enumeration of WM5102 connected over SPI") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- drivers/mfd/arizona-spi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mfd/arizona-spi.c b/drivers/mfd/arizona-spi.c index 24a2c75d691a..aa1d6f94ae53 100644 --- a/drivers/mfd/arizona-spi.c +++ b/drivers/mfd/arizona-spi.c @@ -25,8 +25,8 @@ #include "arizona.h" #ifdef CONFIG_ACPI -const struct acpi_gpio_params reset_gpios = { 1, 0, false }; -const struct acpi_gpio_params ldoena_gpios = { 2, 0, false }; +static const struct acpi_gpio_params reset_gpios = { 1, 0, false }; +static const struct acpi_gpio_params ldoena_gpios = { 2, 0, false }; static const struct acpi_gpio_mapping arizona_acpi_gpios[] = { { "reset-gpios", _gpios, 1, },