Re: [PATCH -next] phy: ingenic: Fix a typo in ingenic_usb_phy_probe()

[Vinod Koul]

On 05-03-21, 03:49, 'Wei Yongjun wrote:
> From: Wei Yongjun 
> 
> Fix the return value check typo which testing the wrong variable
> in ingenic_usb_phy_probe().

Applied, thanks

-- 
~Vinod

Re: [PATCH -next] phy: ingenic: Fix a typo in ingenic_usb_phy_probe()

[Paul Cercueil]

Le ven. 5 mars 2021 à 3:49, 'Wei Yongjun  a 
écrit :

From: Wei Yongjun 

Fix the return value check typo which testing the wrong variable
in ingenic_usb_phy_probe().

Fixes: 31de313dfdcf ("PHY: Ingenic: Add USB PHY driver using generic 
PHY framework.")

Reported-by: Hulk Robot 
Signed-off-by: Wei Yongjun 


Acked-by: Paul Cercueil 

Cheers,
-Paul


---
 drivers/phy/ingenic/phy-ingenic-usb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/ingenic/phy-ingenic-usb.c 
b/drivers/phy/ingenic/phy-ingenic-usb.c

index ea127b177f46..28c28d816484 100644
--- a/drivers/phy/ingenic/phy-ingenic-usb.c
+++ b/drivers/phy/ingenic/phy-ingenic-usb.c
@@ -352,8 +352,8 @@ static int ingenic_usb_phy_probe(struct 
platform_device *pdev)

}

priv->phy = devm_phy_create(dev, NULL, _usb_phy_ops);
-   if (IS_ERR(priv))
-   return PTR_ERR(priv);
+   if (IS_ERR(priv->phy))
+   return PTR_ERR(priv->phy);

phy_set_drvdata(priv->phy, priv);

[PATCH -next] phy: ingenic: Fix a typo in ingenic_usb_phy_probe()

['Wei Yongjun]

From: Wei Yongjun 

Fix the return value check typo which testing the wrong variable
in ingenic_usb_phy_probe().

Fixes: 31de313dfdcf ("PHY: Ingenic: Add USB PHY driver using generic PHY 
framework.")
Reported-by: Hulk Robot 
Signed-off-by: Wei Yongjun 
---
 drivers/phy/ingenic/phy-ingenic-usb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/ingenic/phy-ingenic-usb.c 
b/drivers/phy/ingenic/phy-ingenic-usb.c
index ea127b177f46..28c28d816484 100644
--- a/drivers/phy/ingenic/phy-ingenic-usb.c
+++ b/drivers/phy/ingenic/phy-ingenic-usb.c
@@ -352,8 +352,8 @@ static int ingenic_usb_phy_probe(struct platform_device 
*pdev)
}
 
priv->phy = devm_phy_create(dev, NULL, _usb_phy_ops);
-   if (IS_ERR(priv))
-   return PTR_ERR(priv);
+   if (IS_ERR(priv->phy))
+   return PTR_ERR(priv->phy);
 
phy_set_drvdata(priv->phy, priv);