Re: [PATCH -next] phy: ralink: phy-mt7621-pci: fix return value check in mt7621_pci_phy_probe()

[Vinod Koul]

On 05-03-21, 03:49, 'Wei Yongjun wrote:
> From: Wei Yongjun 
> 
> Fix the return value check which testing the wrong variable
> in mt7621_pci_phy_probe().

Applied, thanks

-- 
~Vinod

Re: [PATCH -next] phy: ralink: phy-mt7621-pci: fix return value check in mt7621_pci_phy_probe()

[Sergio Paracuellos]

On Fri, Mar 5, 2021 at 4:40 AM 'Wei Yongjun  wrote:
>
> From: Wei Yongjun 
>
> Fix the return value check which testing the wrong variable
> in mt7621_pci_phy_probe().
>
> Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY")
> Reported-by: Hulk Robot 
> Signed-off-by: Wei Yongjun 
> ---
>  drivers/phy/ralink/phy-mt7621-pci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Sergio Paracuellos 

[PATCH -next] phy: ralink: phy-mt7621-pci: fix return value check in mt7621_pci_phy_probe()

['Wei Yongjun]

From: Wei Yongjun 

Fix the return value check which testing the wrong variable
in mt7621_pci_phy_probe().

Fixes: d87da32372a0 ("phy: ralink: Add PHY driver for MT7621 PCIe PHY")
Reported-by: Hulk Robot 
Signed-off-by: Wei Yongjun 
---
 drivers/phy/ralink/phy-mt7621-pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/phy/ralink/phy-mt7621-pci.c 
b/drivers/phy/ralink/phy-mt7621-pci.c
index 84ee2b5c2228..753cb5bab930 100644
--- a/drivers/phy/ralink/phy-mt7621-pci.c
+++ b/drivers/phy/ralink/phy-mt7621-pci.c
@@ -319,9 +319,9 @@ static int mt7621_pci_phy_probe(struct platform_device 
*pdev)
return PTR_ERR(phy->regmap);
 
phy->phy = devm_phy_create(dev, dev->of_node, _pci_phy_ops);
-   if (IS_ERR(phy)) {
+   if (IS_ERR(phy->phy)) {
dev_err(dev, "failed to create phy\n");
-   return PTR_ERR(phy);
+   return PTR_ERR(phy->phy);
}
 
phy_set_drvdata(phy->phy, phy);