Re: [PATCH -next] regulator: Make symbols static

[YueHaibing]

On 2019/4/20 0:12, Mark Brown wrote:
> On Tue, Apr 16, 2019 at 10:41:09PM +0800, Yue Haibing wrote:
>> From: YueHaibing 
>>
>> Fix sparse warnings:
>>
>> drivers/regulator/stm32-pwr.c:35:5: warning:
>>  symbol 'ready_mask_table' was not declared. Should it be static?
>> drivers/regulator/stm32-pwr.c:47:5: warning:
>>  symbol 'stm32_pwr_reg_is_ready' was not declared. Should it be static?
>> drivers/regulator/stm32-pwr.c:57:5: warning:
>>  symbol 'stm32_pwr_reg_is_enabled' was not declared. Should it be static?
> 
> This doesn't apply against current code, please check and resend (I
> think it's just that someone else made similar fixes already but didn't
> check properly).

Yep, there is already a fix from kbuild test robot:

82f26185a912 ("regulator: ready_mask_table[] can be static")

> 

Re: [PATCH -next] regulator: Make symbols static

[Mark Brown]

On Tue, Apr 16, 2019 at 10:41:09PM +0800, Yue Haibing wrote:
> From: YueHaibing 
> 
> Fix sparse warnings:
> 
> drivers/regulator/stm32-pwr.c:35:5: warning:
>  symbol 'ready_mask_table' was not declared. Should it be static?
> drivers/regulator/stm32-pwr.c:47:5: warning:
>  symbol 'stm32_pwr_reg_is_ready' was not declared. Should it be static?
> drivers/regulator/stm32-pwr.c:57:5: warning:
>  symbol 'stm32_pwr_reg_is_enabled' was not declared. Should it be static?

This doesn't apply against current code, please check and resend (I
think it's just that someone else made similar fixes already but didn't
check properly).


signature.asc
Description: PGP signature

[PATCH -next] regulator: Make symbols static

[Yue Haibing]

From: YueHaibing 

Fix sparse warnings:

drivers/regulator/stm32-pwr.c:35:5: warning:
 symbol 'ready_mask_table' was not declared. Should it be static?
drivers/regulator/stm32-pwr.c:47:5: warning:
 symbol 'stm32_pwr_reg_is_ready' was not declared. Should it be static?
drivers/regulator/stm32-pwr.c:57:5: warning:
 symbol 'stm32_pwr_reg_is_enabled' was not declared. Should it be static?

Reported-by: Hulk Robot 
Signed-off-by: YueHaibing 
---
 drivers/regulator/stm32-pwr.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/regulator/stm32-pwr.c b/drivers/regulator/stm32-pwr.c
index e434b26..222d593 100644
--- a/drivers/regulator/stm32-pwr.c
+++ b/drivers/regulator/stm32-pwr.c
@@ -32,7 +32,7 @@ enum {
STM32PWR_REG_NUM_REGS
 };
 
-u32 ready_mask_table[STM32PWR_REG_NUM_REGS] = {
+static u32 ready_mask_table[STM32PWR_REG_NUM_REGS] = {
[PWR_REG11] = REG_1_1_RDY,
[PWR_REG18] = REG_1_8_RDY,
[PWR_USB33] = USB_3_3_RDY,
@@ -44,7 +44,7 @@ struct stm32_pwr_reg {
u32 ready_mask;
 };
 
-int stm32_pwr_reg_is_ready(struct regulator_dev *rdev)
+static int stm32_pwr_reg_is_ready(struct regulator_dev *rdev)
 {
struct stm32_pwr_reg *priv = rdev_get_drvdata(rdev);
u32 val;
@@ -54,7 +54,7 @@ int stm32_pwr_reg_is_ready(struct regulator_dev *rdev)
return (val & priv->ready_mask);
 }
 
-int stm32_pwr_reg_is_enabled(struct regulator_dev *rdev)
+static int stm32_pwr_reg_is_enabled(struct regulator_dev *rdev)
 {
struct stm32_pwr_reg *priv = rdev_get_drvdata(rdev);
u32 val;
-- 
2.7.4