Re: [PATCH -next] scsi: megaraid_sas: remove set but not used variable 'sge_sz'

[Martin K. Petersen]

YueHaibing,

> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/megaraid/megaraid_sas_base.c: In function 
> megasas_create_frame_pool:
> drivers/scsi/megaraid/megaraid_sas_base.c:4124:6: warning: variable sge_sz 
> set but not used [-Wunused-but-set-variable]
>
> It's not used any more since
> commit 200aed582d61 ("megaraid_sas: endianness related bug fixes and code 
> optimization")

Applied to 5.3/scsi-queue. Thanks.

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: [PATCH -next] scsi: megaraid_sas: remove set but not used variable 'sge_sz'

[Sumit Saxena]

On Sat, May 25, 2019 at 6:07 PM YueHaibing  wrote:
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/megaraid/megaraid_sas_base.c: In function 
> megasas_create_frame_pool:
> drivers/scsi/megaraid/megaraid_sas_base.c:4124:6: warning: variable sge_sz 
> set but not used [-Wunused-but-set-variable]
>
> It's not used any more since
> commit 200aed582d61 ("megaraid_sas: endianness related bug fixes and code 
> optimization")
>
> Signed-off-by: YueHaibing 
Acked-by: Sumit Saxena 

> ---
>  drivers/scsi/megaraid/megaraid_sas_base.c | 11 ---
>  1 file changed, 11 deletions(-)
>
> diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c 
> b/drivers/scsi/megaraid/megaraid_sas_base.c
> index b26991dcf137..25281a2eb424 100644
> --- a/drivers/scsi/megaraid/megaraid_sas_base.c
> +++ b/drivers/scsi/megaraid/megaraid_sas_base.c
> @@ -4121,22 +4121,11 @@ static int megasas_create_frame_pool(struct 
> megasas_instance *instance)
>  {
> int i;
> u16 max_cmd;
> -   u32 sge_sz;
> u32 frame_count;
> struct megasas_cmd *cmd;
>
> max_cmd = instance->max_mfi_cmds;
>
> -   /*
> -* Size of our frame is 64 bytes for MFI frame, followed by max SG
> -* elements and finally SCSI_SENSE_BUFFERSIZE bytes for sense buffer
> -*/
> -   sge_sz = (IS_DMA64) ? sizeof(struct megasas_sge64) :
> -   sizeof(struct megasas_sge32);
> -
> -   if (instance->flag_ieee)
> -   sge_sz = sizeof(struct megasas_sge_skinny);
> -
> /*
>  * For MFI controllers.
>  * max_num_sge = 60
> --
> 2.17.1
>
>

[PATCH -next] scsi: megaraid_sas: remove set but not used variable 'sge_sz'

[YueHaibing]

Fixes gcc '-Wunused-but-set-variable' warning:

drivers/scsi/megaraid/megaraid_sas_base.c: In function 
megasas_create_frame_pool:
drivers/scsi/megaraid/megaraid_sas_base.c:4124:6: warning: variable sge_sz set 
but not used [-Wunused-but-set-variable]

It's not used any more since
commit 200aed582d61 ("megaraid_sas: endianness related bug fixes and code 
optimization")

Signed-off-by: YueHaibing 
---
 drivers/scsi/megaraid/megaraid_sas_base.c | 11 ---
 1 file changed, 11 deletions(-)

diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c 
b/drivers/scsi/megaraid/megaraid_sas_base.c
index b26991dcf137..25281a2eb424 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -4121,22 +4121,11 @@ static int megasas_create_frame_pool(struct 
megasas_instance *instance)
 {
int i;
u16 max_cmd;
-   u32 sge_sz;
u32 frame_count;
struct megasas_cmd *cmd;
 
max_cmd = instance->max_mfi_cmds;
 
-   /*
-* Size of our frame is 64 bytes for MFI frame, followed by max SG
-* elements and finally SCSI_SENSE_BUFFERSIZE bytes for sense buffer
-*/
-   sge_sz = (IS_DMA64) ? sizeof(struct megasas_sge64) :
-   sizeof(struct megasas_sge32);
-
-   if (instance->flag_ieee)
-   sge_sz = sizeof(struct megasas_sge_skinny);
-
/*
 * For MFI controllers.
 * max_num_sge = 60
-- 
2.17.1