Re: [PATCH -next 0/2] leds: add substitutes for /sys/class/leds//trigger
Hi! > Reading /sys/class/leds//trigger returns all available LED triggers. > However, this violates the "one value per file" rule of sysfs. > > This series provides a new /sys/devices/virtual/led-trigger/ directory and > /sys/class/leds//current-trigger. The new api follows the "one value > per file" rule of sysfs. Lets not do this. We'll have to maintain the old interface, anyway, so it does not really help. Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature
[PATCH -next 0/2] leds: add substitutes for /sys/class/leds//trigger
Reading /sys/class/leds//trigger returns all available LED triggers. However, this violates the "one value per file" rule of sysfs. This series provides a new /sys/devices/virtual/led-trigger/ directory and /sys/class/leds//current-trigger. The new api follows the "one value per file" rule of sysfs. This series was previously developed as a part of the series "leds: fix /sys/class/leds//trigger and add new api" [1]. Now this version only contains the new api part. [1] https://lore.kernel.org/r/1567946472-10075-1-git-send-email-akinobu.m...@gmail.com Akinobu Mita (2): leds: add /sys/devices/virtual/led-trigger/ leds: add /sys/class/leds//current-trigger Documentation/ABI/testing/sysfs-class-led | 13 +++ .../ABI/testing/sysfs-devices-virtual-led-trigger | 8 ++ drivers/leds/led-class.c | 10 +++ drivers/leds/led-triggers.c| 95 +- drivers/leds/leds.h| 5 ++ include/linux/leds.h | 3 + 6 files changed, 130 insertions(+), 4 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-devices-virtual-led-trigger Cc: Greg Kroah-Hartman Cc: "Rafael J. Wysocki" Cc: Jacek Anaszewski Cc: Pavel Machek Cc: Dan Murphy -- 2.7.4
