Re: [PATCH -next RESEND] mfd: ene-kb3930: Make symbol 'kb3930_power_off' static

[Lee Jones]

On Mon, 08 Mar 2021, 'Wei Yongjun wrote:

> From: Wei Yongjun 
> 
> The sparse tool complains as follows:
> 
> drivers/mfd/ene-kb3930.c:36:15: warning:
>  symbol 'kb3930_power_off' was not declared. Should it be static?
> 
> This symbol is not used outside of ene-kb3930.c, so this
> commit marks it static.
> 
> Reported-by: Hulk Robot 
> Signed-off-by: Wei Yongjun 
> Acked-by: Lubomir Rintel 

This should have been a Reviewed-by.

> ---
>  drivers/mfd/ene-kb3930.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog

[PATCH -next RESEND] mfd: ene-kb3930: Make symbol 'kb3930_power_off' static

['Wei Yongjun]

From: Wei Yongjun 

The sparse tool complains as follows:

drivers/mfd/ene-kb3930.c:36:15: warning:
 symbol 'kb3930_power_off' was not declared. Should it be static?

This symbol is not used outside of ene-kb3930.c, so this
commit marks it static.

Reported-by: Hulk Robot 
Signed-off-by: Wei Yongjun 
Acked-by: Lubomir Rintel 
---
 drivers/mfd/ene-kb3930.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/mfd/ene-kb3930.c b/drivers/mfd/ene-kb3930.c
index 83243e668e3f..1b73318d1f1f 100644
--- a/drivers/mfd/ene-kb3930.c
+++ b/drivers/mfd/ene-kb3930.c
@@ -33,7 +33,7 @@ struct kb3930 {
struct gpio_descs *off_gpios;
 };
 
-struct kb3930 *kb3930_power_off;
+static struct kb3930 *kb3930_power_off;
 
 #define EC_GPIO_WAVE   0
 #define EC_GPIO_OFF_MODE   1