Re: [PATCH -next v2] tools/testing/nvdimm: Make symbol '__nfit_test_ioremap' static

[Dan Williams]

On Tue, Apr 20, 2021 at 12:31 AM Zou Wei  wrote:
>
> The sparse tool complains as follows:
>
> tools/testing/nvdimm/test/iomap.c:65:14: warning:
>  symbol '__nfit_test_ioremap' was not declared. Should it be static?
>
> This symbol is not used outside of iomap.c, so this
> commit marks it static.
>
> Reported-by: Hulk Robot 
> Signed-off-by: Zou Wei 

Looks good to me, thanks.

[PATCH -next v2] tools/testing/nvdimm: Make symbol '__nfit_test_ioremap' static

[Zou Wei]

The sparse tool complains as follows:

tools/testing/nvdimm/test/iomap.c:65:14: warning:
 symbol '__nfit_test_ioremap' was not declared. Should it be static?

This symbol is not used outside of iomap.c, so this
commit marks it static.

Reported-by: Hulk Robot 
Signed-off-by: Zou Wei 
---
 tools/testing/nvdimm/test/iomap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/nvdimm/test/iomap.c 
b/tools/testing/nvdimm/test/iomap.c
index c62d372..ed563bd 100644
--- a/tools/testing/nvdimm/test/iomap.c
+++ b/tools/testing/nvdimm/test/iomap.c
@@ -62,7 +62,7 @@ struct nfit_test_resource *get_nfit_res(resource_size_t 
resource)
 }
 EXPORT_SYMBOL(get_nfit_res);
 
-void __iomem *__nfit_test_ioremap(resource_size_t offset, unsigned long size,
+static void __iomem *__nfit_test_ioremap(resource_size_t offset, unsigned long 
size,
void __iomem *(*fallback_fn)(resource_size_t, unsigned long))
 {
struct nfit_test_resource *nfit_res = get_nfit_res(offset);
-- 
2.6.2