Re: [PATCH -rt] whitespace cleanup for 2.6.20-rc5-rt7
Satoru Takeuchi wrote: At Tue, 23 Jan 2007 00:42:31 +0100, Richard Knutsson wrote: Michal Piotrowski wrote: How about this script? "d) Ensure that your patch does not add new trailing whitespace. The below script will fix up your patch by stripping off such whitespace. #!/bin/sh strip1() { TMP=$(mktemp /tmp/XX) cp "$1" "$TMP" sed -e '/^+/s/[ ]*$//' <"$TMP" >"$1" rm "$TMP" } for i in "$@" do strip1 "$i" done " http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt I believe: for i in "$@"; do \ sed --in-place -e "s/[ ]+$//" "$i" done will do as well... Hi Richard, IIRC, `+' is extended regex, so -r option is needed: sed -r --in-place -e "s/[ ]+$//" "$i" Yes, so right! Just because I did not understood why to use -e instead of -r (and even commented on it), I put an -e... Thanks for pointing it out :) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -rt] whitespace cleanup for 2.6.20-rc5-rt7
Satoru Takeuchi wrote: At Tue, 23 Jan 2007 00:42:31 +0100, Richard Knutsson wrote: Michal Piotrowski wrote: How about this script? d) Ensure that your patch does not add new trailing whitespace. The below script will fix up your patch by stripping off such whitespace. #!/bin/sh strip1() { TMP=$(mktemp /tmp/XX) cp $1 $TMP sed -e '/^+/s/[ ]*$//' $TMP $1 rm $TMP } for i in $@ do strip1 $i done http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt I believe: for i in $@; do \ sed --in-place -e s/[ ]+$// $i done will do as well... Hi Richard, IIRC, `+' is extended regex, so -r option is needed: sed -r --in-place -e s/[ ]+$// $i Yes, so right! Just because I did not understood why to use -e instead of -r (and even commented on it), I put an -e... Thanks for pointing it out :) - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -rt] whitespace cleanup for 2.6.20-rc5-rt7
At Tue, 23 Jan 2007 00:42:31 +0100, Richard Knutsson wrote: > > Michal Piotrowski wrote: > > How about this script? > > > > "d) Ensure that your patch does not add new trailing whitespace. The > > below > > script will fix up your patch by stripping off such whitespace. > > > > #!/bin/sh > > > > strip1() > > { > > TMP=$(mktemp /tmp/XX) > > cp "$1" "$TMP" > > sed -e '/^+/s/[ ]*$//' <"$TMP" >"$1" > > rm "$TMP" > > } > > > > for i in "$@" > > do > > strip1 "$i" > > done > > " > > http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt > I believe: > > for i in "$@"; do \ > sed --in-place -e "s/[ ]+$//" "$i" > done > > will do as well... Hi Richard, IIRC, `+' is extended regex, so -r option is needed: sed -r --in-place -e "s/[]+$//" "$i" Satoru Takeuchi > > Richard Knutsson > > - > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to [EMAIL PROTECTED] > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -rt] whitespace cleanup for 2.6.20-rc5-rt7
Michal Piotrowski wrote: How about this script? "d) Ensure that your patch does not add new trailing whitespace. The below script will fix up your patch by stripping off such whitespace. #!/bin/sh strip1() { TMP=$(mktemp /tmp/XX) cp "$1" "$TMP" sed -e '/^+/s/[ ]*$//' <"$TMP" >"$1" rm "$TMP" } for i in "$@" do strip1 "$i" done " http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt I believe: for i in "$@"; do \ sed --in-place -e "s/[ ]+$//" "$i" done will do as well... Richard Knutsson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -rt] whitespace cleanup for 2.6.20-rc5-rt7
On 22/01/07, Ingo Molnar <[EMAIL PROTECTED]> wrote: * Noah Watkins <[EMAIL PROTECTED]> wrote: > fixes trailing whitespace and spaces before tab indents in > 2.6.20-rc5-rt7 as reported with: git-apply --whitespace=error-all thanks. Did you do the patch manually, or do you have a script for that perhaps? How about this script? "d) Ensure that your patch does not add new trailing whitespace. The below script will fix up your patch by stripping off such whitespace. #!/bin/sh strip1() { TMP=$(mktemp /tmp/XX) cp "$1" "$TMP" sed -e '/^+/s/[ ]*$//' <"$TMP" >"$1" rm "$TMP" } for i in "$@" do strip1 "$i" done " http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt Regards, Michal -- Michal K. K. Piotrowski LTG - Linux Testers Group (http://www.stardust.webpages.pl/ltg/) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -rt] whitespace cleanup for 2.6.20-rc5-rt7
No script. Does trailing whitespace and spaces before tab indents seem to cover all the whitespace problem scenarios? -noah On Mon, Jan 22, 2007 at 08:58:36PM +0100, Ingo Molnar wrote: > > * Noah Watkins <[EMAIL PROTECTED]> wrote: > > > fixes trailing whitespace and spaces before tab indents in > > 2.6.20-rc5-rt7 as reported with: git-apply --whitespace=error-all > > thanks. Did you do the patch manually, or do you have a script for that > perhaps? > > Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -rt] whitespace cleanup for 2.6.20-rc5-rt7
* Noah Watkins <[EMAIL PROTECTED]> wrote: > fixes trailing whitespace and spaces before tab indents in > 2.6.20-rc5-rt7 as reported with: git-apply --whitespace=error-all thanks. Did you do the patch manually, or do you have a script for that perhaps? Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -rt] whitespace cleanup for 2.6.20-rc5-rt7
* Noah Watkins [EMAIL PROTECTED] wrote: fixes trailing whitespace and spaces before tab indents in 2.6.20-rc5-rt7 as reported with: git-apply --whitespace=error-all thanks. Did you do the patch manually, or do you have a script for that perhaps? Ingo - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -rt] whitespace cleanup for 2.6.20-rc5-rt7
No script. Does trailing whitespace and spaces before tab indents seem to cover all the whitespace problem scenarios? -noah On Mon, Jan 22, 2007 at 08:58:36PM +0100, Ingo Molnar wrote: * Noah Watkins [EMAIL PROTECTED] wrote: fixes trailing whitespace and spaces before tab indents in 2.6.20-rc5-rt7 as reported with: git-apply --whitespace=error-all thanks. Did you do the patch manually, or do you have a script for that perhaps? Ingo - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -rt] whitespace cleanup for 2.6.20-rc5-rt7
On 22/01/07, Ingo Molnar [EMAIL PROTECTED] wrote: * Noah Watkins [EMAIL PROTECTED] wrote: fixes trailing whitespace and spaces before tab indents in 2.6.20-rc5-rt7 as reported with: git-apply --whitespace=error-all thanks. Did you do the patch manually, or do you have a script for that perhaps? How about this script? d) Ensure that your patch does not add new trailing whitespace. The below script will fix up your patch by stripping off such whitespace. #!/bin/sh strip1() { TMP=$(mktemp /tmp/XX) cp $1 $TMP sed -e '/^+/s/[ ]*$//' $TMP $1 rm $TMP } for i in $@ do strip1 $i done http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt Regards, Michal -- Michal K. K. Piotrowski LTG - Linux Testers Group (http://www.stardust.webpages.pl/ltg/) - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -rt] whitespace cleanup for 2.6.20-rc5-rt7
Michal Piotrowski wrote: How about this script? d) Ensure that your patch does not add new trailing whitespace. The below script will fix up your patch by stripping off such whitespace. #!/bin/sh strip1() { TMP=$(mktemp /tmp/XX) cp $1 $TMP sed -e '/^+/s/[ ]*$//' $TMP $1 rm $TMP } for i in $@ do strip1 $i done http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt I believe: for i in $@; do \ sed --in-place -e s/[ ]+$// $i done will do as well... Richard Knutsson - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH -rt] whitespace cleanup for 2.6.20-rc5-rt7
At Tue, 23 Jan 2007 00:42:31 +0100, Richard Knutsson wrote: Michal Piotrowski wrote: How about this script? d) Ensure that your patch does not add new trailing whitespace. The below script will fix up your patch by stripping off such whitespace. #!/bin/sh strip1() { TMP=$(mktemp /tmp/XX) cp $1 $TMP sed -e '/^+/s/[ ]*$//' $TMP $1 rm $TMP } for i in $@ do strip1 $i done http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt I believe: for i in $@; do \ sed --in-place -e s/[ ]+$// $i done will do as well... Hi Richard, IIRC, `+' is extended regex, so -r option is needed: sed -r --in-place -e s/[]+$// $i Satoru Takeuchi Richard Knutsson - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/ - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH -rt] whitespace cleanup for 2.6.20-rc5-rt7
fixes trailing whitespace and spaces before tab indents in 2.6.20-rc5-rt7 as reported with: git-apply --whitespace=error-all --- arch/arm/mach-omap1/time.c|2 +- arch/i386/kernel/entry.S |2 +- arch/i386/kernel/reboot.c |2 +- arch/ia64/Kconfig |4 ++-- arch/ia64/kernel/fsys.S |2 +- arch/ia64/kernel/time.c |4 ++-- arch/x86_64/kernel/entry.S|2 +- arch/x86_64/kernel/hpet.c |2 +- arch/x86_64/kernel/reboot.c |2 +- arch/x86_64/kernel/smpboot.c |8 arch/x86_64/kernel/tsc.c |8 arch/x86_64/kernel/vsyscall.c |2 +- drivers/char/lpptest.c|2 +- include/asm-arm/atomic.h |2 +- include/asm-generic/vmlinux.lds.h |4 ++-- include/linux/irq.h |6 +++--- include/linux/mutex.h |2 +- kernel/fork.c |6 +++--- kernel/futex.c|4 ++-- kernel/hrtimer.c |2 +- kernel/latency_trace.c|6 +++--- kernel/spinlock.c |2 +- kernel/workqueue.c|2 +- mm/migrate.c |2 +- mm/slab.c | 14 +++--- 25 files changed, 47 insertions(+), 47 deletions(-) diff --git a/arch/arm/mach-omap1/time.c b/arch/arm/mach-omap1/time.c index 7baf0df..85f9f5e 100644 --- a/arch/arm/mach-omap1/time.c +++ b/arch/arm/mach-omap1/time.c @@ -105,7 +105,7 @@ static inline unsigned long omap_mpu_tim static inline void omap_mpu_set_autoreset(int nr) { - volatile omap_mpu_timer_regs_t* timer = omap_mpu_timer_base(nr); + volatile omap_mpu_timer_regs_t* timer = omap_mpu_timer_base(nr); timer->cntl = timer->cntl | MPU_TIMER_AR; } diff --git a/arch/i386/kernel/entry.S b/arch/i386/kernel/entry.S index ce8a092..33d6b80 100644 --- a/arch/i386/kernel/entry.S +++ b/arch/i386/kernel/entry.S @@ -272,7 +272,7 @@ need_resched: jz restore_nocheck testl $IF_MASK,PT_EFLAGS(%esp) # interrupts off (exception path) ? jz restore_nocheck - DISABLE_INTERRUPTS(CLBR_ANY) + DISABLE_INTERRUPTS(CLBR_ANY) call preempt_schedule_irq jmp need_resched diff --git a/arch/i386/kernel/reboot.c b/arch/i386/kernel/reboot.c index 5f81e80..a3e7410 100644 --- a/arch/i386/kernel/reboot.c +++ b/arch/i386/kernel/reboot.c @@ -327,7 +327,7 @@ void machine_emergency_restart(void) asm volatile ( "1: .byte 0x0f, 0x01, 0xc4 \n" /* vmxoff */ "2: \n" - ".section __ex_table,\"a\" \n" + ".section __ex_table,\"a\" \n" " .align 4\n" " .long 1b,2b \n" ".previous \n" diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig index 333049c..a1a6bc3 100644 --- a/arch/ia64/Kconfig +++ b/arch/ia64/Kconfig @@ -300,7 +300,7 @@ config HIGH_RES_RESOLUTION choice prompt "Clock source" depends on HIGH_RES_TIMERS - default HIGH_RES_TIMER_ITC + default HIGH_RES_TIMER_ITC help This option allows you to choose the hardware source in charge of generating high precision interruptions on your system. @@ -308,7 +308,7 @@ choice ITC Interval Time Counter 1/CPU clock - HPET High Precision Event Timer ~ (XXX:have to check the spec) + HPET High Precision Event Timer ~ (XXX:have to check the spec) The ITC timer is available on all the ia64 computers because it is integrated directly into the processor. However it may not diff --git a/arch/ia64/kernel/fsys.S b/arch/ia64/kernel/fsys.S index 7b94c34..2abf920 100644 --- a/arch/ia64/kernel/fsys.S +++ b/arch/ia64/kernel/fsys.S @@ -219,7 +219,7 @@ ENTRY(fsys_gettimeofday) (p6)br.cond.spnt.few .fail_einval // deferred branch ;; ld8 r30 = [r10] // clocksource->mmio_ptr - movl r19 = itc_lastcycle + movl r19 = itc_lastcycle add r23 = IA64_CLOCKSOURCE_SHIFT_OFFSET,r20 cmp.ne p6, p0 = 0, r2 // Fallback if work is scheduled (p6)br.cond.spnt.many fsys_fallback_syscall diff --git a/arch/ia64/kernel/time.c b/arch/ia64/kernel/time.c index 983ef26..4fc3670 100644 --- a/arch/ia64/kernel/time.c +++ b/arch/ia64/kernel/time.c @@ -262,10 +262,10 @@ ia64_init_itm (void) ia64_cpu_local_tick(); if (!clocksource_itc_p) { - /* Sort out mult/shift values: */ + /* Sort out mult/shift values: */ clocksource_itc.mult = clocksource_hz2mult(local_cpu_data->itc_freq, clocksource_itc.shift); -
[PATCH -rt] whitespace cleanup for 2.6.20-rc5-rt7
fixes trailing whitespace and spaces before tab indents in 2.6.20-rc5-rt7 as reported with: git-apply --whitespace=error-all --- arch/arm/mach-omap1/time.c|2 +- arch/i386/kernel/entry.S |2 +- arch/i386/kernel/reboot.c |2 +- arch/ia64/Kconfig |4 ++-- arch/ia64/kernel/fsys.S |2 +- arch/ia64/kernel/time.c |4 ++-- arch/x86_64/kernel/entry.S|2 +- arch/x86_64/kernel/hpet.c |2 +- arch/x86_64/kernel/reboot.c |2 +- arch/x86_64/kernel/smpboot.c |8 arch/x86_64/kernel/tsc.c |8 arch/x86_64/kernel/vsyscall.c |2 +- drivers/char/lpptest.c|2 +- include/asm-arm/atomic.h |2 +- include/asm-generic/vmlinux.lds.h |4 ++-- include/linux/irq.h |6 +++--- include/linux/mutex.h |2 +- kernel/fork.c |6 +++--- kernel/futex.c|4 ++-- kernel/hrtimer.c |2 +- kernel/latency_trace.c|6 +++--- kernel/spinlock.c |2 +- kernel/workqueue.c|2 +- mm/migrate.c |2 +- mm/slab.c | 14 +++--- 25 files changed, 47 insertions(+), 47 deletions(-) diff --git a/arch/arm/mach-omap1/time.c b/arch/arm/mach-omap1/time.c index 7baf0df..85f9f5e 100644 --- a/arch/arm/mach-omap1/time.c +++ b/arch/arm/mach-omap1/time.c @@ -105,7 +105,7 @@ static inline unsigned long omap_mpu_tim static inline void omap_mpu_set_autoreset(int nr) { - volatile omap_mpu_timer_regs_t* timer = omap_mpu_timer_base(nr); + volatile omap_mpu_timer_regs_t* timer = omap_mpu_timer_base(nr); timer-cntl = timer-cntl | MPU_TIMER_AR; } diff --git a/arch/i386/kernel/entry.S b/arch/i386/kernel/entry.S index ce8a092..33d6b80 100644 --- a/arch/i386/kernel/entry.S +++ b/arch/i386/kernel/entry.S @@ -272,7 +272,7 @@ need_resched: jz restore_nocheck testl $IF_MASK,PT_EFLAGS(%esp) # interrupts off (exception path) ? jz restore_nocheck - DISABLE_INTERRUPTS(CLBR_ANY) + DISABLE_INTERRUPTS(CLBR_ANY) call preempt_schedule_irq jmp need_resched diff --git a/arch/i386/kernel/reboot.c b/arch/i386/kernel/reboot.c index 5f81e80..a3e7410 100644 --- a/arch/i386/kernel/reboot.c +++ b/arch/i386/kernel/reboot.c @@ -327,7 +327,7 @@ void machine_emergency_restart(void) asm volatile ( 1: .byte 0x0f, 0x01, 0xc4 \n /* vmxoff */ 2: \n - .section __ex_table,\a\ \n + .section __ex_table,\a\ \n .align 4\n .long 1b,2b \n .previous \n diff --git a/arch/ia64/Kconfig b/arch/ia64/Kconfig index 333049c..a1a6bc3 100644 --- a/arch/ia64/Kconfig +++ b/arch/ia64/Kconfig @@ -300,7 +300,7 @@ config HIGH_RES_RESOLUTION choice prompt Clock source depends on HIGH_RES_TIMERS - default HIGH_RES_TIMER_ITC + default HIGH_RES_TIMER_ITC help This option allows you to choose the hardware source in charge of generating high precision interruptions on your system. @@ -308,7 +308,7 @@ choice timer resolution ITC Interval Time Counter 1/CPU clock - HPET High Precision Event Timer ~ (XXX:have to check the spec) + HPET High Precision Event Timer ~ (XXX:have to check the spec) The ITC timer is available on all the ia64 computers because it is integrated directly into the processor. However it may not diff --git a/arch/ia64/kernel/fsys.S b/arch/ia64/kernel/fsys.S index 7b94c34..2abf920 100644 --- a/arch/ia64/kernel/fsys.S +++ b/arch/ia64/kernel/fsys.S @@ -219,7 +219,7 @@ ENTRY(fsys_gettimeofday) (p6)br.cond.spnt.few .fail_einval // deferred branch ;; ld8 r30 = [r10] // clocksource-mmio_ptr - movl r19 = itc_lastcycle + movl r19 = itc_lastcycle add r23 = IA64_CLOCKSOURCE_SHIFT_OFFSET,r20 cmp.ne p6, p0 = 0, r2 // Fallback if work is scheduled (p6)br.cond.spnt.many fsys_fallback_syscall diff --git a/arch/ia64/kernel/time.c b/arch/ia64/kernel/time.c index 983ef26..4fc3670 100644 --- a/arch/ia64/kernel/time.c +++ b/arch/ia64/kernel/time.c @@ -262,10 +262,10 @@ ia64_init_itm (void) ia64_cpu_local_tick(); if (!clocksource_itc_p) { - /* Sort out mult/shift values: */ + /* Sort out mult/shift values: */ clocksource_itc.mult = clocksource_hz2mult(local_cpu_data-itc_freq, clocksource_itc.shift); -