Re: [PATCH 0/2] mmc: dw_mmc: fix the wrong operation for reset controller

[Jaehoon Chung]

Hi,

On 11/02/2016 06:56 AM, John Stultz wrote:
> On Sun, Oct 30, 2016 at 7:49 PM, Jaehoon Chung  wrote:
>> This patch adds the "reset-names" as reset controller for dwmmc controller.
>> Linaro guys had reported the issue about booting stuck.
>>
>> Some SoCs are enabled the CONFIG_RESET_CONTROLLER.
>> then dwmmc controller are waiting for getting reset controller.
>> But if doesn't define "resets" property in device-tree, it should be stuck.
>>
>> If use the reset-names as reset controller for dwmmc controller,
>> it's more stable than now.
>> This commit is related with the below commit.
>>
>> Fixes: d6786fefe816 ("mmc: dw_mmc: add reset support to dwmmc host 
>> controller")
> 
> So I wasn't hit by the issue, as I don't tend to boot from SD on my
> hikey, but I did run these patches and I'm not seeing any issues with
> my Android environment.
> 
> So for what its worth:
> Acked-by: John Stultz 

Applied on my repository (fixes branch).

Best Regards,
Jaehoon Chung

> 
> thanks
> -john
> 
> 
> 

Re: [PATCH 0/2] mmc: dw_mmc: fix the wrong operation for reset controller

[Jaehoon Chung]

Hi,

On 11/02/2016 06:56 AM, John Stultz wrote:
> On Sun, Oct 30, 2016 at 7:49 PM, Jaehoon Chung  wrote:
>> This patch adds the "reset-names" as reset controller for dwmmc controller.
>> Linaro guys had reported the issue about booting stuck.
>>
>> Some SoCs are enabled the CONFIG_RESET_CONTROLLER.
>> then dwmmc controller are waiting for getting reset controller.
>> But if doesn't define "resets" property in device-tree, it should be stuck.
>>
>> If use the reset-names as reset controller for dwmmc controller,
>> it's more stable than now.
>> This commit is related with the below commit.
>>
>> Fixes: d6786fefe816 ("mmc: dw_mmc: add reset support to dwmmc host 
>> controller")
> 
> So I wasn't hit by the issue, as I don't tend to boot from SD on my
> hikey, but I did run these patches and I'm not seeing any issues with
> my Android environment.
> 
> So for what its worth:
> Acked-by: John Stultz 

Applied on my repository (fixes branch).

Best Regards,
Jaehoon Chung

> 
> thanks
> -john
> 
> 
> 

Re: [PATCH 0/2] mmc: dw_mmc: fix the wrong operation for reset controller

[John Stultz]

On Sun, Oct 30, 2016 at 7:49 PM, Jaehoon Chung  wrote:
> This patch adds the "reset-names" as reset controller for dwmmc controller.
> Linaro guys had reported the issue about booting stuck.
>
> Some SoCs are enabled the CONFIG_RESET_CONTROLLER.
> then dwmmc controller are waiting for getting reset controller.
> But if doesn't define "resets" property in device-tree, it should be stuck.
>
> If use the reset-names as reset controller for dwmmc controller,
> it's more stable than now.
> This commit is related with the below commit.
>
> Fixes: d6786fefe816 ("mmc: dw_mmc: add reset support to dwmmc host 
> controller")

So I wasn't hit by the issue, as I don't tend to boot from SD on my
hikey, but I did run these patches and I'm not seeing any issues with
my Android environment.

So for what its worth:
Acked-by: John Stultz 

thanks
-john

Re: [PATCH 0/2] mmc: dw_mmc: fix the wrong operation for reset controller

[John Stultz]

On Sun, Oct 30, 2016 at 7:49 PM, Jaehoon Chung  wrote:
> This patch adds the "reset-names" as reset controller for dwmmc controller.
> Linaro guys had reported the issue about booting stuck.
>
> Some SoCs are enabled the CONFIG_RESET_CONTROLLER.
> then dwmmc controller are waiting for getting reset controller.
> But if doesn't define "resets" property in device-tree, it should be stuck.
>
> If use the reset-names as reset controller for dwmmc controller,
> it's more stable than now.
> This commit is related with the below commit.
>
> Fixes: d6786fefe816 ("mmc: dw_mmc: add reset support to dwmmc host 
> controller")

So I wasn't hit by the issue, as I don't tend to boot from SD on my
hikey, but I did run these patches and I'm not seeing any issues with
my Android environment.

So for what its worth:
Acked-by: John Stultz 

thanks
-john

[PATCH 0/2] mmc: dw_mmc: fix the wrong operation for reset controller

[Jaehoon Chung]

This patch adds the "reset-names" as reset controller for dwmmc controller.
Linaro guys had reported the issue about booting stuck.

Some SoCs are enabled the CONFIG_RESET_CONTROLLER.
then dwmmc controller are waiting for getting reset controller.
But if doesn't define "resets" property in device-tree, it should be stuck.

If use the reset-names as reset controller for dwmmc controller,
it's more stable than now.
This commit is related with the below commit.

Fixes: d6786fefe816 ("mmc: dw_mmc: add reset support to dwmmc host controller")

Jaehoon Chung (2):
  Documentation: synopsys-dw-mshc: add binding for reset-names
  mmc: dw_mmc: add the "reset" as name of reset controller

 Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt | 5 +
 drivers/mmc/host/dw_mmc.c  | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

-- 
2.10.1

[PATCH 0/2] mmc: dw_mmc: fix the wrong operation for reset controller

[Jaehoon Chung]

This patch adds the "reset-names" as reset controller for dwmmc controller.
Linaro guys had reported the issue about booting stuck.

Some SoCs are enabled the CONFIG_RESET_CONTROLLER.
then dwmmc controller are waiting for getting reset controller.
But if doesn't define "resets" property in device-tree, it should be stuck.

If use the reset-names as reset controller for dwmmc controller,
it's more stable than now.
This commit is related with the below commit.

Fixes: d6786fefe816 ("mmc: dw_mmc: add reset support to dwmmc host controller")

Jaehoon Chung (2):
  Documentation: synopsys-dw-mshc: add binding for reset-names
  mmc: dw_mmc: add the "reset" as name of reset controller

 Documentation/devicetree/bindings/mmc/synopsys-dw-mshc.txt | 5 +
 drivers/mmc/host/dw_mmc.c  | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

-- 
2.10.1