Re: [PATCH 0/3] [GIT PULL] tracing: Minor fixes for 5.1-rc2
On Tue, 26 Mar 2019 14:29:27 -0700 Linus Torvalds wrote: > On Tue, Mar 26, 2019 at 11:48 AM Steven Rostedt wrote: > > > > Should I work on changing this? > > I don't personally much care, but the pr-tracker-bot clearly does. > > If you don't care about the automated "it's been pulled" message, that > doesn't matter, of course. I'm subscribed to your git tree and filter out all updates for my signed off by. An then I get those emails. So I get the "Pulled" message regardless. > > That said, I'd almost prefer to get just the regular pull request > without the patches. If the complete patch is small, it's often nice > to see that _in_ the pull request (at the bottom), but I don't > generally need or want the individual patches themselves as separate > emails (unless there's some particular reason you want me to comment > on something, or apply them directly as patches). It's not really for you, but more for transparency in general. I have a rule that I don't push anything to you that I haven't personally sent to LKML as a separate patch. It's not a big deal. I could make this a two step process, and send these as my "for-next" patches so that people (including the authors of the patch) know that I'm sending them upstream. -- Steve
Re: [PATCH 0/3] [GIT PULL] tracing: Minor fixes for 5.1-rc2
On Tue, Mar 26, 2019 at 11:48 AM Steven Rostedt wrote: > > Should I work on changing this? I don't personally much care, but the pr-tracker-bot clearly does. If you don't care about the automated "it's been pulled" message, that doesn't matter, of course. That said, I'd almost prefer to get just the regular pull request without the patches. If the complete patch is small, it's often nice to see that _in_ the pull request (at the bottom), but I don't generally need or want the individual patches themselves as separate emails (unless there's some particular reason you want me to comment on something, or apply them directly as patches). Linus
Re: [PATCH 0/3] [GIT PULL] tracing: Minor fixes for 5.1-rc2
On Tue, 26 Mar 2019 10:48:44 -0700 Linus Torvalds wrote: > On Tue, Mar 26, 2019 at 5:42 AM Steven Rostedt wrote: > > > > Please pull the latest trace-v5.1-rc2 tree, which can be found at: > > Pulled and pushed out, but for some reason the pr-tracker-bot doesn't > seem to have reacted. > > Presumably there's something in your git pull message that means it > doesn't trigger. > > And I suspect I know what it is: the patch that your subject line > starts with "[PATCH..]" instead of "[GIT PULL..]" > Interesting. This is how I've always sent patches to you via quilt. I usually don't put fixes sent to me through for-next, as I haven't been convinced that that helps any. I make it a requirement to send any patch I push into my tree for merging as a separate patch. As I usually do that when I push to linux-next, if I send directly to you, I will then send them individually. The point being, when I send individual patches directly to you (and not as a single email pull request), I use quilt sendmail. Which will append the "[PATCH 0/x]" before my cover message subject. Should I work on changing this? -- Steve
Re: [PATCH 0/3] [GIT PULL] tracing: Minor fixes for 5.1-rc2
On Tue, Mar 26, 2019 at 5:42 AM Steven Rostedt wrote: > > Please pull the latest trace-v5.1-rc2 tree, which can be found at: Pulled and pushed out, but for some reason the pr-tracker-bot doesn't seem to have reacted. Presumably there's something in your git pull message that means it doesn't trigger. And I suspect I know what it is: the patch that your subject line starts with "[PATCH..]" instead of "[GIT PULL..]" Linus
[PATCH 0/3] [GIT PULL] tracing: Minor fixes for 5.1-rc2
Linus, Three small fixes: - A fix to a double free in the histogram code - Uninitialized variable fix - Use NULL instead of zero fix and spelling fixes Please pull the latest trace-v5.1-rc2 tree, which can be found at: git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git trace-v5.1-rc2 Tag SHA1: ed41a01c516cdb7f43a2e0fde385f94f06dff5ff Head SHA1: 9efb85c5cfac7e1f0caae4471446d936ff2163fe Frank Rowand (1): tracing: initialize variable in create_dyn_event() Hariprasad Kelam (1): ftrace: Fix warning using plain integer as NULL & spelling corrections Tom Zanussi (1): tracing: Remove unnecessary var_ref destroy in track_data_destroy() kernel/trace/ftrace.c| 12 ++-- kernel/trace/trace_dynevent.c| 2 +- kernel/trace/trace_events_hist.c | 1 - 3 files changed, 7 insertions(+), 8 deletions(-)
