[PATCH 0/3] A few hist trigger fixes
From: Tom Zanussi Hi Steve, Here's a fix for a problem I found with the hist trigger snapshot action related to the refactoring in the later versions of the patchset ('[PATCH 3/3] tracing: Add a check_val() check before updating cond_snapshot() track_val'). I also added v2 of 2 other patches that I previously submitted [1] but realized hadn't gotten picked up. ('[PATCH v2 1/3] tracing: Prevent hist_field_var_ref() from accessing NULL tracing_map_elts' and '[PATCH v2 2/3] tracing: Check keys for variable references in expressions too'). One of them I had to rebase ('[PATCH v2 2/3] tracing: Check keys for variable references in expressions too') because of the error_log changes since then, but the original ones still apply to versions before that). So in summary, all of these patches apply to current ftrace/core, while only '[PATCH 3/3] tracing: Add a check_val() check before updating cond_snapshot() track_val' and the previous 2 original patches in [1] apply to mainline. Thanks, Tom [1] https://lore.kernel.org/lkml/cover.1541687121.git.tom.zanu...@linux.intel.com/ The following changes since commit c8faaa4c594f55ddf903d61180029a3ea1da5286: rcu: validate arguments for rcu tracepoints (2019-04-03 08:26:38 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git ftrace/key-ref-fix-v2 Tom Zanussi (3): tracing: Prevent hist_field_var_ref() from accessing NULL tracing_map_elts tracing: Check keys for variable references in expressions too tracing: Add a check_val() check before updating cond_snapshot() track_val kernel/trace/trace_events_hist.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) -- 2.14.1
Re: [PATCH 0/3] A few hist trigger fixes
On Thu, 26 Apr 2018 20:04:46 -0500 Tom Zanussiwrote: > Hi Steve, > > Here are a few patches that fix some problems found when testing the > hist trigger inter-event (e.g. latency) support patches. > > The first fixes a problem I noticed when printing flags. > > The remaining two add some hist_err() calls for fields, the first > reported by Masami, the second something I noticed when fixing the > first. > They look good and I queued them up. Thanks! -- Steve
Re: [PATCH 0/3] A few hist trigger fixes
On Thu, 26 Apr 2018 20:04:46 -0500 Tom Zanussi wrote: > Hi Steve, > > Here are a few patches that fix some problems found when testing the > hist trigger inter-event (e.g. latency) support patches. > > The first fixes a problem I noticed when printing flags. > > The remaining two add some hist_err() calls for fields, the first > reported by Masami, the second something I noticed when fixing the > first. > They look good and I queued them up. Thanks! -- Steve
[PATCH 0/3] A few hist trigger fixes
Hi Steve, Here are a few patches that fix some problems found when testing the hist trigger inter-event (e.g. latency) support patches. The first fixes a problem I noticed when printing flags. The remaining two add some hist_err() calls for fields, the first reported by Masami, the second something I noticed when fixing the first. Thanks, Tom The following changes since commit 0566e40ce7c493d39006cdd7edf17bfdc52eb2ac: tracing: initcall: Ordered comparison of function pointers (2018-04-26 15:02:46 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git ftrace/hist-fixes-1 Tom Zanussi (3): tracing: Restore proper field flag printing when displaying triggers tracing: Add field parsing hist error for hist triggers tracing: Add field modifier parsing hist error for hist triggers kernel/trace/trace_events_hist.c | 12 1 file changed, 12 insertions(+) -- 1.9.3
[PATCH 0/3] A few hist trigger fixes
Hi Steve, Here are a few patches that fix some problems found when testing the hist trigger inter-event (e.g. latency) support patches. The first fixes a problem I noticed when printing flags. The remaining two add some hist_err() calls for fields, the first reported by Masami, the second something I noticed when fixing the first. Thanks, Tom The following changes since commit 0566e40ce7c493d39006cdd7edf17bfdc52eb2ac: tracing: initcall: Ordered comparison of function pointers (2018-04-26 15:02:46 -0400) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/zanussi/linux-trace.git ftrace/hist-fixes-1 Tom Zanussi (3): tracing: Restore proper field flag printing when displaying triggers tracing: Add field parsing hist error for hist triggers tracing: Add field modifier parsing hist error for hist triggers kernel/trace/trace_events_hist.c | 12 1 file changed, 12 insertions(+) -- 1.9.3