Re: [PATCH 0/3] staging: vchiq: fix completion routines & semaphores
On Wed, Dec 12, 2018 at 7:54 PM Nicolas Saenz Julienne wrote: > > As pointed out by Arnd Bergman[1] there where some issues on how I > converted semaphores to completion routines. I wasn't aware of a > macro override happening in vchiq_killable.h, which was changing > down_interruptible()'s meaning. > > This patch changes all completions so they use the proper APIs and gets > rid of vchiq_killable.h. I took into account Arnd's commit to avoid > merge conflicts. > Reviewed-by: Arnd Bergmann Thanks for the follow-up! Arnd
[PATCH 0/3] staging: vchiq: fix completion routines & semaphores
As pointed out by Arnd Bergman[1] there where some issues on how I converted semaphores to completion routines. I wasn't aware of a macro override happening in vchiq_killable.h, which was changing down_interruptible()'s meaning. This patch changes all completions so they use the proper APIs and gets rid of vchiq_killable.h. I took into account Arnd's commit to avoid merge conflicts. [1] https://www.spinics.net/lists/arm-kernel/msg694422.html === Nicolas Saenz Julienne (3): staging: vchiq: switch to wait_for_completion_killable staging: vchiq_2835_arm: quit using custom down_interruptible() staging: vchiq: delete vchiq_killable.h .../interface/vchiq_arm/vchiq_2835_arm.c | 3 +- .../interface/vchiq_arm/vchiq_arm.c | 22 .../interface/vchiq_arm/vchiq_connected.c | 1 - .../interface/vchiq_arm/vchiq_core.c | 22 .../interface/vchiq_arm/vchiq_killable.h | 55 --- .../interface/vchiq_arm/vchiq_util.c | 7 +-- 6 files changed, 24 insertions(+), 86 deletions(-) delete mode 100644 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_killable.h -- 2.19.2
