Re: [PATCH 0/3] vmalloc enhancements
On 3/29/19 11:07 PM, Roman Gushchin wrote: >> Roman Gushchin (3): >> mm: refactor __vunmap() to avoid duplicated call to find_vm_area() >> mm: separate memory allocation and actual work in alloc_vmap_area() >> mm: show number of vmalloc pages in /proc/meminfo >> >> fs/proc/meminfo.c | 2 +- >> include/linux/vmalloc.h | 2 + >> mm/vmalloc.c| 107 ++-- >> 3 files changed, 73 insertions(+), 38 deletions(-) >> >> -- >> 2.20.1 >> > > Ping. Any comments/suggestions/objections? I suspect my questions for 3/3 effectively blocked this, so now it should be unblocked. Haven't checked how this is affected by the "improve vmap allocation" series, but you were following it closely and thus should know better.
Re: [PATCH 0/3] vmalloc enhancements
On Mon, Feb 25, 2019 at 12:30:34PM -0800, Roman Gushchin wrote: > The patchset contains few changes to the vmalloc code, which are > leading to some performance gains and code simplification. > > Also, it exports a number of pages, used by vmalloc(), > in /proc/meminfo. > > Patch (1) removes some redundancy on __vunmap(). > Patch (2) separates memory allocation and data initialization > in alloc_vmap_area() > Patch (3) adds vmalloc counter to /proc/meminfo. > > v3->v2: > - switched back to atomic after more accurate perf measurements: > no visible perf difference > - added perf stacktraces in commmit message of (1) > > v2->v1: > - rebased on top of current mm tree > - switch from atomic to percpu vmalloc page counter > > RFC->v1: > - removed bogus empty lines (suggested by Matthew Wilcox) > - made nr_vmalloc_pages static (suggested by Matthew Wilcox) > - dropped patch 3 from RFC patchset, will post later with > some other changes > - dropped RFC > > Roman Gushchin (3): > mm: refactor __vunmap() to avoid duplicated call to find_vm_area() > mm: separate memory allocation and actual work in alloc_vmap_area() > mm: show number of vmalloc pages in /proc/meminfo > > fs/proc/meminfo.c | 2 +- > include/linux/vmalloc.h | 2 + > mm/vmalloc.c| 107 ++-- > 3 files changed, 73 insertions(+), 38 deletions(-) > > -- > 2.20.1 > Ping. Any comments/suggestions/objections? Thanks!
[PATCH 0/3] vmalloc enhancements
The patchset contains few changes to the vmalloc code, which are leading to some performance gains and code simplification. Also, it exports a number of pages, used by vmalloc(), in /proc/meminfo. Patch (1) removes some redundancy on __vunmap(). Patch (2) separates memory allocation and data initialization in alloc_vmap_area() Patch (3) adds vmalloc counter to /proc/meminfo. v3->v2: - switched back to atomic after more accurate perf measurements: no visible perf difference - added perf stacktraces in commmit message of (1) v2->v1: - rebased on top of current mm tree - switch from atomic to percpu vmalloc page counter RFC->v1: - removed bogus empty lines (suggested by Matthew Wilcox) - made nr_vmalloc_pages static (suggested by Matthew Wilcox) - dropped patch 3 from RFC patchset, will post later with some other changes - dropped RFC Roman Gushchin (3): mm: refactor __vunmap() to avoid duplicated call to find_vm_area() mm: separate memory allocation and actual work in alloc_vmap_area() mm: show number of vmalloc pages in /proc/meminfo fs/proc/meminfo.c | 2 +- include/linux/vmalloc.h | 2 + mm/vmalloc.c| 107 ++-- 3 files changed, 73 insertions(+), 38 deletions(-) -- 2.20.1
Re: [PATCH 0/3] vmalloc enhancements
On Mon, Feb 11, 2019 at 11:18:45AM -0800, Andrew Morton wrote: > On Mon, 11 Feb 2019 14:08:22 -0500 Johannes Weiner wrote: > > > On Wed, Dec 19, 2018 at 09:37:48AM -0800, Roman Gushchin wrote: > > > The patchset contains few changes to the vmalloc code, which are > > > leading to some performance gains and code simplification. > > > > > > Also, it exports a number of pages, used by vmalloc(), > > > in /proc/meminfo. > > > > These slipped through the cracks. +CC Andrew directly. > > Andrew, if it's not too late yet, could you consider them for 5.1? > > > > There's been some activity in vmalloc.c lately and these have > bitrotted. They'll need a redo, please. > Will do. Thanks!
Re: [PATCH 0/3] vmalloc enhancements
On Mon, 11 Feb 2019 14:08:22 -0500 Johannes Weiner wrote: > On Wed, Dec 19, 2018 at 09:37:48AM -0800, Roman Gushchin wrote: > > The patchset contains few changes to the vmalloc code, which are > > leading to some performance gains and code simplification. > > > > Also, it exports a number of pages, used by vmalloc(), > > in /proc/meminfo. > > These slipped through the cracks. +CC Andrew directly. > Andrew, if it's not too late yet, could you consider them for 5.1? > There's been some activity in vmalloc.c lately and these have bitrotted. They'll need a redo, please.
Re: [PATCH 0/3] vmalloc enhancements
These slipped through the cracks. +CC Andrew directly. Andrew, if it's not too late yet, could you consider them for 5.1? On Wed, Dec 19, 2018 at 09:37:48AM -0800, Roman Gushchin wrote: > The patchset contains few changes to the vmalloc code, which are > leading to some performance gains and code simplification. > > Also, it exports a number of pages, used by vmalloc(), > in /proc/meminfo. > > Patch (1) removes some redundancy on __vunmap(). > Patch (2) separates memory allocation and data initialization > in alloc_vmap_area() > Patch (3) adds vmalloc counter to /proc/meminfo. > > RFC->v1: > - removed bogus empty lines (suggested by Matthew Wilcox) > - made nr_vmalloc_pages static (suggested by Matthew Wilcox) > - dropped patch 3 from RFC patchset, will post later with > some other changes > - dropped RFC > > Roman Gushchin (3): > mm: refactor __vunmap() to avoid duplicated call to find_vm_area() > mm: separate memory allocation and actual work in alloc_vmap_area() > mm: show number of vmalloc pages in /proc/meminfo > > fs/proc/meminfo.c | 2 +- > include/linux/vmalloc.h | 2 + > mm/vmalloc.c| 107 ++-- > 3 files changed, 73 insertions(+), 38 deletions(-) > > -- > 2.19.2 >
[PATCH 0/3] vmalloc enhancements
The patchset contains few changes to the vmalloc code, which are leading to some performance gains and code simplification. Also, it exports a number of pages, used by vmalloc(), in /proc/meminfo. Patch (1) removes some redundancy on __vunmap(). Patch (2) separates memory allocation and data initialization in alloc_vmap_area() Patch (3) adds vmalloc counter to /proc/meminfo. RFC->v1: - removed bogus empty lines (suggested by Matthew Wilcox) - made nr_vmalloc_pages static (suggested by Matthew Wilcox) - dropped patch 3 from RFC patchset, will post later with some other changes - dropped RFC Roman Gushchin (3): mm: refactor __vunmap() to avoid duplicated call to find_vm_area() mm: separate memory allocation and actual work in alloc_vmap_area() mm: show number of vmalloc pages in /proc/meminfo fs/proc/meminfo.c | 2 +- include/linux/vmalloc.h | 2 + mm/vmalloc.c| 107 ++-- 3 files changed, 73 insertions(+), 38 deletions(-) -- 2.19.2
