Re: [PATCH 0/3 v3] build in panic_timeout value
On Tue, Nov 26, 2013 at 5:17 AM, Ingo Molnar wrote: > * Jason Baron wrote: >> I've now separated out the arch bits into separate patches. >> Hopefully, it makes review easier. I also didn't address moving the >> 'panic_timeout' command-line parameter up as an 'early_param()'. I >> think it might make sense to move it up, especially for distro >> kernels, but its not a need here, so I didn't want to just shove it >> in. If needed, I think it can come in separately, as it shoudn't >> affect this series. > > The series looks good to me, I've applied the patches to > tip:core/debug. > > If Felipe Contreras's fix patch looks good to you then it would also > be nice if you could send me that as well, on top of your patches. Why? Because for ad hominem reasons you wouldn't take the patch itself even though it's obviously good? > That fix patch had only one remaining bug/problem, last I checked: if > panic_timeout is turned into an early_param() then pause_on_oops > should obviously also be turned into an early param. That is not a "problem" with the patch itself, and it's the first time this "problem" has been mentioned at all. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/3 v3] build in panic_timeout value
* Jason Baron wrote: > Hi, > > I've now separated out the arch bits into separate patches. > Hopefully, it makes review easier. I also didn't address moving the > 'panic_timeout' command-line parameter up as an 'early_param()'. I > think it might make sense to move it up, especially for distro > kernels, but its not a need here, so I didn't want to just shove it > in. If needed, I think it can come in separately, as it shoudn't > affect this series. The series looks good to me, I've applied the patches to tip:core/debug. If Felipe Contreras's fix patch looks good to you then it would also be nice if you could send me that as well, on top of your patches. That fix patch had only one remaining bug/problem, last I checked: if panic_timeout is turned into an early_param() then pause_on_oops should obviously also be turned into an early param. Changing just one of these parameters would be inconsistent and would lead to assymetric behavior in the early-crash case. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/3 v3] build in panic_timeout value
* Jason Baron jba...@akamai.com wrote: Hi, I've now separated out the arch bits into separate patches. Hopefully, it makes review easier. I also didn't address moving the 'panic_timeout' command-line parameter up as an 'early_param()'. I think it might make sense to move it up, especially for distro kernels, but its not a need here, so I didn't want to just shove it in. If needed, I think it can come in separately, as it shoudn't affect this series. The series looks good to me, I've applied the patches to tip:core/debug. If Felipe Contreras's fix patch looks good to you then it would also be nice if you could send me that as well, on top of your patches. That fix patch had only one remaining bug/problem, last I checked: if panic_timeout is turned into an early_param() then pause_on_oops should obviously also be turned into an early param. Changing just one of these parameters would be inconsistent and would lead to assymetric behavior in the early-crash case. Thanks, Ingo -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/3 v3] build in panic_timeout value
On Tue, Nov 26, 2013 at 5:17 AM, Ingo Molnar mi...@kernel.org wrote: * Jason Baron jba...@akamai.com wrote: I've now separated out the arch bits into separate patches. Hopefully, it makes review easier. I also didn't address moving the 'panic_timeout' command-line parameter up as an 'early_param()'. I think it might make sense to move it up, especially for distro kernels, but its not a need here, so I didn't want to just shove it in. If needed, I think it can come in separately, as it shoudn't affect this series. The series looks good to me, I've applied the patches to tip:core/debug. If Felipe Contreras's fix patch looks good to you then it would also be nice if you could send me that as well, on top of your patches. Why? Because for ad hominem reasons you wouldn't take the patch itself even though it's obviously good? That fix patch had only one remaining bug/problem, last I checked: if panic_timeout is turned into an early_param() then pause_on_oops should obviously also be turned into an early param. That is not a problem with the patch itself, and it's the first time this problem has been mentioned at all. -- Felipe Contreras -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/3 v3] build in panic_timeout value
Hi, I've now separated out the arch bits into separate patches. Hopefully, it makes review easier. I also didn't address moving the 'panic_timeout' command-line parameter up as an 'early_param()'. I think it might make sense to move it up, especially for distro kernels, but its not a need here, so I didn't want to just shove it in. If needed, I think it can come in separately, as it shoudn't affect this series. Thanks, -Jason v3: -separate arch bits -drop mips settings of panic_timeout as per Ralf Baechle v2: -restrict arch defaults to arch/ code -add set_arch_panic_timeout(), in case .config specifies a non-default timeout Jason Baron (2): panic: Make panic_timeout configurable powerpc: cleanup panic_timeout Ralf Baechle (1): mips: remove panic_timeout settings. arch/mips/ar7/setup.c | 1 - arch/mips/emma/markeins/setup.c| 3 --- arch/mips/netlogic/xlp/setup.c | 1 - arch/mips/netlogic/xlr/setup.c | 1 - arch/mips/sibyte/swarm/setup.c | 2 -- arch/powerpc/Kconfig | 4 arch/powerpc/include/asm/setup.h | 1 + arch/powerpc/kernel/setup_32.c | 3 --- arch/powerpc/kernel/setup_64.c | 3 --- arch/powerpc/platforms/pseries/setup.c | 2 +- include/linux/kernel.h | 9 + kernel/panic.c | 2 +- lib/Kconfig.debug | 9 + 13 files changed, 25 insertions(+), 16 deletions(-) -- 1.8.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/3 v3] build in panic_timeout value
Hi, I've now separated out the arch bits into separate patches. Hopefully, it makes review easier. I also didn't address moving the 'panic_timeout' command-line parameter up as an 'early_param()'. I think it might make sense to move it up, especially for distro kernels, but its not a need here, so I didn't want to just shove it in. If needed, I think it can come in separately, as it shoudn't affect this series. Thanks, -Jason v3: -separate arch bits -drop mips settings of panic_timeout as per Ralf Baechle v2: -restrict arch defaults to arch/ code -add set_arch_panic_timeout(), in case .config specifies a non-default timeout Jason Baron (2): panic: Make panic_timeout configurable powerpc: cleanup panic_timeout Ralf Baechle (1): mips: remove panic_timeout settings. arch/mips/ar7/setup.c | 1 - arch/mips/emma/markeins/setup.c| 3 --- arch/mips/netlogic/xlp/setup.c | 1 - arch/mips/netlogic/xlr/setup.c | 1 - arch/mips/sibyte/swarm/setup.c | 2 -- arch/powerpc/Kconfig | 4 arch/powerpc/include/asm/setup.h | 1 + arch/powerpc/kernel/setup_32.c | 3 --- arch/powerpc/kernel/setup_64.c | 3 --- arch/powerpc/platforms/pseries/setup.c | 2 +- include/linux/kernel.h | 9 + kernel/panic.c | 2 +- lib/Kconfig.debug | 9 + 13 files changed, 25 insertions(+), 16 deletions(-) -- 1.8.2 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
