Re: [PATCH 0/4] scripts/checkpatch.pl: A small step for Linux...
On 01/09/12 04:09, Jesper Juhl wrote: > On Fri, 31 Aug 2012, Cruz Julian Bishop wrote: > >> ...and a big step for learning more Perl. >> >> Hi! >> >> This patch set started off as an experiment, but as I continued, I >> realised that I should submit this and see if it's suitable for merging >> into Linux. >> >> To start off with, here's some patches for checkincludes.pl >> >> This set was created for the following purposes: >> >> 1: Making it slightly easier to read >> 2: Making it easier to extend and add new arguments >> 3: Changing the usage output to look more "correct" >> 4: Introducing a 'quiet' mode like checkpatch.pl, and printing >> messages for files without duplicated includes by default >> >> Sorry if I did anything wrong - It's my first time really >> experimenting with Perl. >> >> Thanks in advance. >> >> ~Cruz >> >> Cruz Julian Bishop (4): >> scripts/checkincludes.pl: Print usage with heredoc >> scripts/checkincludes.pl: Simplify and shorten argument logic >> scripts/checkincludes.pl: Fix a bug introduced in the last commit >> scripts/checkincludes.pl: Introduce 'quiet' mode >> >> scripts/checkincludes.pl | 113 >> ++ >> 1 file changed, 65 insertions(+), 48 deletions(-) >> >> > Minor detail. Your patches are for "scripts/checkincludes.pl" but the > subject says "scripts/checkpatch.pl"... You may want to get it straight > what you are patching and let the subject reflect reality :-) > Yeah, I ended up writing the cover letter at 11:30 at night without any coffee :-) I'll look at a link that Joe Perches sent me then resubmit this Thanks. ~Cruz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/4] scripts/checkpatch.pl: A small step for Linux...
On Fri, 31 Aug 2012, Cruz Julian Bishop wrote: > ...and a big step for learning more Perl. > > Hi! > > This patch set started off as an experiment, but as I continued, I > realised that I should submit this and see if it's suitable for merging > into Linux. > > To start off with, here's some patches for checkincludes.pl > > This set was created for the following purposes: > > 1: Making it slightly easier to read > 2: Making it easier to extend and add new arguments > 3: Changing the usage output to look more "correct" > 4: Introducing a 'quiet' mode like checkpatch.pl, and printing > messages for files without duplicated includes by default > > Sorry if I did anything wrong - It's my first time really > experimenting with Perl. > > Thanks in advance. > > ~Cruz > > Cruz Julian Bishop (4): > scripts/checkincludes.pl: Print usage with heredoc > scripts/checkincludes.pl: Simplify and shorten argument logic > scripts/checkincludes.pl: Fix a bug introduced in the last commit > scripts/checkincludes.pl: Introduce 'quiet' mode > > scripts/checkincludes.pl | 113 > ++ > 1 file changed, 65 insertions(+), 48 deletions(-) > > Minor detail. Your patches are for "scripts/checkincludes.pl" but the subject says "scripts/checkpatch.pl"... You may want to get it straight what you are patching and let the subject reflect reality :-) -- Jesper Juhlhttp://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/4] scripts/checkpatch.pl: A small step for Linux...
Ah, the wonders of having no coffee. I only just realized that I wrote checkpatch instead of checkincludes! Should I resubmit this patch series, or just leave it since it's already on the mailing list? On 31/08/12 23:18, Cruz Julian Bishop wrote: > ...and a big step for learning more Perl. > > Hi! > > This patch set started off as an experiment, but as I continued, I > realised that I should submit this and see if it's suitable for merging > into Linux. > > To start off with, here's some patches for checkincludes.pl > > This set was created for the following purposes: > > 1: Making it slightly easier to read > 2: Making it easier to extend and add new arguments > 3: Changing the usage output to look more "correct" > 4: Introducing a 'quiet' mode like checkpatch.pl, and printing > messages for files without duplicated includes by default > > Sorry if I did anything wrong - It's my first time really > experimenting with Perl. > > Thanks in advance. > > ~Cruz > > Cruz Julian Bishop (4): > scripts/checkincludes.pl: Print usage with heredoc > scripts/checkincludes.pl: Simplify and shorten argument logic > scripts/checkincludes.pl: Fix a bug introduced in the last commit > scripts/checkincludes.pl: Introduce 'quiet' mode > > scripts/checkincludes.pl | 113 > ++ > 1 file changed, 65 insertions(+), 48 deletions(-) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/4] scripts/checkpatch.pl: A small step for Linux...
...and a big step for learning more Perl. Hi! This patch set started off as an experiment, but as I continued, I realised that I should submit this and see if it's suitable for merging into Linux. To start off with, here's some patches for checkincludes.pl This set was created for the following purposes: 1: Making it slightly easier to read 2: Making it easier to extend and add new arguments 3: Changing the usage output to look more "correct" 4: Introducing a 'quiet' mode like checkpatch.pl, and printing messages for files without duplicated includes by default Sorry if I did anything wrong - It's my first time really experimenting with Perl. Thanks in advance. ~Cruz Cruz Julian Bishop (4): scripts/checkincludes.pl: Print usage with heredoc scripts/checkincludes.pl: Simplify and shorten argument logic scripts/checkincludes.pl: Fix a bug introduced in the last commit scripts/checkincludes.pl: Introduce 'quiet' mode scripts/checkincludes.pl | 113 ++ 1 file changed, 65 insertions(+), 48 deletions(-) -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
