Re: [PATCH 0/4] staging: zsmalloc: various cleanups/improvments
On Mon, Jan 28, 2013 at 12:47:40PM +0900, Minchan Kim wrote: > Hi Seth, > > On Fri, Jan 25, 2013 at 11:46:14AM -0600, Seth Jennings wrote: > > These patches are the first 4 patches of the zswap patchset I > > sent out previously. Some recent commits to zsmalloc and > > zcache in staging-next forced a rebase. While I was at it, Nitin > > (zsmalloc maintainer) requested I break these 4 patches out from > > the zswap patchset, since they stand on their own. > > [2/4] and [4/4] is okay to merge current zsmalloc in staging but > [1/4] and [3/4] is dependent on zswap so it should be part of > zswap patchset. I tried to apply patches 2 and 4, but 2 didn't work, so I only applied 4/4. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/4] staging: zsmalloc: various cleanups/improvments
On Mon, Jan 28, 2013 at 12:47:40PM +0900, Minchan Kim wrote: Hi Seth, On Fri, Jan 25, 2013 at 11:46:14AM -0600, Seth Jennings wrote: These patches are the first 4 patches of the zswap patchset I sent out previously. Some recent commits to zsmalloc and zcache in staging-next forced a rebase. While I was at it, Nitin (zsmalloc maintainer) requested I break these 4 patches out from the zswap patchset, since they stand on their own. [2/4] and [4/4] is okay to merge current zsmalloc in staging but [1/4] and [3/4] is dependent on zswap so it should be part of zswap patchset. I tried to apply patches 2 and 4, but 2 didn't work, so I only applied 4/4. thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/4] staging: zsmalloc: various cleanups/improvments
On Mon, Jan 28, 2013 at 11:07:10AM -0600, Seth Jennings wrote: > On 01/27/2013 09:47 PM, Minchan Kim wrote: > > Hi Seth, > > > > On Fri, Jan 25, 2013 at 11:46:14AM -0600, Seth Jennings wrote: > >> These patches are the first 4 patches of the zswap patchset I > >> sent out previously. Some recent commits to zsmalloc and > >> zcache in staging-next forced a rebase. While I was at it, Nitin > >> (zsmalloc maintainer) requested I break these 4 patches out from > >> the zswap patchset, since they stand on their own. > > > > [2/4] and [4/4] is okay to merge current zsmalloc in staging but > > [1/4] and [3/4] is dependent on zswap so it should be part of > > zswap patchset. > > Just to clarify, patches 1 and 3 are _not_ dependent on zswap. They > just introduce changes that are only needed by zswap. I don't think so. If zswap might be not merged, we don't need [1, 3] at the moment. You could argue that [1, 3] make zsmalloc more flexible and I agree. BUT I want it when we have needs. It would be not too late. So [1,3] should be part of zswap patchset. > > Seth > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majord...@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: mailto:"d...@kvack.org;> em...@kvack.org -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/4] staging: zsmalloc: various cleanups/improvments
On 01/27/2013 09:47 PM, Minchan Kim wrote: > Hi Seth, > > On Fri, Jan 25, 2013 at 11:46:14AM -0600, Seth Jennings wrote: >> These patches are the first 4 patches of the zswap patchset I >> sent out previously. Some recent commits to zsmalloc and >> zcache in staging-next forced a rebase. While I was at it, Nitin >> (zsmalloc maintainer) requested I break these 4 patches out from >> the zswap patchset, since they stand on their own. > > [2/4] and [4/4] is okay to merge current zsmalloc in staging but > [1/4] and [3/4] is dependent on zswap so it should be part of > zswap patchset. Just to clarify, patches 1 and 3 are _not_ dependent on zswap. They just introduce changes that are only needed by zswap. Seth -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/4] staging: zsmalloc: various cleanups/improvments
On 01/27/2013 09:47 PM, Minchan Kim wrote: Hi Seth, On Fri, Jan 25, 2013 at 11:46:14AM -0600, Seth Jennings wrote: These patches are the first 4 patches of the zswap patchset I sent out previously. Some recent commits to zsmalloc and zcache in staging-next forced a rebase. While I was at it, Nitin (zsmalloc maintainer) requested I break these 4 patches out from the zswap patchset, since they stand on their own. [2/4] and [4/4] is okay to merge current zsmalloc in staging but [1/4] and [3/4] is dependent on zswap so it should be part of zswap patchset. Just to clarify, patches 1 and 3 are _not_ dependent on zswap. They just introduce changes that are only needed by zswap. Seth -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/4] staging: zsmalloc: various cleanups/improvments
On Mon, Jan 28, 2013 at 11:07:10AM -0600, Seth Jennings wrote: On 01/27/2013 09:47 PM, Minchan Kim wrote: Hi Seth, On Fri, Jan 25, 2013 at 11:46:14AM -0600, Seth Jennings wrote: These patches are the first 4 patches of the zswap patchset I sent out previously. Some recent commits to zsmalloc and zcache in staging-next forced a rebase. While I was at it, Nitin (zsmalloc maintainer) requested I break these 4 patches out from the zswap patchset, since they stand on their own. [2/4] and [4/4] is okay to merge current zsmalloc in staging but [1/4] and [3/4] is dependent on zswap so it should be part of zswap patchset. Just to clarify, patches 1 and 3 are _not_ dependent on zswap. They just introduce changes that are only needed by zswap. I don't think so. If zswap might be not merged, we don't need [1, 3] at the moment. You could argue that [1, 3] make zsmalloc more flexible and I agree. BUT I want it when we have needs. It would be not too late. So [1,3] should be part of zswap patchset. Seth -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majord...@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: a href=mailto:d...@kvack.org; em...@kvack.org /a -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/4] staging: zsmalloc: various cleanups/improvments
Hi Seth, On Fri, Jan 25, 2013 at 11:46:14AM -0600, Seth Jennings wrote: > These patches are the first 4 patches of the zswap patchset I > sent out previously. Some recent commits to zsmalloc and > zcache in staging-next forced a rebase. While I was at it, Nitin > (zsmalloc maintainer) requested I break these 4 patches out from > the zswap patchset, since they stand on their own. [2/4] and [4/4] is okay to merge current zsmalloc in staging but [1/4] and [3/4] is dependent on zswap so it should be part of zswap patchset. > > All are already Acked-by Nitin. > > Based on staging-next as of today. > > Seth Jennings (4): > staging: zsmalloc: add gfp flags to zs_create_pool > staging: zsmalloc: remove unused pool name > staging: zsmalloc: add page alloc/free callbacks > staging: zsmalloc: make CLASS_DELTA relative to PAGE_SIZE > > drivers/staging/zram/zram_drv.c |4 +- > drivers/staging/zsmalloc/zsmalloc-main.c | 60 > ++ > drivers/staging/zsmalloc/zsmalloc.h | 10 - > 3 files changed, 47 insertions(+), 27 deletions(-) > > -- > 1.7.9.5 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majord...@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: mailto:"d...@kvack.org;> em...@kvack.org -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/4] staging: zsmalloc: various cleanups/improvments
Hi Seth, On Fri, Jan 25, 2013 at 11:46:14AM -0600, Seth Jennings wrote: These patches are the first 4 patches of the zswap patchset I sent out previously. Some recent commits to zsmalloc and zcache in staging-next forced a rebase. While I was at it, Nitin (zsmalloc maintainer) requested I break these 4 patches out from the zswap patchset, since they stand on their own. [2/4] and [4/4] is okay to merge current zsmalloc in staging but [1/4] and [3/4] is dependent on zswap so it should be part of zswap patchset. All are already Acked-by Nitin. Based on staging-next as of today. Seth Jennings (4): staging: zsmalloc: add gfp flags to zs_create_pool staging: zsmalloc: remove unused pool name staging: zsmalloc: add page alloc/free callbacks staging: zsmalloc: make CLASS_DELTA relative to PAGE_SIZE drivers/staging/zram/zram_drv.c |4 +- drivers/staging/zsmalloc/zsmalloc-main.c | 60 ++ drivers/staging/zsmalloc/zsmalloc.h | 10 - 3 files changed, 47 insertions(+), 27 deletions(-) -- 1.7.9.5 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majord...@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: a href=mailto:d...@kvack.org; em...@kvack.org /a -- Kind regards, Minchan Kim -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 0/4] staging: zsmalloc: various cleanups/improvments
> From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] > Subject: [PATCH 0/4] staging: zsmalloc: various cleanups/improvments > > These patches are the first 4 patches of the zswap patchset I > sent out previously. Some recent commits to zsmalloc and > zcache in staging-next forced a rebase. While I was at it, Nitin > (zsmalloc maintainer) requested I break these 4 patches out from > the zswap patchset, since they stand on their own. > > All are already Acked-by Nitin. > > Based on staging-next as of today. > > Seth Jennings (4): > staging: zsmalloc: add gfp flags to zs_create_pool > staging: zsmalloc: remove unused pool name > staging: zsmalloc: add page alloc/free callbacks > staging: zsmalloc: make CLASS_DELTA relative to PAGE_SIZE > > drivers/staging/zram/zram_drv.c |4 +- > drivers/staging/zsmalloc/zsmalloc-main.c | 60 > ++ > drivers/staging/zsmalloc/zsmalloc.h | 10 - > 3 files changed, 47 insertions(+), 27 deletions(-) FWIW, please add my ack to all the patches. I'm happy to see zsmalloc move forward. I'm a bit skeptical that it will ever be capable of doing everything we would like it to do, but am eager to see if it can. Acked-by: Dan Magenheimer -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/4] staging: zsmalloc: various cleanups/improvments
These patches are the first 4 patches of the zswap patchset I sent out previously. Some recent commits to zsmalloc and zcache in staging-next forced a rebase. While I was at it, Nitin (zsmalloc maintainer) requested I break these 4 patches out from the zswap patchset, since they stand on their own. All are already Acked-by Nitin. Based on staging-next as of today. Seth Jennings (4): staging: zsmalloc: add gfp flags to zs_create_pool staging: zsmalloc: remove unused pool name staging: zsmalloc: add page alloc/free callbacks staging: zsmalloc: make CLASS_DELTA relative to PAGE_SIZE drivers/staging/zram/zram_drv.c |4 +- drivers/staging/zsmalloc/zsmalloc-main.c | 60 ++ drivers/staging/zsmalloc/zsmalloc.h | 10 - 3 files changed, 47 insertions(+), 27 deletions(-) -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/4] staging: zsmalloc: various cleanups/improvments
These patches are the first 4 patches of the zswap patchset I sent out previously. Some recent commits to zsmalloc and zcache in staging-next forced a rebase. While I was at it, Nitin (zsmalloc maintainer) requested I break these 4 patches out from the zswap patchset, since they stand on their own. All are already Acked-by Nitin. Based on staging-next as of today. Seth Jennings (4): staging: zsmalloc: add gfp flags to zs_create_pool staging: zsmalloc: remove unused pool name staging: zsmalloc: add page alloc/free callbacks staging: zsmalloc: make CLASS_DELTA relative to PAGE_SIZE drivers/staging/zram/zram_drv.c |4 +- drivers/staging/zsmalloc/zsmalloc-main.c | 60 ++ drivers/staging/zsmalloc/zsmalloc.h | 10 - 3 files changed, 47 insertions(+), 27 deletions(-) -- 1.7.9.5 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH 0/4] staging: zsmalloc: various cleanups/improvments
From: Seth Jennings [mailto:sjenn...@linux.vnet.ibm.com] Subject: [PATCH 0/4] staging: zsmalloc: various cleanups/improvments These patches are the first 4 patches of the zswap patchset I sent out previously. Some recent commits to zsmalloc and zcache in staging-next forced a rebase. While I was at it, Nitin (zsmalloc maintainer) requested I break these 4 patches out from the zswap patchset, since they stand on their own. All are already Acked-by Nitin. Based on staging-next as of today. Seth Jennings (4): staging: zsmalloc: add gfp flags to zs_create_pool staging: zsmalloc: remove unused pool name staging: zsmalloc: add page alloc/free callbacks staging: zsmalloc: make CLASS_DELTA relative to PAGE_SIZE drivers/staging/zram/zram_drv.c |4 +- drivers/staging/zsmalloc/zsmalloc-main.c | 60 ++ drivers/staging/zsmalloc/zsmalloc.h | 10 - 3 files changed, 47 insertions(+), 27 deletions(-) FWIW, please add my ack to all the patches. I'm happy to see zsmalloc move forward. I'm a bit skeptical that it will ever be capable of doing everything we would like it to do, but am eager to see if it can. Acked-by: Dan Magenheimer dan.magenhei...@oracle.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
