Re: [PATCH 0/5] Hi655x powerkey support for HiKey (v2)

2016-06-08 Thread Lee Jones
On Fri, 03 Jun 2016, John Stultz wrote:

> This patchset enables the pmic powerkey to function on HiKey.
> 
> I wanted to submit it for some initial review. Feedback would
> be greatly appreciated!
> 
> New in v2:
> * Larger rework to the powerkey driver, integrating feedback
>   from Dmitry
> * Minor dts cleanup suggested by Rob

Looks like I reviewed your RFC instead.

The points are still valid here though.

> Cc: Dmitry Torokhov 
> Cc: Rob Herring 
> Cc: Pawel Moll 
> Cc: Mark Rutland 
> Cc: Ian Campbell 
> Cc: Kumar Gala 
> Cc: Lee Jones 
> Cc: Jorge Ramirez-Ortiz 
> Cc: Wei Xu 
> Cc: Guodong Xu 
> 
> 
> Guodong Xu (1):
>   arm64: dts: Add powerkey info to pmic for hi6220-hikey
> 
> John Stultz (3):
>   dts: bindings: Add binding documentation for hisilicon,hi6552-powerkey
>   hi655x-pmic: Make hi655x pmic logic probe child nodes in the dt
>   hi655x-pmic: Fixup issue with un-acked interrupts
> 
> Jorge Ramirez-Ortiz (1):
>   drivers: input: powerkey for HISI 65xx SoC
> 
>  .../bindings/input/hisilicon,hi6552-powerkey.txt   |  40 ++
>  arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts |   7 +
>  drivers/input/misc/Kconfig |   9 ++
>  drivers/input/misc/Makefile|   1 +
>  drivers/input/misc/hisi_powerkey.c | 155 
> +
>  drivers/mfd/hi655x-pmic.c  |   9 ++
>  6 files changed, 221 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/input/hisilicon,hi6552-powerkey.txt
>  create mode 100644 drivers/input/misc/hisi_powerkey.c
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog


Re: [PATCH 0/5] Hi655x powerkey support for HiKey (v2)

2016-06-08 Thread Lee Jones
On Fri, 03 Jun 2016, John Stultz wrote:

> This patchset enables the pmic powerkey to function on HiKey.
> 
> I wanted to submit it for some initial review. Feedback would
> be greatly appreciated!
> 
> New in v2:
> * Larger rework to the powerkey driver, integrating feedback
>   from Dmitry
> * Minor dts cleanup suggested by Rob

Looks like I reviewed your RFC instead.

The points are still valid here though.

> Cc: Dmitry Torokhov 
> Cc: Rob Herring 
> Cc: Pawel Moll 
> Cc: Mark Rutland 
> Cc: Ian Campbell 
> Cc: Kumar Gala 
> Cc: Lee Jones 
> Cc: Jorge Ramirez-Ortiz 
> Cc: Wei Xu 
> Cc: Guodong Xu 
> 
> 
> Guodong Xu (1):
>   arm64: dts: Add powerkey info to pmic for hi6220-hikey
> 
> John Stultz (3):
>   dts: bindings: Add binding documentation for hisilicon,hi6552-powerkey
>   hi655x-pmic: Make hi655x pmic logic probe child nodes in the dt
>   hi655x-pmic: Fixup issue with un-acked interrupts
> 
> Jorge Ramirez-Ortiz (1):
>   drivers: input: powerkey for HISI 65xx SoC
> 
>  .../bindings/input/hisilicon,hi6552-powerkey.txt   |  40 ++
>  arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts |   7 +
>  drivers/input/misc/Kconfig |   9 ++
>  drivers/input/misc/Makefile|   1 +
>  drivers/input/misc/hisi_powerkey.c | 155 
> +
>  drivers/mfd/hi655x-pmic.c  |   9 ++
>  6 files changed, 221 insertions(+)
>  create mode 100644 
> Documentation/devicetree/bindings/input/hisilicon,hi6552-powerkey.txt
>  create mode 100644 drivers/input/misc/hisi_powerkey.c
> 

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog


[PATCH 0/5] Hi655x powerkey support for HiKey (v2)

2016-06-03 Thread John Stultz
This patchset enables the pmic powerkey to function on HiKey.

I wanted to submit it for some initial review. Feedback would
be greatly appreciated!

New in v2:
* Larger rework to the powerkey driver, integrating feedback
  from Dmitry
* Minor dts cleanup suggested by Rob

thanks
-john

Cc: Dmitry Torokhov 
Cc: Rob Herring 
Cc: Pawel Moll 
Cc: Mark Rutland 
Cc: Ian Campbell 
Cc: Kumar Gala 
Cc: Lee Jones 
Cc: Jorge Ramirez-Ortiz 
Cc: Wei Xu 
Cc: Guodong Xu 


Guodong Xu (1):
  arm64: dts: Add powerkey info to pmic for hi6220-hikey

John Stultz (3):
  dts: bindings: Add binding documentation for hisilicon,hi6552-powerkey
  hi655x-pmic: Make hi655x pmic logic probe child nodes in the dt
  hi655x-pmic: Fixup issue with un-acked interrupts

Jorge Ramirez-Ortiz (1):
  drivers: input: powerkey for HISI 65xx SoC

 .../bindings/input/hisilicon,hi6552-powerkey.txt   |  40 ++
 arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts |   7 +
 drivers/input/misc/Kconfig |   9 ++
 drivers/input/misc/Makefile|   1 +
 drivers/input/misc/hisi_powerkey.c | 155 +
 drivers/mfd/hi655x-pmic.c  |   9 ++
 6 files changed, 221 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/input/hisilicon,hi6552-powerkey.txt
 create mode 100644 drivers/input/misc/hisi_powerkey.c

-- 
1.9.1



[PATCH 0/5] Hi655x powerkey support for HiKey (v2)

2016-06-03 Thread John Stultz
This patchset enables the pmic powerkey to function on HiKey.

I wanted to submit it for some initial review. Feedback would
be greatly appreciated!

New in v2:
* Larger rework to the powerkey driver, integrating feedback
  from Dmitry
* Minor dts cleanup suggested by Rob

thanks
-john

Cc: Dmitry Torokhov 
Cc: Rob Herring 
Cc: Pawel Moll 
Cc: Mark Rutland 
Cc: Ian Campbell 
Cc: Kumar Gala 
Cc: Lee Jones 
Cc: Jorge Ramirez-Ortiz 
Cc: Wei Xu 
Cc: Guodong Xu 


Guodong Xu (1):
  arm64: dts: Add powerkey info to pmic for hi6220-hikey

John Stultz (3):
  dts: bindings: Add binding documentation for hisilicon,hi6552-powerkey
  hi655x-pmic: Make hi655x pmic logic probe child nodes in the dt
  hi655x-pmic: Fixup issue with un-acked interrupts

Jorge Ramirez-Ortiz (1):
  drivers: input: powerkey for HISI 65xx SoC

 .../bindings/input/hisilicon,hi6552-powerkey.txt   |  40 ++
 arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts |   7 +
 drivers/input/misc/Kconfig |   9 ++
 drivers/input/misc/Makefile|   1 +
 drivers/input/misc/hisi_powerkey.c | 155 +
 drivers/mfd/hi655x-pmic.c  |   9 ++
 6 files changed, 221 insertions(+)
 create mode 100644 
Documentation/devicetree/bindings/input/hisilicon,hi6552-powerkey.txt
 create mode 100644 drivers/input/misc/hisi_powerkey.c

-- 
1.9.1