Re: [PATCH 0/6] ACPI / PM: ACPI power management update
On Friday, January 04, 2013 10:58:41 PM Rafael J. Wysocki wrote: > Hi All, > > There are a few changes of the ACPI power management code I've gathered > over the last few weeks. Some of them are just cleanups etc., but some > fix (potential) problems and/or add new functionality. > > [1/6] - Rework power states changing so that we put devices into D3hot > (if available) before removing power from them entirely. > [2/6] - Rename __acpi_bus_get_power() (for future use). > [3/6] - Rename state_string() (in bus.c, for future use). > [4/6] - Export the (current) power states of ACPI devices via sysfs. > [5/6] - Move device power management functions from bus.c to device_pm.c. > [6/6] - (Unrelated to the above) Get rid of some ugly #ifdefs in sleep.c. > > All of them except for [1/6] have been posted already and no one has had any > comments. > > Please review. OK, I don't see any objections, so I'm taking it into linux-next for v3.9. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] ACPI / PM: ACPI power management update
On Friday, January 04, 2013 10:58:41 PM Rafael J. Wysocki wrote: Hi All, There are a few changes of the ACPI power management code I've gathered over the last few weeks. Some of them are just cleanups etc., but some fix (potential) problems and/or add new functionality. [1/6] - Rework power states changing so that we put devices into D3hot (if available) before removing power from them entirely. [2/6] - Rename __acpi_bus_get_power() (for future use). [3/6] - Rename state_string() (in bus.c, for future use). [4/6] - Export the (current) power states of ACPI devices via sysfs. [5/6] - Move device power management functions from bus.c to device_pm.c. [6/6] - (Unrelated to the above) Get rid of some ugly #ifdefs in sleep.c. All of them except for [1/6] have been posted already and no one has had any comments. Please review. OK, I don't see any objections, so I'm taking it into linux-next for v3.9. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] ACPI / PM: ACPI power management update
On Saturday, January 05, 2013 10:31:11 AM Sedat Dilek wrote: > Hi Rafael, > > against which Linux-kernel version is your patchset? > Linux v3.8-rc2? > Mambo number 5 [1] aka patch 5/6 does not apply cleanly. Oh, I didn't say, sorry about that. It is on top of the linux-next branch of the linux-pm.git tree with the additional patchset at https://lkml.org/lkml/2013/1/3/460 applied. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] ACPI / PM: ACPI power management update
Hi Rafael, against which Linux-kernel version is your patchset? Linux v3.8-rc2? Mambo number 5 [1] aka patch 5/6 does not apply cleanly. Regards, - Sedat - [1] http://www.youtube.com/watch?v=QQ4Ht5xfD5E P.S.: GIT AM and APPLY sessions GIT AM... wearefam@fambox:~/src/linux-kernel/linux$ git checkout Linux-v3.8-rc2 Already on 'Linux-v3.8-rc2' wearefam@fambox:~/src/linux-kernel/linux$ wearefam@fambox:~/src/linux-kernel/linux$ wearefam@fambox:~/src/linux-kernel/linux$ GIT_BRANCH="acpi-pm-fixes" ; git branch $GIT_BRANCH && git checkout $GIT_BRANCH Switched to branch 'acpi-pm-fixes' wearefam@fambox:~/src/linux-kernel/linux$ wearefam@fambox:~/src/linux-kernel/linux$ git am ../patches/acpi-pm-fixes/1-6-ACPI-PM-Change-the-way-power-transitions-to-D3cold-are-carried-out.patch Applying: ACPI / PM: Change the way power transitions to D3cold are carried out wearefam@fambox:~/src/linux-kernel/linux$ wearefam@fambox:~/src/linux-kernel/linux$ git am ../patches/acpi-pm-fixes/2-6-ACPI-PM-More-visible-function-for-retrieving-device-power-states.patch Applying: ACPI / PM: More visible function for retrieving device power states wearefam@fambox:~/src/linux-kernel/linux$ wearefam@fambox:~/src/linux-kernel/linux$ git am ../patches/acpi-pm-fixes/3-6-ACPI-PM-Common-string-representations-of-device-power-states.patch Applying: ACPI / PM: Common string representations of device power states wearefam@fambox:~/src/linux-kernel/linux$ wearefam@fambox:~/src/linux-kernel/linux$ git am ../patches/acpi-pm-fixes/4-6-ACPI-PM-Export-power-states-of-ACPI-devices-via-sysfs.patch Applying: ACPI / PM: Export power states of ACPI devices via sysfs wearefam@fambox:~/src/linux-kernel/linux$ wearefam@fambox:~/src/linux-kernel/linux$ git am ../patches/acpi-pm-fixes/5-6-ACPI-PM-Move-device-power-management-functions-to-device_pm.c.patch Applying: ACPI / PM: Move device power management functions to device_pm.c error: patch failed: include/acpi/acpi_bus.h:333 error: include/acpi/acpi_bus.h: patch does not apply Patch failed at 0001 ACPI / PM: Move device power management functions to device_pm.c When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Same with GIT APPLY... [...] wearefam@fambox:~/src/linux-kernel/linux$ git apply --check --verbose ../patches/acpi-pm-fixes/5* Checking patch drivers/acpi/device_pm.c... Checking patch include/acpi/acpi_bus.h... error: while searching for: acpi_status acpi_bus_get_status_handle(acpi_handle handle, unsigned long long *sta); int acpi_bus_get_status(struct acpi_device *device); int acpi_bus_set_power(acpi_handle handle, int state); const char *acpi_power_state_string(int state); int acpi_device_get_power(struct acpi_device *device, int *state); int acpi_device_set_power(struct acpi_device *device, int state); int acpi_bus_update_power(acpi_handle handle, int *state_p); bool acpi_bus_power_manageable(acpi_handle handle); bool acpi_bus_can_wakeup(acpi_handle handle); #ifdef CONFIG_ACPI_PROC_EVENT int acpi_bus_generate_proc_event(struct acpi_device *device, u8 type, int data); int acpi_bus_generate_proc_event4(const char *class, const char *bid, u8 type, int data); error: patch failed: include/acpi/acpi_bus.h:333 error: include/acpi/acpi_bus.h: patch does not apply Checking patch drivers/acpi/internal.h... Hunk #1 succeeded at 43 (offset -18 lines). Checking patch drivers/acpi/bus.c... - EOT- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] ACPI / PM: ACPI power management update
Hi Rafael, against which Linux-kernel version is your patchset? Linux v3.8-rc2? Mambo number 5 [1] aka patch 5/6 does not apply cleanly. Regards, - Sedat - [1] http://www.youtube.com/watch?v=QQ4Ht5xfD5E P.S.: GIT AM and APPLY sessions GIT AM... wearefam@fambox:~/src/linux-kernel/linux$ git checkout Linux-v3.8-rc2 Already on 'Linux-v3.8-rc2' wearefam@fambox:~/src/linux-kernel/linux$ wearefam@fambox:~/src/linux-kernel/linux$ wearefam@fambox:~/src/linux-kernel/linux$ GIT_BRANCH=acpi-pm-fixes ; git branch $GIT_BRANCH git checkout $GIT_BRANCH Switched to branch 'acpi-pm-fixes' wearefam@fambox:~/src/linux-kernel/linux$ wearefam@fambox:~/src/linux-kernel/linux$ git am ../patches/acpi-pm-fixes/1-6-ACPI-PM-Change-the-way-power-transitions-to-D3cold-are-carried-out.patch Applying: ACPI / PM: Change the way power transitions to D3cold are carried out wearefam@fambox:~/src/linux-kernel/linux$ wearefam@fambox:~/src/linux-kernel/linux$ git am ../patches/acpi-pm-fixes/2-6-ACPI-PM-More-visible-function-for-retrieving-device-power-states.patch Applying: ACPI / PM: More visible function for retrieving device power states wearefam@fambox:~/src/linux-kernel/linux$ wearefam@fambox:~/src/linux-kernel/linux$ git am ../patches/acpi-pm-fixes/3-6-ACPI-PM-Common-string-representations-of-device-power-states.patch Applying: ACPI / PM: Common string representations of device power states wearefam@fambox:~/src/linux-kernel/linux$ wearefam@fambox:~/src/linux-kernel/linux$ git am ../patches/acpi-pm-fixes/4-6-ACPI-PM-Export-power-states-of-ACPI-devices-via-sysfs.patch Applying: ACPI / PM: Export power states of ACPI devices via sysfs wearefam@fambox:~/src/linux-kernel/linux$ wearefam@fambox:~/src/linux-kernel/linux$ git am ../patches/acpi-pm-fixes/5-6-ACPI-PM-Move-device-power-management-functions-to-device_pm.c.patch Applying: ACPI / PM: Move device power management functions to device_pm.c error: patch failed: include/acpi/acpi_bus.h:333 error: include/acpi/acpi_bus.h: patch does not apply Patch failed at 0001 ACPI / PM: Move device power management functions to device_pm.c When you have resolved this problem run git am --resolved. If you would prefer to skip this patch, instead run git am --skip. To restore the original branch and stop patching run git am --abort. Same with GIT APPLY... [...] wearefam@fambox:~/src/linux-kernel/linux$ git apply --check --verbose ../patches/acpi-pm-fixes/5* Checking patch drivers/acpi/device_pm.c... Checking patch include/acpi/acpi_bus.h... error: while searching for: acpi_status acpi_bus_get_status_handle(acpi_handle handle, unsigned long long *sta); int acpi_bus_get_status(struct acpi_device *device); int acpi_bus_set_power(acpi_handle handle, int state); const char *acpi_power_state_string(int state); int acpi_device_get_power(struct acpi_device *device, int *state); int acpi_device_set_power(struct acpi_device *device, int state); int acpi_bus_update_power(acpi_handle handle, int *state_p); bool acpi_bus_power_manageable(acpi_handle handle); bool acpi_bus_can_wakeup(acpi_handle handle); #ifdef CONFIG_ACPI_PROC_EVENT int acpi_bus_generate_proc_event(struct acpi_device *device, u8 type, int data); int acpi_bus_generate_proc_event4(const char *class, const char *bid, u8 type, int data); error: patch failed: include/acpi/acpi_bus.h:333 error: include/acpi/acpi_bus.h: patch does not apply Checking patch drivers/acpi/internal.h... Hunk #1 succeeded at 43 (offset -18 lines). Checking patch drivers/acpi/bus.c... - EOT- -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/6] ACPI / PM: ACPI power management update
On Saturday, January 05, 2013 10:31:11 AM Sedat Dilek wrote: Hi Rafael, against which Linux-kernel version is your patchset? Linux v3.8-rc2? Mambo number 5 [1] aka patch 5/6 does not apply cleanly. Oh, I didn't say, sorry about that. It is on top of the linux-next branch of the linux-pm.git tree with the additional patchset at https://lkml.org/lkml/2013/1/3/460 applied. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/6] ACPI / PM: ACPI power management update
Hi All, There are a few changes of the ACPI power management code I've gathered over the last few weeks. Some of them are just cleanups etc., but some fix (potential) problems and/or add new functionality. [1/6] - Rework power states changing so that we put devices into D3hot (if available) before removing power from them entirely. [2/6] - Rename __acpi_bus_get_power() (for future use). [3/6] - Rename state_string() (in bus.c, for future use). [4/6] - Export the (current) power states of ACPI devices via sysfs. [5/6] - Move device power management functions from bus.c to device_pm.c. [6/6] - (Unrelated to the above) Get rid of some ugly #ifdefs in sleep.c. All of them except for [1/6] have been posted already and no one has had any comments. Please review. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 0/6] ACPI / PM: ACPI power management update
Hi All, There are a few changes of the ACPI power management code I've gathered over the last few weeks. Some of them are just cleanups etc., but some fix (potential) problems and/or add new functionality. [1/6] - Rework power states changing so that we put devices into D3hot (if available) before removing power from them entirely. [2/6] - Rename __acpi_bus_get_power() (for future use). [3/6] - Rename state_string() (in bus.c, for future use). [4/6] - Export the (current) power states of ACPI devices via sysfs. [5/6] - Move device power management functions from bus.c to device_pm.c. [6/6] - (Unrelated to the above) Get rid of some ugly #ifdefs in sleep.c. All of them except for [1/6] have been posted already and no one has had any comments. Please review. Thanks, Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
