Re: [PATCH 0/7] RFC: Cell SPE logos
On Tue, 13 Feb 2007, James Simmons wrote:
> Andrew please apply.
Thanks!
Andrew, I will resend the whole series again, against current linus.git.
> Acked-By: James Simmons <[EMAIL PROTECTED]>
>
> On Mon, 12 Feb 2007, Geert Uytterhoeven wrote:
>
> > On Wed, 31 Jan 2007, Geert Uytterhoeven wrote:
> > > I would like to hear your opinions about the patchset below (updated
> > > version
> > > compared to yesterday, lkml added to the CC list).
> > >
> > > The Cell Broadband Engine contains a 64-bit PowerPC core with 2 hardware
> > > threads (called PPEs) and 8 Synergistic Processing Engines (called SPEs).
> > > When booting Linux, 2 penguins logos are shown on the graphical console by
> > > the standard frame buffer console logo code.
> > >
> > > To emphasize the existence of the SPEs (which can be used under Linux), we
> > > added a second row of (smaller) helper penguin logos, one for each SPE.
> > > I attached a PNG version of the helper penguin logo for reference.
> > >
> > > Summaries:
> > > [PATCH 1/7] fbdev: Avoid vertical overflow when making space for the logo
> > > [PATCH 2/7] fbdev: fb_do_show_logo() updates
> > > [PATCH 3/7] fbdev: extract fb_show_logo_line()
> > > [PATCH 4/7] fbdev: move logo externs to header file
> > > [PATCH 5/7] fbdev: Add fb_append_extra_logo()
> > > [PATCH 6/7] fbdev: SPE helper penguin logo
> > > [PATCH 7/7] Cell: Draw SPE helper penguin logos
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
[EMAIL PROTECTED] --- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 B-1935 Zaventem, Belgium
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/7] RFC: Cell SPE logos
Andrew please apply.
Acked-By: James Simmons <[EMAIL PROTECTED]>
On Mon, 12 Feb 2007, Geert Uytterhoeven wrote:
> On Wed, 31 Jan 2007, Geert Uytterhoeven wrote:
> > I would like to hear your opinions about the patchset below (updated version
> > compared to yesterday, lkml added to the CC list).
> >
> > The Cell Broadband Engine contains a 64-bit PowerPC core with 2 hardware
> > threads (called PPEs) and 8 Synergistic Processing Engines (called SPEs).
> > When booting Linux, 2 penguins logos are shown on the graphical console by
> > the standard frame buffer console logo code.
> >
> > To emphasize the existence of the SPEs (which can be used under Linux), we
> > added a second row of (smaller) helper penguin logos, one for each SPE.
> > I attached a PNG version of the helper penguin logo for reference.
> >
> > Summaries:
> > [PATCH 1/7] fbdev: Avoid vertical overflow when making space for the logo
> > [PATCH 2/7] fbdev: fb_do_show_logo() updates
> > [PATCH 3/7] fbdev: extract fb_show_logo_line()
> > [PATCH 4/7] fbdev: move logo externs to header file
> > [PATCH 5/7] fbdev: Add fb_append_extra_logo()
> > [PATCH 6/7] fbdev: SPE helper penguin logo
> > [PATCH 7/7] Cell: Draw SPE helper penguin logos
>
> The helper penguins overlap with the main penguins when using console rotation
> (fbcon=rotate:x, with x != 0). Here's a fix:
>
> ---
>
> Correct the image offsets when rotating the logo. Before image->dx and
> image->dy were always zero, so nobody ever noticed.
>
> Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]>
> ---
> drivers/video/fbmem.c | 12
> 1 files changed, 8 insertions(+), 4 deletions(-)
>
> --- ps3-linux-2.6.20.orig/drivers/video/fbmem.c
> +++ ps3-linux-2.6.20/drivers/video/fbmem.c
> @@ -355,22 +355,26 @@ static void fb_rotate_logo(struct fb_inf
> if (rotate == FB_ROTATE_UD) {
> fb_rotate_logo_ud(image->data, dst, image->width,
> image->height);
> - image->dx = info->var.xres - image->width;
> - image->dy = info->var.yres - image->height;
> + image->dx = info->var.xres - image->width - image->dx;
> + image->dy = info->var.yres - image->height - image->dy;
> } else if (rotate == FB_ROTATE_CW) {
> fb_rotate_logo_cw(image->data, dst, image->width,
> image->height);
> tmp = image->width;
> image->width = image->height;
> image->height = tmp;
> - image->dx = info->var.xres - image->width;
> + tmp = image->dy;
> + image->dy = image->dx;
> + image->dx = info->var.xres - image->width - tmp;
> } else if (rotate == FB_ROTATE_CCW) {
> fb_rotate_logo_ccw(image->data, dst, image->width,
> image->height);
> tmp = image->width;
> image->width = image->height;
> image->height = tmp;
> - image->dy = info->var.yres - image->height;
> + tmp = image->dx;
> + image->dx = image->dy;
> + image->dy = info->var.yres - image->height - tmp;
> }
>
> image->data = dst;
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- Sony Network and Software Technology Center Europe
> (NSCE)
> [EMAIL PROTECTED] --- The Corporate Village, Da Vincilaan 7-D1
> Voice +32-2-7008453 Fax +32-2-7008622 B-1935 Zaventem,
> Belgium
>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/7] RFC: Cell SPE logos
On Wed, 31 Jan 2007, Geert Uytterhoeven wrote:
> I would like to hear your opinions about the patchset below (updated version
> compared to yesterday, lkml added to the CC list).
>
> The Cell Broadband Engine contains a 64-bit PowerPC core with 2 hardware
> threads (called PPEs) and 8 Synergistic Processing Engines (called SPEs).
> When booting Linux, 2 penguins logos are shown on the graphical console by
> the standard frame buffer console logo code.
>
> To emphasize the existence of the SPEs (which can be used under Linux), we
> added a second row of (smaller) helper penguin logos, one for each SPE.
> I attached a PNG version of the helper penguin logo for reference.
>
> Summaries:
> [PATCH 1/7] fbdev: Avoid vertical overflow when making space for the logo
> [PATCH 2/7] fbdev: fb_do_show_logo() updates
> [PATCH 3/7] fbdev: extract fb_show_logo_line()
> [PATCH 4/7] fbdev: move logo externs to header file
> [PATCH 5/7] fbdev: Add fb_append_extra_logo()
> [PATCH 6/7] fbdev: SPE helper penguin logo
> [PATCH 7/7] Cell: Draw SPE helper penguin logos
The helper penguins overlap with the main penguins when using console rotation
(fbcon=rotate:x, with x != 0). Here's a fix:
---
Correct the image offsets when rotating the logo. Before image->dx and
image->dy were always zero, so nobody ever noticed.
Signed-off-by: Geert Uytterhoeven <[EMAIL PROTECTED]>
---
drivers/video/fbmem.c | 12
1 files changed, 8 insertions(+), 4 deletions(-)
--- ps3-linux-2.6.20.orig/drivers/video/fbmem.c
+++ ps3-linux-2.6.20/drivers/video/fbmem.c
@@ -355,22 +355,26 @@ static void fb_rotate_logo(struct fb_inf
if (rotate == FB_ROTATE_UD) {
fb_rotate_logo_ud(image->data, dst, image->width,
image->height);
- image->dx = info->var.xres - image->width;
- image->dy = info->var.yres - image->height;
+ image->dx = info->var.xres - image->width - image->dx;
+ image->dy = info->var.yres - image->height - image->dy;
} else if (rotate == FB_ROTATE_CW) {
fb_rotate_logo_cw(image->data, dst, image->width,
image->height);
tmp = image->width;
image->width = image->height;
image->height = tmp;
- image->dx = info->var.xres - image->width;
+ tmp = image->dy;
+ image->dy = image->dx;
+ image->dx = info->var.xres - image->width - tmp;
} else if (rotate == FB_ROTATE_CCW) {
fb_rotate_logo_ccw(image->data, dst, image->width,
image->height);
tmp = image->width;
image->width = image->height;
image->height = tmp;
- image->dy = info->var.yres - image->height;
+ tmp = image->dx;
+ image->dx = image->dy;
+ image->dy = info->var.yres - image->height - tmp;
}
image->data = dst;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
[EMAIL PROTECTED] --- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 B-1935 Zaventem, Belgium
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [Cbe-oss-dev] [PATCH 0/7] RFC: Cell SPE logos
Hi! > > > I would like to hear your opinions about the patchset below (updated > > > version > > > compared to yesterday, lkml added to the CC list). > > > > Can you just blast these pictures from userspace? There's really no > > excuse to advertise SPEs from kernel > > > > What's next, I have powerful Intel graphics chipset in here, perhaps > > it is as powerful as SPE, shall I start adding little pictures for its > > pipelines? > > By the same token, there is no excuse to have the logo code at all in > the kernel in the first place... it's cool though :-) And it's a config > option, so you don't have to have it I believe the old logo code was originally created for compatibility with Solaris? :-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/7] RFC: Cell SPE logos
> I would like to hear your opinions about the patchset below (updated version > compared to yesterday, lkml added to the CC list). > > The Cell Broadband Engine contains a 64-bit PowerPC core with 2 hardware > threads (called PPEs) and 8 Synergistic Processing Engines (called SPEs). > When booting Linux, 2 penguins logos are shown on the graphical console by > the standard frame buffer console logo code. > > To emphasize the existence of the SPEs (which can be used under Linux), we > added a second row of (smaller) helper penguin logos, one for each SPE. > I attached a PNG version of the helper penguin logo for reference. > > Summaries: > [PATCH 1/7] fbdev: Avoid vertical overflow when making space for the logo > [PATCH 2/7] fbdev: fb_do_show_logo() updates > [PATCH 3/7] fbdev: extract fb_show_logo_line() > [PATCH 4/7] fbdev: move logo externs to header file > [PATCH 5/7] fbdev: Add fb_append_extra_logo() > [PATCH 6/7] fbdev: SPE helper penguin logo > [PATCH 7/7] Cell: Draw SPE helper penguin logos > > Thanks for your comments! Now that their are patches for the logo I would like to see a few more improvements that I haven't gotten too. I really like to see the logo drawn outside of fbcon. This way for embedded platforms without fbcon we could have the logo to know if the graphics device worked. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Linux-fbdev-devel] [Cbe-oss-dev] [PATCH 0/7] RFC: Cell SPE logos
> On Sun, 2007-02-04 at 14:32 +0100, Pavel Machek wrote: > > Hi1 > > > > > I would like to hear your opinions about the patchset below (updated > > > version > > > compared to yesterday, lkml added to the CC list). > > > > Can you just blast these pictures from userspace? There's really no > > excuse to advertise SPEs from kernel > > > > What's next, I have powerful Intel graphics chipset in here, perhaps > > it is as powerful as SPE, shall I start adding little pictures for its > > pipelines? > > By the same token, there is no excuse to have the logo code at all in > the kernel in the first place... it's cool though :-) And it's a config > option, so you don't have to have it True. Of course we would need a userland interface to splash a logo. I found the logo to be useful to know if the graphics device is alive and working properly. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Cbe-oss-dev] [PATCH 0/7] RFC: Cell SPE logos
On Sun, 2007-02-04 at 14:32 +0100, Pavel Machek wrote: > Hi1 > > > I would like to hear your opinions about the patchset below (updated version > > compared to yesterday, lkml added to the CC list). > > Can you just blast these pictures from userspace? There's really no > excuse to advertise SPEs from kernel > > What's next, I have powerful Intel graphics chipset in here, perhaps > it is as powerful as SPE, shall I start adding little pictures for its > pipelines? By the same token, there is no excuse to have the logo code at all in the kernel in the first place... it's cool though :-) And it's a config option, so you don't have to have it Ben - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Linux-fbdev-devel] [PATCH 0/7] RFC: Cell SPE logos
On Sun, 4 Feb 2007, Pavel Machek wrote:
> > I would like to hear your opinions about the patchset below (updated version
> > compared to yesterday, lkml added to the CC list).
>
> Can you just blast these pictures from userspace? There's really no
> excuse to advertise SPEs from kernel
Everything drawn on a frame buffer (penguin logos, text console, ...) can
indeed be done from userspace.
> What's next, I have powerful Intel graphics chipset in here, perhaps
> it is as powerful as SPE, shall I start adding little pictures for its
> pipelines?
Do you have in-kernel support for running generic code on those pipelines?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
[EMAIL PROTECTED] --- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 B-1935 Zaventem, Belgium
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/7] RFC: Cell SPE logos
Hi1 > I would like to hear your opinions about the patchset below (updated version > compared to yesterday, lkml added to the CC list). Can you just blast these pictures from userspace? There's really no excuse to advertise SPEs from kernel What's next, I have powerful Intel graphics chipset in here, perhaps it is as powerful as SPE, shall I start adding little pictures for its pipelines? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [Cbe-oss-dev] [PATCH 0/7] RFC: Cell SPE logos
Geert Uytterhoeven wrote: > To emphasize the existence of the SPEs (which can be used under Linux), we > added a second row of (smaller) helper penguin logos, one for each SPE. > I attached a PNG version of the helper penguin logo for reference. For anyone interested, I put a screen shot here: http://www.kernel.org/pub/linux/kernel/people/geoff/cell/debian-penguin-shot.png It may take some time for it to go out to the mirrors. -Geoff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/7] RFC: Cell SPE logos
On Wed, 31 Jan 2007, Geert Uytterhoeven wrote:
> I attached a PNG version of the helper penguin logo for reference.
Of course I forgot the attachment...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
[EMAIL PROTECTED] --- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 B-1935 Zaventem, Belgium
logo_spe_clut224.png
Description: PNG image
[PATCH 0/7] RFC: Cell SPE logos
Hi,
I would like to hear your opinions about the patchset below (updated version
compared to yesterday, lkml added to the CC list).
The Cell Broadband Engine contains a 64-bit PowerPC core with 2 hardware
threads (called PPEs) and 8 Synergistic Processing Engines (called SPEs).
When booting Linux, 2 penguins logos are shown on the graphical console by
the standard frame buffer console logo code.
To emphasize the existence of the SPEs (which can be used under Linux), we
added a second row of (smaller) helper penguin logos, one for each SPE.
I attached a PNG version of the helper penguin logo for reference.
Summaries:
[PATCH 1/7] fbdev: Avoid vertical overflow when making space for the logo
[PATCH 2/7] fbdev: fb_do_show_logo() updates
[PATCH 3/7] fbdev: extract fb_show_logo_line()
[PATCH 4/7] fbdev: move logo externs to header file
[PATCH 5/7] fbdev: Add fb_append_extra_logo()
[PATCH 6/7] fbdev: SPE helper penguin logo
[PATCH 7/7] Cell: Draw SPE helper penguin logos
Thanks for your comments!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- Sony Network and Software Technology Center Europe (NSCE)
[EMAIL PROTECTED] --- The Corporate Village, Da Vincilaan 7-D1
Voice +32-2-7008453 Fax +32-2-7008622 B-1935 Zaventem, Belgium
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
