Re: [PATCH 0/7] Split Coresight decode by aux records
Hi James, On Fri, Feb 12, 2021 at 04:45:06PM +0200, James Clark wrote: > Hi All, > > Since my previous RFC, I've fixed --per-thread mode and solved > most of the open questions. I've also changed --dump-raw-trace > to use the same code path so it's also working now. > > I think the only open questions are: > * General approach > * If aux records need to be saved, or if they can be pulled > from elsewhere. > > I've also tested perf inject which is now working with troublesome > files. > This patchset is now at the top of the coresight review list. I suggest you rebase this on top of your two timestamp related patches and send another revision. > Thanks > James > > James Clark (7): > perf cs-etm: Split up etm queue setup function > perf cs-etm: Only search timestamp in current sample's queue. > perf cs-etm: Save aux records in each etm queue > perf cs-etm: don't process queues until cs_etm__flush_events > perf cs-etm: split decode by aux records. > perf cs-etm: Use existing decode code path for --dump-raw-trace > perf cs-etm: Suppress printing when resetting decoder > > .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 10 +- > tools/perf/util/cs-etm.c | 300 ++ > 2 files changed, 168 insertions(+), 142 deletions(-) > > -- > 2.28.0 >
Re: [PATCH 0/7] Split Coresight decode by aux records
On 24/02/2021 18:13, Mathieu Poirier wrote: > Good day James, > > I have received your patchset and added it to my queue. On the flip side it > will be 3 to 4 weeks (from today) before I get a chance to look at it. As > such > I suggest you don't wait on me before addressing the issues found by Leo. > Ok, thanks Mathieu. I found that it's only working in --per-thread mode by coincidence of my input file. So I would suggest to not look too thoroughly until I have submitted v2. It should also probably still be an RFC rather than PATCH. Thanks James > Thanks, > Mathieu > > On Fri, Feb 12, 2021 at 04:45:06PM +0200, James Clark wrote: >> Hi All, >> >> Since my previous RFC, I've fixed --per-thread mode and solved >> most of the open questions. I've also changed --dump-raw-trace >> to use the same code path so it's also working now. >> >> I think the only open questions are: >> * General approach >> * If aux records need to be saved, or if they can be pulled >> from elsewhere. >> >> I've also tested perf inject which is now working with troublesome >> files. >> >> Thanks >> James >> >> James Clark (7): >> perf cs-etm: Split up etm queue setup function >> perf cs-etm: Only search timestamp in current sample's queue. >> perf cs-etm: Save aux records in each etm queue >> perf cs-etm: don't process queues until cs_etm__flush_events >> perf cs-etm: split decode by aux records. >> perf cs-etm: Use existing decode code path for --dump-raw-trace >> perf cs-etm: Suppress printing when resetting decoder >> >> .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 10 +- >> tools/perf/util/cs-etm.c | 300 ++ >> 2 files changed, 168 insertions(+), 142 deletions(-) >> >> -- >> 2.28.0 >>
Re: [PATCH 0/7] Split Coresight decode by aux records
Good day James, I have received your patchset and added it to my queue. On the flip side it will be 3 to 4 weeks (from today) before I get a chance to look at it. As such I suggest you don't wait on me before addressing the issues found by Leo. Thanks, Mathieu On Fri, Feb 12, 2021 at 04:45:06PM +0200, James Clark wrote: > Hi All, > > Since my previous RFC, I've fixed --per-thread mode and solved > most of the open questions. I've also changed --dump-raw-trace > to use the same code path so it's also working now. > > I think the only open questions are: > * General approach > * If aux records need to be saved, or if they can be pulled > from elsewhere. > > I've also tested perf inject which is now working with troublesome > files. > > Thanks > James > > James Clark (7): > perf cs-etm: Split up etm queue setup function > perf cs-etm: Only search timestamp in current sample's queue. > perf cs-etm: Save aux records in each etm queue > perf cs-etm: don't process queues until cs_etm__flush_events > perf cs-etm: split decode by aux records. > perf cs-etm: Use existing decode code path for --dump-raw-trace > perf cs-etm: Suppress printing when resetting decoder > > .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 10 +- > tools/perf/util/cs-etm.c | 300 ++ > 2 files changed, 168 insertions(+), 142 deletions(-) > > -- > 2.28.0 >
[PATCH 0/7] Split Coresight decode by aux records
Hi All, Since my previous RFC, I've fixed --per-thread mode and solved most of the open questions. I've also changed --dump-raw-trace to use the same code path so it's also working now. I think the only open questions are: * General approach * If aux records need to be saved, or if they can be pulled from elsewhere. I've also tested perf inject which is now working with troublesome files. Thanks James James Clark (7): perf cs-etm: Split up etm queue setup function perf cs-etm: Only search timestamp in current sample's queue. perf cs-etm: Save aux records in each etm queue perf cs-etm: don't process queues until cs_etm__flush_events perf cs-etm: split decode by aux records. perf cs-etm: Use existing decode code path for --dump-raw-trace perf cs-etm: Suppress printing when resetting decoder .../perf/util/cs-etm-decoder/cs-etm-decoder.c | 10 +- tools/perf/util/cs-etm.c | 300 ++ 2 files changed, 168 insertions(+), 142 deletions(-) -- 2.28.0
