Re: [PATCH 0/7] fujitsu-laptop: Miscellaneous cleanups

[Darren Hart]

On Sun, Feb 18, 2018 at 08:55:09PM +0100, Michał Kępień wrote:
> > To avoid just having to review everything again in a few months ;-) I've 
> > queued
> > up patches 1-5. I'll await comments to 6 and a respin of 7 based on 
> > feedback.
> 
> Thanks, I think I will post v2 of the entire series with changes
> addressing review comments for patches 6/7 and 7/7.  I think that is the
> most coherent way of moving forward, but if you would rather see fixed
> versions of patches 6/7 and 7/7 posted as 1/2 and 2/2, please just let
> me know.

Your cover letter made it easy to manage, thanks for being clear, makes it
easier on our end.

-- 
Darren Hart
VMware Open Source Technology Center

Re: [PATCH 0/7] fujitsu-laptop: Miscellaneous cleanups

[Darren Hart]

On Sun, Feb 18, 2018 at 08:55:09PM +0100, Michał Kępień wrote:
> > To avoid just having to review everything again in a few months ;-) I've 
> > queued
> > up patches 1-5. I'll await comments to 6 and a respin of 7 based on 
> > feedback.
> 
> Thanks, I think I will post v2 of the entire series with changes
> addressing review comments for patches 6/7 and 7/7.  I think that is the
> most coherent way of moving forward, but if you would rather see fixed
> versions of patches 6/7 and 7/7 posted as 1/2 and 2/2, please just let
> me know.

Your cover letter made it easy to manage, thanks for being clear, makes it
easier on our end.

-- 
Darren Hart
VMware Open Source Technology Center

Re: [PATCH 0/7] fujitsu-laptop: Miscellaneous cleanups

[Michał Kępień]

> To avoid just having to review everything again in a few months ;-) I've 
> queued
> up patches 1-5. I'll await comments to 6 and a respin of 7 based on feedback.

Thanks, I think I will post v2 of the entire series with changes
addressing review comments for patches 6/7 and 7/7.  I think that is the
most coherent way of moving forward, but if you would rather see fixed
versions of patches 6/7 and 7/7 posted as 1/2 and 2/2, please just let
me know.

-- 
Best regards,
Michał Kępień

Re: [PATCH 0/7] fujitsu-laptop: Miscellaneous cleanups

[Michał Kępień]

> To avoid just having to review everything again in a few months ;-) I've 
> queued
> up patches 1-5. I'll await comments to 6 and a respin of 7 based on feedback.

Thanks, I think I will post v2 of the entire series with changes
addressing review comments for patches 6/7 and 7/7.  I think that is the
most coherent way of moving forward, but if you would rather see fixed
versions of patches 6/7 and 7/7 posted as 1/2 and 2/2, please just let
me know.

-- 
Best regards,
Michał Kępień

Re: [PATCH 0/7] fujitsu-laptop: Miscellaneous cleanups

[Darren Hart]

On Sun, Feb 11, 2018 at 10:07:20PM +0100, Michał Kępień wrote:
> This is the second of the two patch series I started preparing back in
> June 2017 [1].  It took me this long to post it purely due to permanent
> spare time shortage, not because the changes are complicated. 
> 
> The patch series contains miscellaneous cleanups which I think are worth
> getting done before splitting fujitsu-laptop into two separate modules.
> I am not 100% sure that all the changes in the last patch in this series
> actually help, so please speak your mind.
> 
> This patch series was tested on a Lifebook S7020.  AFAICT it does not
> conflict with the recent draft patch from Jan-Marek Glogowski and may
> thus be applied independently.
> 
> Finally, please forgive me if it takes me weeks or months to address
> review comments.  It is also perfectly fine for reviews to take weeks or
> months ;)
> 

To avoid just having to review everything again in a few months ;-) I've queued
up patches 1-5. I'll await comments to 6 and a respin of 7 based on feedback.

Thanks,

-- 
Darren Hart
VMware Open Source Technology Center

Re: [PATCH 0/7] fujitsu-laptop: Miscellaneous cleanups

[Darren Hart]

On Sun, Feb 11, 2018 at 10:07:20PM +0100, Michał Kępień wrote:
> This is the second of the two patch series I started preparing back in
> June 2017 [1].  It took me this long to post it purely due to permanent
> spare time shortage, not because the changes are complicated. 
> 
> The patch series contains miscellaneous cleanups which I think are worth
> getting done before splitting fujitsu-laptop into two separate modules.
> I am not 100% sure that all the changes in the last patch in this series
> actually help, so please speak your mind.
> 
> This patch series was tested on a Lifebook S7020.  AFAICT it does not
> conflict with the recent draft patch from Jan-Marek Glogowski and may
> thus be applied independently.
> 
> Finally, please forgive me if it takes me weeks or months to address
> review comments.  It is also perfectly fine for reviews to take weeks or
> months ;)
> 

To avoid just having to review everything again in a few months ;-) I've queued
up patches 1-5. I'll await comments to 6 and a respin of 7 based on feedback.

Thanks,

-- 
Darren Hart
VMware Open Source Technology Center

Re: [PATCH 0/7] fujitsu-laptop: Miscellaneous cleanups

[Jonathan Woithe]

On Sun, Feb 11, 2018 at 10:07:20PM +0100, Micha?? K??pie?? wrote:
> The patch series contains miscellaneous cleanups which I think are worth
> getting done before splitting fujitsu-laptop into two separate modules.
> I am not 100% sure that all the changes in the last patch in this series
> actually help, so please speak your mind.

With the relatively minor comments about patch 6 I've posted about
separately, I'm happy with this patch set.  Collectively these changes
improve the readability of the code and make its intent clearer.

> This patch series was tested on a Lifebook S7020.  AFAICT it does not
> conflict with the recent draft patch from Jan-Marek Glogowski and may
> thus be applied independently.

I agree.

I'm interested to hear your thoughts in connection with my queries about
patch 6 before merging.  That aside, I have no issues with this series.

Reviewed-by: Jonathan Woithe 

Regards
  jonathan

Re: [PATCH 0/7] fujitsu-laptop: Miscellaneous cleanups

[Jonathan Woithe]

On Sun, Feb 11, 2018 at 10:07:20PM +0100, Micha?? K??pie?? wrote:
> The patch series contains miscellaneous cleanups which I think are worth
> getting done before splitting fujitsu-laptop into two separate modules.
> I am not 100% sure that all the changes in the last patch in this series
> actually help, so please speak your mind.

With the relatively minor comments about patch 6 I've posted about
separately, I'm happy with this patch set.  Collectively these changes
improve the readability of the code and make its intent clearer.

> This patch series was tested on a Lifebook S7020.  AFAICT it does not
> conflict with the recent draft patch from Jan-Marek Glogowski and may
> thus be applied independently.

I agree.

I'm interested to hear your thoughts in connection with my queries about
patch 6 before merging.  That aside, I have no issues with this series.

Reviewed-by: Jonathan Woithe 

Regards
  jonathan

[PATCH 0/7] fujitsu-laptop: Miscellaneous cleanups

[Michał Kępień]

This is the second of the two patch series I started preparing back in
June 2017 [1].  It took me this long to post it purely due to permanent
spare time shortage, not because the changes are complicated. 

The patch series contains miscellaneous cleanups which I think are worth
getting done before splitting fujitsu-laptop into two separate modules.
I am not 100% sure that all the changes in the last patch in this series
actually help, so please speak your mind.

This patch series was tested on a Lifebook S7020.  AFAICT it does not
conflict with the recent draft patch from Jan-Marek Glogowski and may
thus be applied independently.

Finally, please forgive me if it takes me weeks or months to address
review comments.  It is also perfectly fine for reviews to take weeks or
months ;)

[1] https://www.spinics.net/lists/kernel/msg2534759.html

 drivers/platform/x86/fujitsu-laptop.c | 179 +-
 1 file changed, 90 insertions(+), 89 deletions(-)

-- 
2.16.1

[PATCH 0/7] fujitsu-laptop: Miscellaneous cleanups

[Michał Kępień]

This is the second of the two patch series I started preparing back in
June 2017 [1].  It took me this long to post it purely due to permanent
spare time shortage, not because the changes are complicated. 

The patch series contains miscellaneous cleanups which I think are worth
getting done before splitting fujitsu-laptop into two separate modules.
I am not 100% sure that all the changes in the last patch in this series
actually help, so please speak your mind.

This patch series was tested on a Lifebook S7020.  AFAICT it does not
conflict with the recent draft patch from Jan-Marek Glogowski and may
thus be applied independently.

Finally, please forgive me if it takes me weeks or months to address
review comments.  It is also perfectly fine for reviews to take weeks or
months ;)

[1] https://www.spinics.net/lists/kernel/msg2534759.html

 drivers/platform/x86/fujitsu-laptop.c | 179 +-
 1 file changed, 90 insertions(+), 89 deletions(-)

-- 
2.16.1