Re: [PATCH 0/8] Enable dma driver for MIC X100 Coprocessors.
On Tue, 2014-05-27 at 14:14 -0700, Greg Kroah-Hartman wrote: > On Wed, May 07, 2014 at 08:10:57PM -0700, Sudeep Dutt wrote: > > On Thu, 2014-04-24 at 11:10 -0700, Siva Krishna Yerramreddy wrote: > > > On Mon, 2014-04-14 at 13:14 -0700, Siva Yerramreddy wrote: > > > > I am sending all these patches to char-misc because there is a > > > > dependency > > > > between the patches for dma driver and other drivers. > > > > > > > Greg, any feedback on the patches? > > > > Hi Greg, > > The primary author of this patch series Siva is no longer with Intel so > > we will be taking ownership of addressing review feedback. > > Care to resend these with an author email address that will not bounce? > I don't like taking code from people with invalid email addresses... > Sure, I have resent the patch series. Please take a look. Thanks, Sudeep Dutt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/8] Enable dma driver for MIC X100 Coprocessors.
On Wed, May 07, 2014 at 08:10:57PM -0700, Sudeep Dutt wrote: > On Thu, 2014-04-24 at 11:10 -0700, Siva Krishna Yerramreddy wrote: > > On Mon, 2014-04-14 at 13:14 -0700, Siva Yerramreddy wrote: > > > I am sending all these patches to char-misc because there is a dependency > > > between the patches for dma driver and other drivers. > > > > > Greg, any feedback on the patches? > > Hi Greg, > The primary author of this patch series Siva is no longer with Intel so > we will be taking ownership of addressing review feedback. Care to resend these with an author email address that will not bounce? I don't like taking code from people with invalid email addresses... thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/8] Enable dma driver for MIC X100 Coprocessors.
On Wed, May 07, 2014 at 08:33:20PM -0700, Dan Williams wrote: > On Wed, May 7, 2014 at 8:10 PM, Sudeep Dutt wrote: > > On Thu, 2014-04-24 at 11:10 -0700, Siva Krishna Yerramreddy wrote: > >> On Mon, 2014-04-14 at 13:14 -0700, Siva Yerramreddy wrote: > >> > I am sending all these patches to char-misc because there is a dependency > >> > between the patches for dma driver and other drivers. > >> > > >> Greg, any feedback on the patches? > > > > Hi Greg, > > The primary author of this patch series Siva is no longer with Intel so > > we will be taking ownership of addressing review feedback. > > > > The patches have been applied to the MIC GITHUB tree which is registered > > with Fengguang Wu's 0-day infrastructure and no issues have been > > reported. > > > > We have not received any feedback on the patches yet and were wondering > > if you had a chance to review them? > > Fwiw, I'm still planning on reviewing these. They are in my queue, sorry, it's really big at the moment due to travel... greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/8] Enable dma driver for MIC X100 Coprocessors.
On Wed, May 7, 2014 at 8:10 PM, Sudeep Dutt wrote: > On Thu, 2014-04-24 at 11:10 -0700, Siva Krishna Yerramreddy wrote: >> On Mon, 2014-04-14 at 13:14 -0700, Siva Yerramreddy wrote: >> > I am sending all these patches to char-misc because there is a dependency >> > between the patches for dma driver and other drivers. >> > >> Greg, any feedback on the patches? > > Hi Greg, > The primary author of this patch series Siva is no longer with Intel so > we will be taking ownership of addressing review feedback. > > The patches have been applied to the MIC GITHUB tree which is registered > with Fengguang Wu's 0-day infrastructure and no issues have been > reported. > > We have not received any feedback on the patches yet and were wondering > if you had a chance to review them? Fwiw, I'm still planning on reviewing these. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 0/8] Enable dma driver for MIC X100 Coprocessors.
On Thu, 2014-04-24 at 11:10 -0700, Siva Krishna Yerramreddy wrote: > On Mon, 2014-04-14 at 13:14 -0700, Siva Yerramreddy wrote: > > I am sending all these patches to char-misc because there is a dependency > > between the patches for dma driver and other drivers. > > > Greg, any feedback on the patches? Hi Greg, The primary author of this patch series Siva is no longer with Intel so we will be taking ownership of addressing review feedback. The patches have been applied to the MIC GITHUB tree which is registered with Fengguang Wu's 0-day infrastructure and no issues have been reported. We have not received any feedback on the patches yet and were wondering if you had a chance to review them? Thanks, Sudeep Dutt > > Description: > > > > This set of patches add support for MIC X100 dma driver. > > MIC PCIe card has a dma controller with 8 channels. These channels are > > shared between the host s/w and the card s/w. 0 to 3 are used by host > > and 4 to 7 by card. As the dma device doesn't show up as PCIe device, > > a virtual bus called mic bus is created and virtual dma devices are > > created on it by the host/card drivers. On host the channels are private > > and used only by the host driver to transfer data for the virtio devices. > > > > Here is a higher level block diagram. > > | > >+--+ | +--+ > >| Card OS | | | Host OS | > >+--+ | +--+ > > | > > +---+ ++ +--+ | +-+ ++ ++ > > | Virtio| |Virtio | |Virtio| | |Virtio | |Virtio | |Virtio | > > | Net | |Console | |Block | | |Net | |Console | |Block | > > | Driver| |Driver | |Driver| | |backend | |backend | |backend | > > +---+ ++ +--+ | +-+ ++ ++ > > | | | | || | > > | | | |User || | > > | | | |--||-|--- > > +---+ |Kernel +--+ > > | | | Virtio over PCIe IOCTLs | > > | | +--+ > > +---+ | | | > > +---+ > > | MIC DMA | | | | | MIC DMA > > | > > | Driver| | | | | Driver > > | > > +---+ | | | > > +---+ > > | | | || > > +---+ | | | > > ++ > > |MIC virtual Bus| | | | |MIC > > virtual Bus | > > +---+ | | | > > ++ > > | | | | | > > | +--+|+---+ | > > | |Intel MIC |||Intel MIC | | > > +---|Card Driver |||Host Driver| | > > +--+|+---+-+ > > | | | > > +-+ > > | | > > |PCIe Bus | > > +-+ > > > > The following series of patches are partitioned as follows: > > > > Patch 1: Add mic bus and dma driver documentation. > > Author: Siva Yerramreddy > > Patch 2: Add a bus driver for virtual MIC devices. > > Authors: Siva Yerramreddy, Sudeep Dutt > > Patch 3: MIC X100 DMA Driver. > > Author: Siva Yerramreddy > > Patch 4: Add threaded irq support in host driver. > > This is needed as the dma driver uses threaded irq. > > Author: Siva Yerramreddy > > Patch 5: Add dma support in host driver. > > Authors: Siva Yerramreddy, Ashutosh Dixit, Sudeep Dutt > > Patch 6: Add threaded irq support in card driver. > > This is needed as the dma driver uses threaded irq. > > Author: Siva Yerramreddy > > Patch 7: Add dma support in card driver. > > Author: Siva Yerramreddy > > Patch 8: Add support for loading/unloading dma driver. > > Author: Siva Yerramreddy > > > > The patches have been compiled/validated against v3.14. > > Tested using dmatest module with module parameter "threads_per_chan=60". > > > > Thanks to Dan Williams, Vinod Koul, Jon Mason, Dave Jiang for the ini
[PATCH 0/8] Enable dma driver for MIC X100 Coprocessors.
I am sending all these patches to char-misc because there is a dependency between the patches for dma driver and other drivers. Description: This set of patches add support for MIC X100 dma driver. MIC PCIe card has a dma controller with 8 channels. These channels are shared between the host s/w and the card s/w. 0 to 3 are used by host and 4 to 7 by card. As the dma device doesn't show up as PCIe device, a virtual bus called mic bus is created and virtual dma devices are created on it by the host/card drivers. On host the channels are private and used only by the host driver to transfer data for the virtio devices. Here is a higher level block diagram. | +--+ | +--+ | Card OS | | | Host OS | +--+ | +--+ | +---+ ++ +--+ | +-+ ++ ++ | Virtio| |Virtio | |Virtio| | |Virtio | |Virtio | |Virtio | | Net | |Console | |Block | | |Net | |Console | |Block | | Driver| |Driver | |Driver| | |backend | |backend | |backend | +---+ ++ +--+ | +-+ ++ ++ | | | | || | | | | |User || | | | | |--||-|--- +---+ |Kernel +--+ | | | Virtio over PCIe IOCTLs | | | +--+ +---+ | | | +---+ | MIC DMA | | | | | MIC DMA | | Driver| | | | | Driver| +---+ | | | +---+ | | | || +---+ | | | ++ |MIC virtual Bus| | | | |MIC virtual Bus | +---+ | | | ++ | | | | | | +--+|+---+ | | |Intel MIC |||Intel MIC | | +---|Card Driver |||Host Driver| | +--+|+---+-+ | | | +-+ | | |PCIe Bus | +-+ The following series of patches are partitioned as follows: Patch 1: Add mic bus and dma driver documentation. Author: Siva Yerramreddy Patch 2: Add a bus driver for virtual MIC devices. Authors: Siva Yerramreddy, Sudeep Dutt Patch 3: MIC X100 DMA Driver. Author: Siva Yerramreddy Patch 4: Add threaded irq support in host driver. This is needed as the dma driver uses threaded irq. Author: Siva Yerramreddy Patch 5: Add dma support in host driver. Authors: Siva Yerramreddy, Ashutosh Dixit, Sudeep Dutt Patch 6: Add threaded irq support in card driver. This is needed as the dma driver uses threaded irq. Author: Siva Yerramreddy Patch 7: Add dma support in card driver. Author: Siva Yerramreddy Patch 8: Add support for loading/unloading dma driver. Author: Siva Yerramreddy The patches have been compiled/validated against v3.14. Tested using dmatest module with module parameter "threads_per_chan=60". Thanks to Dan Williams, Vinod Koul, Jon Mason, Dave Jiang for the initial review. Siva Yerramreddy (8): misc: mic: Add mic bus and dma driver documentation misc: mic: add a bus driver for virtual MIC devices dma: MIC X100 DMA Driver misc: mic: add threaded irq support in host driver misc: mic: add dma support in host driver misc: mic: add threaded irq support in card driver misc: mic: add dma support in card driver misc: mic: add support for loading/unloading dma driver Documentation/mic/mic_overview.txt | 67 ++-- Documentation/mic/mpssd/mpss | 14 +- drivers/dma/Kconfig| 19 + drivers/dma/Makefile | 1 + drivers/dma/mic_x100_dma.c | 774 + drivers/dma/mic_x100_dma.h | 286 ++ drivers/misc/mic/Kconfig | 21 +- drivers/misc/mic/Makef
