Re: [PATCH 0/8 v4] bcm2835 DMA slave support

2016-04-05 Thread Vinod Koul
On Wed, Mar 16, 2016 at 12:24:54PM -0700, Eric Anholt wrote:
> Here's the series for DMA slave and memcpy support for 2835, with the
> DT changes to enable the remaining channels dropped out while that
> goes through review.  I had to do some minor conflict resolution, but
> it was pretty mechanical, and I tested again with dmatest on the last
> patch.

Applied, thanks

-- 
~Vinod


[PATCH 0/8 v4] bcm2835 DMA slave support

2016-03-19 Thread Eric Anholt
Here's the series for DMA slave and memcpy support for 2835, with the
DT changes to enable the remaining channels dropped out while that
goes through review.  I had to do some minor conflict resolution, but
it was pretty mechanical, and I tested again with dmatest on the last
patch.

Martin Sperl (8):
  dmaengine: bcm2835: set residue_granularity field
  dmaengine: bcm2835: remove unnecessary masking of dma channels
  dmaengine: bcm2835: add additional defines for DMA-registers
  dmaengine: bcm2835: move cyclic member from bcm2835_chan into
bcm2835_desc
  dmaengine: bcm2835: move controlblock chain generation into separate
method
  dmaengine: bcm2835: limit max length based on channel type
  dmaengine: bcm2835: add slave_sg support to bcm2835-dma
  dmaengine: bcm2835: add dma_memcopy support to bcm2835-dma

 drivers/dma/bcm2835-dma.c | 529 --
 1 file changed, 412 insertions(+), 117 deletions(-)

-- 
2.7.0



Re: [PATCH 0/8 v4] bcm2835 DMA slave support

2016-03-19 Thread Martin Sperl

On 16.03.2016 20:24, Eric Anholt wrote:

Here's the series for DMA slave and memcpy support for 2835, with the
DT changes to enable the remaining channels dropped out while that
goes through review.  I had to do some minor conflict resolution, but
it was pretty mechanical, and I tested again with dmatest on the last
patch.
I guess I have got a list to implement that without a change to the 
device tree,

besides making use of platform_get_irq_byname and setting up the property:
interrupt-names = "dma0", "dma1", .. "dma10", "dma_shared", "dma_all";

As the property "interrupt-names" is a standard it should be acceptable.






Re: [PATCH 0/8 v4] bcm2835 DMA slave support

2016-03-18 Thread Martin Sperl

On 16.03.2016 20:24, Eric Anholt wrote:

Here's the series for DMA slave and memcpy support for 2835, with the
DT changes to enable the remaining channels dropped out while that
goes through review.  I had to do some minor conflict resolution, but
it was pretty mechanical, and I tested again with dmatest on the last
patch.

Martin Sperl (8):
   dmaengine: bcm2835: set residue_granularity field
   dmaengine: bcm2835: remove unnecessary masking of dma channels
   dmaengine: bcm2835: add additional defines for DMA-registers
   dmaengine: bcm2835: move cyclic member from bcm2835_chan into
 bcm2835_desc
   dmaengine: bcm2835: move controlblock chain generation into separate
 method
   dmaengine: bcm2835: limit max length based on channel type
   dmaengine: bcm2835: add slave_sg support to bcm2835-dma
   dmaengine: bcm2835: add dma_memcopy support to bcm2835-dma


I have successfully tested this modified patch-series
playing BigBuckBunny on:
* fb-tft device (fb_st7735r) - via spi-bcm2835 using slave_sg dma
* I2S Hifiberry DAC (snd_soc_hifiberry_dac) - via bcm2835-i2s using 
cyclic dma


Required additional patches to make this work
(especially I2S support, which is non-working since ):
* the clock-patchsets:
 * [PATCH 0/6] clk: bcm2835: fixes clk-bcm2835 driver issues
(most are reviewed by Eric)
 * [PATCH 0/3] reorganize clock initialization and add PCM clock
(no reviewed/acked so far)
* i2s patchset to enable the use of the clock framework
 * [PATCH V2 0/3] ASOC: bcm2835: move bcm2835-i2s to use clock framework
(if I remember correctly Mark Brown has merged the driver patches)
* out of tree drivers for Hifiberry DAC
   (I guess I should upstream those...)

Tested-by: Martin Sperl