Re: [PATCH 00/10] Various load-balance cleanups/optimizations -v2
On Mon, Aug 19, 2013 at 06:00:58PM +0200, Peter Zijlstra wrote: > > After poking at them a little more I feel somewhat more confident. > > I found one more bug, but this one was my own fault, we should also clear > sds->busiest_stat.avg_load because update_sd_pick_busiest() reads that before > we set it. > > Moved the memset optimization and the fix for that into a separate patch. > > Other than that, there's a sched_domain degenerate fix; and a new way to > detect > group_imb (which relies on the sched_domain fix). I'm fine to my patches with your changes. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/10] Various load-balance cleanups/optimizations -v2
On Mon, Aug 19, 2013 at 06:00:58PM +0200, Peter Zijlstra wrote: After poking at them a little more I feel somewhat more confident. I found one more bug, but this one was my own fault, we should also clear sds-busiest_stat.avg_load because update_sd_pick_busiest() reads that before we set it. Moved the memset optimization and the fix for that into a separate patch. Other than that, there's a sched_domain degenerate fix; and a new way to detect group_imb (which relies on the sched_domain fix). I'm fine to my patches with your changes. Thanks! -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 00/10] Various load-balance cleanups/optimizations -v2
After poking at them a little more I feel somewhat more confident. I found one more bug, but this one was my own fault, we should also clear sds->busiest_stat.avg_load because update_sd_pick_busiest() reads that before we set it. Moved the memset optimization and the fix for that into a separate patch. Other than that, there's a sched_domain degenerate fix; and a new way to detect group_imb (which relies on the sched_domain fix). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 00/10] Various load-balance cleanups/optimizations -v2
After poking at them a little more I feel somewhat more confident. I found one more bug, but this one was my own fault, we should also clear sds-busiest_stat.avg_load because update_sd_pick_busiest() reads that before we set it. Moved the memset optimization and the fix for that into a separate patch. Other than that, there's a sched_domain degenerate fix; and a new way to detect group_imb (which relies on the sched_domain fix). -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
