Re: [PATCH 00/10] mtip32xx: various fixes
On 2/23/2016 8:14 AM, Jens Axboe wrote: > On Mon, Feb 22 2016, Asai Thambi SP wrote: >> Hi Jens, >> >> This patchset includes various fixes for mtip32xx driver, tested >> on kernel 4.5-rc3 >> >> Selvan Mani (10): >> mtip32xx: Abort secure erase when drive is mounted >> mtip32xx: Fix broken service thread handling >> mtip32xx: Remove unwanted code from taskfile error handler >> mtip32xx: Print exact time when an internal command is interrupted >> mtip32xx: Avoid issuing standby immediate cmd during FTL rebuild >> mtip32xx: Fix for rmmod crash when drive is in FTL rebuild >> mtip32xx: Handle safe removal during IO >> mtip32xx: Handle FTL rebuild failure state during device >> initialization >> mtip32xx: Add timeout handler >> mtip32xx: Cleanup queued requests after surprise removal > > All your patches are mangled, very white space damaged (tabs are 4 > spaces, etc). As mentioned, I don't think the first patch should go in, > the rest look fine. > I had my email client configured correctly, not sure how the setting changed. I will fix the formatting and resend the patchset.
Re: [PATCH 00/10] mtip32xx: various fixes
On Mon, Feb 22 2016, Asai Thambi SP wrote: > Hi Jens, > > This patchset includes various fixes for mtip32xx driver, tested > on kernel 4.5-rc3 > > Selvan Mani (10): > mtip32xx: Abort secure erase when drive is mounted > mtip32xx: Fix broken service thread handling > mtip32xx: Remove unwanted code from taskfile error handler > mtip32xx: Print exact time when an internal command is interrupted > mtip32xx: Avoid issuing standby immediate cmd during FTL rebuild > mtip32xx: Fix for rmmod crash when drive is in FTL rebuild > mtip32xx: Handle safe removal during IO > mtip32xx: Handle FTL rebuild failure state during device > initialization > mtip32xx: Add timeout handler > mtip32xx: Cleanup queued requests after surprise removal All your patches are mangled, very white space damaged (tabs are 4 spaces, etc). As mentioned, I don't think the first patch should go in, the rest look fine. -- Jens Axboe
[PATCH 00/10] mtip32xx: various fixes
Hi Jens, This patchset includes various fixes for mtip32xx driver, tested on kernel 4.5-rc3 Selvan Mani (10): mtip32xx: Abort secure erase when drive is mounted mtip32xx: Fix broken service thread handling mtip32xx: Remove unwanted code from taskfile error handler mtip32xx: Print exact time when an internal command is interrupted mtip32xx: Avoid issuing standby immediate cmd during FTL rebuild mtip32xx: Fix for rmmod crash when drive is in FTL rebuild mtip32xx: Handle safe removal during IO mtip32xx: Handle FTL rebuild failure state during device initialization mtip32xx: Add timeout handler mtip32xx: Cleanup queued requests after surprise removal drivers/block/mtip32xx/mtip32xx.c | 380 + drivers/block/mtip32xx/mtip32xx.h | 13 ++- 2 files changed, 314 insertions(+), 79 deletions(-)
