[PATCH 00/10] omap3 crypto fixes
This patch series fix crypto support for omap3 devices which use DT. It enables AES and SHAM on N9/N950 and SHAM on N900. AES is still disabled for N900. Pali Rohár (10): ARM: OMAP2+: Return correct error values from device and hwmod ARM: OMAP3: Fix crypto support for HS devices crypto: omap-sham: Add support for omap3 devices crypto: omap-sham: Check for return value from pm_runtime_get_sync ARM: dts: omap3 hs: Remove timer12 ARM: dts: omap3: Add missing dmas for crypto ARM: dts: n9/n950: Enable omap crypto support ARM: dts: n900: Enable omap sham and include directly omap34xx.dtsi ARM: dts: omap3-tao3530: Include directly omap34xx.dtsi ARM: dts: Remove files omap34xx-hs.dtsi and omap36xx-hs.dtsi arch/arm/boot/dts/omap3-n900.dts | 16 +- arch/arm/boot/dts/omap3-n950-n9.dtsi |2 +- arch/arm/boot/dts/omap3-tao3530.dtsi | 11 +++- arch/arm/boot/dts/omap3.dtsi |4 ++ arch/arm/boot/dts/omap34xx-hs.dtsi | 16 -- arch/arm/boot/dts/omap36xx-hs.dtsi | 16 -- arch/arm/mach-omap2/omap_device.c | 30 ++- arch/arm/mach-omap2/omap_hwmod.c | 10 ++-- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 79 +++- drivers/crypto/omap-sham.c | 13 - 10 files changed, 131 insertions(+), 66 deletions(-) delete mode 100644 arch/arm/boot/dts/omap34xx-hs.dtsi delete mode 100644 arch/arm/boot/dts/omap36xx-hs.dtsi -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/10] omap3 crypto fixes
On Sunday 08 March 2015 17:35:13 Paul Walmsley wrote: > On Sun, 8 Mar 2015, Pali Rohár wrote: > > On Friday 06 March 2015 23:23:06 Aaro Koskinen wrote: > > > On Fri, Mar 06, 2015 at 10:36:32AM -0800, Tony Lindgren wrote: > > > > Are there any fixes in this series that should go into > > > > v4.0-rc series, or can it all wait for v4.1? > > > > > > I think these all should wait for v4.1. > > > > > > A. > > > > I would suggest to include at least patches 01, 04, 06. > > Probably those could go to -stable tree... but this > > decision is up to you. > > I'm not sure patch 1 is a fix. As far as I know we haven't > run into any issues with it on real hardware - only on QEMU - > unless you know otherwise, Pali? Are we sure that the QEMU > model behavior matches the hardware? > > > - Paul Patch 1 check for return value of more functions. If real HW or software emulated HW (in qemu) does not support e.g. aes then kernel show oops message, because kernel does not check return values and try to touch non-existent HW. So I think patch 1 is really fix. In my opinion if something can fail, then kernel should check if it failed. And not expect that function call always pass. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH 00/10] omap3 crypto fixes
Hi, On Thu, Feb 26, 2015 at 02:49:50PM +0100, Pali Rohár wrote: > This patch series fix crypto support for omap3 devices which use DT. > > It enables AES and SHAM on N9/N950 and SHAM on N900. AES is still disabled > for N900. (Please format your lines somewhere near < 76 chars, especially in commit logs, otherwise "git log" looks ugly on 80 char terminals.) I tested these with stock bootloaders, and devices boot normally and I can now modprobe omap-aes (on N9 and N950) and omap-sham (on all three): omap-aes 480c5000.aes: OMAP AES hw accel rev: 2.6 omap-sham 480c3000.sham: hw accel on OMAP rev 0.9 However I get these when CONFIG_CRYPTO_MANAGER_DISABLE_TESTS is not set: alg: hash: Chunking test 1 failed for omap-sha1 alg: hash: Chunking test 1 failed for omap-md5 alg: hash: Chunking test 1 failed for omap-hmac-sha1 alg: hash: Chunking test 1 failed for omap-hmac-md5 But that's probably unrelated to this series. For patches 1-8, feel free to add: Tested-by: Aaro Koskinen A. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/10] omap3 crypto fixes
On Thursday 26 February 2015 23:46:05 Aaro Koskinen wrote: > Hi, > > On Thu, Feb 26, 2015 at 02:49:50PM +0100, Pali Rohár wrote: > > This patch series fix crypto support for omap3 devices which > > use DT. > > > > It enables AES and SHAM on N9/N950 and SHAM on N900. AES is > > still disabled for N900. > > (Please format your lines somewhere near < 76 chars, > especially in commit logs, otherwise "git log" looks ugly on > 80 char terminals.) > > I tested these with stock bootloaders, and devices boot > normally and I can now modprobe omap-aes (on N9 and N950) and > omap-sham (on all three): > > omap-aes 480c5000.aes: OMAP AES hw accel rev: 2.6 > omap-sham 480c3000.sham: hw accel on OMAP rev 0.9 > > However I get these when CONFIG_CRYPTO_MANAGER_DISABLE_TESTS > is not set: > > alg: hash: Chunking test 1 failed for omap-sha1 > alg: hash: Chunking test 1 failed for omap-md5 > alg: hash: Chunking test 1 failed for omap-hmac-sha1 > alg: hash: Chunking test 1 failed for omap-hmac-md5 > > But that's probably unrelated to this series. For patches 1-8, > feel free to add: > > Tested-by: Aaro Koskinen > > A. Hi, thanks for testing! Now I'm happy that I can load omap-aes and omap-sham drivers on real n900 device, qemu n900 and after your tests also on real n9 and n950 without any kernel crash or oops. Of course omap-aes is disabled on n900, but loading omap-aes.ko (accidentally) does not hurt. It looks like there are other parts in md5 and sha broken, but first step is load & register all drivers without kernel crash. And this is working now. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH 00/10] omap3 crypto fixes
On Friday 06 March 2015 23:23:06 Aaro Koskinen wrote: > Hi, > > On Fri, Mar 06, 2015 at 10:36:32AM -0800, Tony Lindgren wrote: > > Are there any fixes in this series that should go into > > v4.0-rc series, or can it all wait for v4.1? > > I think these all should wait for v4.1. > > A. 4.1-rc3 was released and this patch series is still not included... -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH 00/10] omap3 crypto fixes
* Pali Rohár [150514 14:19]: > On Friday 06 March 2015 23:23:06 Aaro Koskinen wrote: > > Hi, > > > > On Fri, Mar 06, 2015 at 10:36:32AM -0800, Tony Lindgren wrote: > > > Are there any fixes in this series that should go into > > > v4.0-rc series, or can it all wait for v4.1? > > > > I think these all should wait for v4.1. > > > > A. > > 4.1-rc3 was released and this patch series is still not included... The dts changes should be merged? I suggest you repost the driver fixes so Herbert can queue them. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/10] omap3 crypto fixes
On Thursday 14 May 2015 23:34:19 Tony Lindgren wrote: > * Pali Rohár [150514 14:19]: > > On Friday 06 March 2015 23:23:06 Aaro Koskinen wrote: > > > Hi, > > > > > > On Fri, Mar 06, 2015 at 10:36:32AM -0800, Tony Lindgren wrote: > > > > Are there any fixes in this series that should go into > > > > v4.0-rc series, or can it all wait for v4.1? > > > > > > I think these all should wait for v4.1. > > > > > > A. > > > > 4.1-rc3 was released and this patch series is still not included... > > The dts changes should be merged? > Looks like yes, but first two arch/arm/mach-omap2 patches not. > I suggest you repost the driver fixes so Herbert can queue them. > Ok. > Regards, > > Tony -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH 00/10] omap3 crypto fixes
* Pali Rohár [150514 14:40]: > On Thursday 14 May 2015 23:34:19 Tony Lindgren wrote: > > * Pali Rohár [150514 14:19]: > > > On Friday 06 March 2015 23:23:06 Aaro Koskinen wrote: > > > > Hi, > > > > > > > > On Fri, Mar 06, 2015 at 10:36:32AM -0800, Tony Lindgren wrote: > > > > > Are there any fixes in this series that should go into > > > > > v4.0-rc series, or can it all wait for v4.1? > > > > > > > > I think these all should wait for v4.1. > > > > > > > > A. > > > > > > 4.1-rc3 was released and this patch series is still not included... > > > > The dts changes should be merged? > > > > Looks like yes, but first two arch/arm/mach-omap2 patches not. I suggest you repost those to separately so Paul can take a look at them. It seems they can be merged separately from the driver changes? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/10] omap3 crypto fixes
* Pali Rohár [150226 05:54]: > This patch series fix crypto support for omap3 devices which use DT. > > It enables AES and SHAM on N9/N950 and SHAM on N900. AES is still disabled > for N900. > > Pali Rohár (10): > ARM: OMAP2+: Return correct error values from device and hwmod > ARM: OMAP3: Fix crypto support for HS devices > crypto: omap-sham: Add support for omap3 devices > crypto: omap-sham: Check for return value from pm_runtime_get_sync > ARM: dts: omap3 hs: Remove timer12 > ARM: dts: omap3: Add missing dmas for crypto > ARM: dts: n9/n950: Enable omap crypto support > ARM: dts: n900: Enable omap sham and include directly omap34xx.dtsi > ARM: dts: omap3-tao3530: Include directly omap34xx.dtsi > ARM: dts: Remove files omap34xx-hs.dtsi and omap36xx-hs.dtsi > > arch/arm/boot/dts/omap3-n900.dts | 16 +- > arch/arm/boot/dts/omap3-n950-n9.dtsi |2 +- > arch/arm/boot/dts/omap3-tao3530.dtsi | 11 +++- > arch/arm/boot/dts/omap3.dtsi |4 ++ > arch/arm/boot/dts/omap34xx-hs.dtsi | 16 -- > arch/arm/boot/dts/omap36xx-hs.dtsi | 16 -- > arch/arm/mach-omap2/omap_device.c | 30 ++- > arch/arm/mach-omap2/omap_hwmod.c | 10 ++-- > arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 79 > +++- > drivers/crypto/omap-sham.c | 13 - > 10 files changed, 131 insertions(+), 66 deletions(-) > delete mode 100644 arch/arm/boot/dts/omap34xx-hs.dtsi > delete mode 100644 arch/arm/boot/dts/omap36xx-hs.dtsi Are there any fixes in this series that should go into v4.0-rc series, or can it all wait for v4.1? Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/10] omap3 crypto fixes
On Friday 06 March 2015 19:36:32 Tony Lindgren wrote: > * Pali Rohár [150226 05:54]: > > This patch series fix crypto support for omap3 devices which > > use DT. > > > > It enables AES and SHAM on N9/N950 and SHAM on N900. AES is > > still disabled for N900. > > > > Pali Rohár (10): > > ARM: OMAP2+: Return correct error values from device and > > hwmod ARM: OMAP3: Fix crypto support for HS devices > > crypto: omap-sham: Add support for omap3 devices > > crypto: omap-sham: Check for return value from > > pm_runtime_get_sync ARM: dts: omap3 hs: Remove timer12 > > ARM: dts: omap3: Add missing dmas for crypto > > ARM: dts: n9/n950: Enable omap crypto support > > ARM: dts: n900: Enable omap sham and include directly > > omap34xx.dtsi ARM: dts: omap3-tao3530: Include directly > > omap34xx.dtsi ARM: dts: Remove files omap34xx-hs.dtsi and > > omap36xx-hs.dtsi > > > > arch/arm/boot/dts/omap3-n900.dts | 16 +- > > arch/arm/boot/dts/omap3-n950-n9.dtsi |2 +- > > arch/arm/boot/dts/omap3-tao3530.dtsi | 11 +++- > > arch/arm/boot/dts/omap3.dtsi |4 ++ > > arch/arm/boot/dts/omap34xx-hs.dtsi | 16 -- > > arch/arm/boot/dts/omap36xx-hs.dtsi | 16 -- > > arch/arm/mach-omap2/omap_device.c | 30 > > ++- arch/arm/mach-omap2/omap_hwmod.c | > > 10 ++-- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 79 > > +++- drivers/crypto/omap-sham.c > > | 13 - 10 files changed, 131 > > insertions(+), 66 deletions(-) delete mode 100644 > > arch/arm/boot/dts/omap34xx-hs.dtsi delete mode 100644 > > arch/arm/boot/dts/omap36xx-hs.dtsi > > Are there any fixes in this series that should go into > v4.0-rc series, or can it all wait for v4.1? > > Regards, > > Tony I do not know which patches are you sending to 4.0-rc series, but omap crypto is totally broken in linus tree for both GP & HS omap3 devices when DT booting is used. This patch series fix that problem. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH 00/10] omap3 crypto fixes
* Pali Rohár [150306 11:16]: > On Friday 06 March 2015 19:36:32 Tony Lindgren wrote: > > * Pali Rohár [150226 05:54]: > > > This patch series fix crypto support for omap3 devices which > > > use DT. > > > > > > It enables AES and SHAM on N9/N950 and SHAM on N900. AES is > > > still disabled for N900. > > > > > > Pali Rohár (10): > > > ARM: OMAP2+: Return correct error values from device and > > > hwmod ARM: OMAP3: Fix crypto support for HS devices > > > crypto: omap-sham: Add support for omap3 devices > > > crypto: omap-sham: Check for return value from > > > pm_runtime_get_sync ARM: dts: omap3 hs: Remove timer12 > > > ARM: dts: omap3: Add missing dmas for crypto > > > ARM: dts: n9/n950: Enable omap crypto support > > > ARM: dts: n900: Enable omap sham and include directly > > > omap34xx.dtsi ARM: dts: omap3-tao3530: Include directly > > > omap34xx.dtsi ARM: dts: Remove files omap34xx-hs.dtsi and > > > omap36xx-hs.dtsi > > > > > > arch/arm/boot/dts/omap3-n900.dts | 16 +- > > > arch/arm/boot/dts/omap3-n950-n9.dtsi |2 +- > > > arch/arm/boot/dts/omap3-tao3530.dtsi | 11 +++- > > > arch/arm/boot/dts/omap3.dtsi |4 ++ > > > arch/arm/boot/dts/omap34xx-hs.dtsi | 16 -- > > > arch/arm/boot/dts/omap36xx-hs.dtsi | 16 -- > > > arch/arm/mach-omap2/omap_device.c | 30 > > > ++- arch/arm/mach-omap2/omap_hwmod.c | > > > 10 ++-- arch/arm/mach-omap2/omap_hwmod_3xxx_data.c | 79 > > > +++- drivers/crypto/omap-sham.c > > > | 13 - 10 files changed, 131 > > > insertions(+), 66 deletions(-) delete mode 100644 > > > arch/arm/boot/dts/omap34xx-hs.dtsi delete mode 100644 > > > arch/arm/boot/dts/omap36xx-hs.dtsi > > > > Are there any fixes in this series that should go into > > v4.0-rc series, or can it all wait for v4.1? > > > > Regards, > > > > Tony > > I do not know which patches are you sending to 4.0-rc series, but > omap crypto is totally broken in linus tree for both GP & HS > omap3 devices when DT booting is used. This patch series fix that > problem. OK so the whole series is needed then. It seems too intrusive for the v4.0-rc series unless this fixes a regression with some earlier commit. Regards, Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/10] omap3 crypto fixes
Hi, On Fri, Mar 06, 2015 at 10:36:32AM -0800, Tony Lindgren wrote: > Are there any fixes in this series that should go into > v4.0-rc series, or can it all wait for v4.1? I think these all should wait for v4.1. A. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/10] omap3 crypto fixes
Hi, On Fri, Feb 27, 2015 at 01:40:44PM +0100, Pali Rohár wrote: > > However I get these when CONFIG_CRYPTO_MANAGER_DISABLE_TESTS > > is not set: > > > > alg: hash: Chunking test 1 failed for omap-sha1 > > alg: hash: Chunking test 1 failed for omap-md5 > > alg: hash: Chunking test 1 failed for omap-hmac-sha1 > > alg: hash: Chunking test 1 failed for omap-hmac-md5 BTW, it seems these errors are reported to be introduced possibly somewhere between 3.11 and 3.15: https://lists.fedoraproject.org/pipermail/arm/2014-August/008240.html A. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 00/10] omap3 crypto fixes
On Friday 06 March 2015 23:23:06 Aaro Koskinen wrote: > Hi, > > On Fri, Mar 06, 2015 at 10:36:32AM -0800, Tony Lindgren wrote: > > Are there any fixes in this series that should go into > > v4.0-rc series, or can it all wait for v4.1? > > I think these all should wait for v4.1. > > A. I would suggest to include at least patches 01, 04, 06. Probably those could go to -stable tree... but this decision is up to you. -- Pali Rohár pali.ro...@gmail.com signature.asc Description: This is a digitally signed message part.
Re: [PATCH 00/10] omap3 crypto fixes
On Sun, 8 Mar 2015, Pali Rohár wrote: > On Friday 06 March 2015 23:23:06 Aaro Koskinen wrote: > > On Fri, Mar 06, 2015 at 10:36:32AM -0800, Tony Lindgren wrote: > > > Are there any fixes in this series that should go into > > > v4.0-rc series, or can it all wait for v4.1? > > > > I think these all should wait for v4.1. > > > > A. > > I would suggest to include at least patches 01, 04, 06. Probably > those could go to -stable tree... but this decision is up to you. I'm not sure patch 1 is a fix. As far as I know we haven't run into any issues with it on real hardware - only on QEMU - unless you know otherwise, Pali? Are we sure that the QEMU model behavior matches the hardware? - Paul
