Re: [PATCH 00/14] serial: langtiq: Add CCF suppport
On 10/16/2018 5:58 AM, Paul Burton wrote: Hi Songjun, On Mon, Sep 24, 2018 at 06:27:49PM +0800, Songjun Wu wrote: This patch series is for adding common clock framework support for langtiq serial driver, mainly includes: s/langtiq/lantiq/ ... Thanks, it will be fixed. 1) Add common clock framework support. 2) Modify the dts file according to the DT conventions. 3) Replace the platform dependent functions with kernel functions Songjun Wu (14): MIPS: dts: Change upper case to lower case MIPS: dts: Add aliases node for lantiq danube serial serial: lantiq: Get serial id from dts serial: lantiq: Change ltq_w32_mask to asc_update_bits MIPS: lantiq: Unselect SWAP_IO_SPACE when LANTIQ is selected serial: lantiq: Use readl/writel instead of ltq_r32/ltq_w32 serial: lantiq: Rename fpiclk to freqclk serial: lantiq: Replace clk_enable/clk_disable with clk generic API serial: lantiq: Add CCF support serial: lantiq: Reorder the head files include: Add lantiq.h in include/linux/ serial: lantiq: Replace lantiq_soc.h with lantiq.h serial: lantiq: Change init_lqasc to static declaration dt-bindings: serial: lantiq: Add optional properties for CCF It appears that you only copied me on patches 1, 2 & 5. I've applied patch 1 to mips-next for 4.20, but I have no clue whether your other patches were deemed acceptable by serial or DT maintainers & I have no context for the changes being made, so I can neither apply nor ack patches 2 & 5. Please copy me on the whole series next time. Thanks, Paul Thanks. I will resend the patches and cc all the patches to you.
Re: [PATCH 00/14] serial: langtiq: Add CCF suppport
Hi Songjun, On Mon, Sep 24, 2018 at 06:27:49PM +0800, Songjun Wu wrote: > This patch series is for adding common clock framework support > for langtiq serial driver, mainly includes: s/langtiq/lantiq/ ... > 1) Add common clock framework support. > 2) Modify the dts file according to the DT conventions. > 3) Replace the platform dependent functions with kernel functions > > Songjun Wu (14): > MIPS: dts: Change upper case to lower case > MIPS: dts: Add aliases node for lantiq danube serial > serial: lantiq: Get serial id from dts > serial: lantiq: Change ltq_w32_mask to asc_update_bits > MIPS: lantiq: Unselect SWAP_IO_SPACE when LANTIQ is selected > serial: lantiq: Use readl/writel instead of ltq_r32/ltq_w32 > serial: lantiq: Rename fpiclk to freqclk > serial: lantiq: Replace clk_enable/clk_disable with clk generic API > serial: lantiq: Add CCF support > serial: lantiq: Reorder the head files > include: Add lantiq.h in include/linux/ > serial: lantiq: Replace lantiq_soc.h with lantiq.h > serial: lantiq: Change init_lqasc to static declaration > dt-bindings: serial: lantiq: Add optional properties for CCF It appears that you only copied me on patches 1, 2 & 5. I've applied patch 1 to mips-next for 4.20, but I have no clue whether your other patches were deemed acceptable by serial or DT maintainers & I have no context for the changes being made, so I can neither apply nor ack patches 2 & 5. Please copy me on the whole series next time. Thanks, Paul
[PATCH 00/14] serial: langtiq: Add CCF suppport
This patch series is for adding common clock framework support for langtiq serial driver, mainly includes: 1) Add common clock framework support. 2) Modify the dts file according to the DT conventions. 3) Replace the platform dependent functions with kernel functions Songjun Wu (14): MIPS: dts: Change upper case to lower case MIPS: dts: Add aliases node for lantiq danube serial serial: lantiq: Get serial id from dts serial: lantiq: Change ltq_w32_mask to asc_update_bits MIPS: lantiq: Unselect SWAP_IO_SPACE when LANTIQ is selected serial: lantiq: Use readl/writel instead of ltq_r32/ltq_w32 serial: lantiq: Rename fpiclk to freqclk serial: lantiq: Replace clk_enable/clk_disable with clk generic API serial: lantiq: Add CCF support serial: lantiq: Reorder the head files include: Add lantiq.h in include/linux/ serial: lantiq: Replace lantiq_soc.h with lantiq.h serial: lantiq: Change init_lqasc to static declaration dt-bindings: serial: lantiq: Add optional properties for CCF .../devicetree/bindings/serial/lantiq_asc.txt | 15 +++ arch/mips/Kconfig | 1 - arch/mips/boot/dts/lantiq/danube.dtsi | 42 +++--- arch/mips/boot/dts/lantiq/easy50712.dts| 18 ++- drivers/tty/serial/lantiq.c| 145 - include/linux/lantiq.h | 23 6 files changed, 155 insertions(+), 89 deletions(-) create mode 100644 include/linux/lantiq.h -- 2.11.0