RE: [PATCH 00/20] DPAA fixes

2019-10-08 Thread Madalin-cristian Bucur
> -Original Message-
> From: Jakub Kicinski 
> Sent: Wednesday, October 9, 2019 7:02 AM
> Subject: Re: [PATCH 00/20] DPAA fixes
> 
> On Tue,  8 Oct 2019 15:10:21 +0300, Madalin Bucur wrote:
> > Here's a series of fixes and changes for the DPAA 1.x drivers.
> > Fixing some boot time dependency issues, removing some dead code,
> > changing the buffers used for reception, fixing the DMA devices,
> > some cleanups.
> 
> Hi Madalin!
> 
> The title of this series says "DPAA fixes", are these bug fixes?
> If so they should target the net tree ([PATCH net]) and contain
> appropriate Fixes tags.
> 
> Cleanups should go into the net-next tree ([PATCH net-next]).
> 
> Please try to not post more than 15 patches in one series, it clogs
> up the review flow.
> 
> For some of those and other best practices please see:
> 
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html
> 
> :)
> 
> IMHO there is also no need at all to CC linux-kernel on networking
> patches..

Hi Jakub,

I should have added the net-next target in the subject.
I can split the (minor) fixes from the other changes.
I've added "Fixes" tags to the fix patches already.
In regards to the patch count, I can send two patch
sets but it won't reduce the total...

Regards,
Madalin


Re: [PATCH 00/20] DPAA fixes

2019-10-08 Thread Jakub Kicinski
On Tue,  8 Oct 2019 15:10:21 +0300, Madalin Bucur wrote:
> Here's a series of fixes and changes for the DPAA 1.x drivers.
> Fixing some boot time dependency issues, removing some dead code,
> changing the buffers used for reception, fixing the DMA devices,
> some cleanups.

Hi Madalin!

The title of this series says "DPAA fixes", are these bug fixes?
If so they should target the net tree ([PATCH net]) and contain
appropriate Fixes tags.

Cleanups should go into the net-next tree ([PATCH net-next]).

Please try to not post more than 15 patches in one series, it clogs 
up the review flow.

For some of those and other best practices please see:

https://www.kernel.org/doc/html/latest/networking/netdev-FAQ.html
https://www.kernel.org/doc/html/latest/process/submitting-patches.html

:)

IMHO there is also no need at all to CC linux-kernel on networking patches..


[PATCH 00/20] DPAA fixes

2019-10-08 Thread Madalin Bucur
Here's a series of fixes and changes for the DPAA 1.x drivers.
Fixing some boot time dependency issues, removing some dead code,
changing the buffers used for reception, fixing the DMA devices,
some cleanups.

Laurentiu Tudor (3):
  fsl/fman: don't touch liodn base regs reserved on non-PAMU SoCs
  dpaa_eth: defer probing after qbman
  fsl/fman: add API to get the device behind a fman port

Madalin Bucur (17):
  dpaa_eth: remove redundant code
  dpaa_eth: change DMA device
  fsl/fman: remove unused struct member
  dpaa_eth: use only one buffer pool per interface
  dpaa_eth: use page backed rx buffers
  dpaa_eth: perform DMA unmapping before read
  dpaa_eth: avoid timestamp read on error paths
  dpaa_eth: simplify variables used in dpaa_cleanup_tx_fd()
  dpaa_eth: use fd information in dpaa_cleanup_tx_fd()
  dpaa_eth: use a page to store the SGT
  soc: fsl: qbman: allow registering a device link for the portal user
  dpaa_eth: register a device link for the qman portal used
  dpaa_eth: add dropped frames to percpu ethtool stats
  dpaa_eth: remove netdev_err() for user errors
  dpaa_eth: extend delays in ndo_stop
  dpaa_eth: add dpaa_dma_to_virt()
  dpaa_eth: cleanup skb_to_contig_fd()

 drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 407 +++--
 drivers/net/ethernet/freescale/dpaa/dpaa_eth.h |  12 +-
 .../net/ethernet/freescale/dpaa/dpaa_eth_sysfs.c   |   6 +-
 drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c |  56 ++-
 drivers/net/ethernet/freescale/fman/fman.c |   6 +-
 drivers/net/ethernet/freescale/fman/fman_port.c|  17 +-
 drivers/net/ethernet/freescale/fman/fman_port.h|   2 +
 drivers/soc/fsl/qbman/qman.c   |   7 +
 include/soc/fsl/qman.h |  11 +
 9 files changed, 285 insertions(+), 239 deletions(-)

-- 
2.1.0