Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Fri, Dec 7, 2012 at 5:16 PM, Greg KH wrote:
> On Fri, Dec 07, 2012 at 01:47:48PM +, Grant Likely wrote:
>> On Wed, 5 Dec 2012 16:39:23 -0800, Greg KH
>> wrote:
>> > On Thu, Dec 06, 2012 at 12:27:42AM +, Grant Likely wrote:
>> > > On Wed, 21 Nov 2012 20:07:23 -0500, wf...@viridian.itc.virginia.edu
>> > > (Bill Pemberton) wrote:
>> > > > Grant Likely writes:
>> > > > >
>> > > > > You mean this series wasn't created with a script? You did this by
>> > > > > hand? If so then I must say kudos on your dedication!
>> > > > >
>> > > > > But it makes me more nervous about the series. Too easy to fat
>> > > > > finger many things when touching that many files.
>> > > > >
>> > > >
>> > > > No, I didn't do them by hand, it was a script. Originally, it was a
>> > > > couple, all basically the same, but removing each __dev*. Then I'd do
>> > > > a word diff to eyeball them to make sure the script didn't do
>> > > > something goofy.
>> > > >
>> > > > The whack-a-mole part came along because I was working against
>> > > > linux-next and whatever patch series was right for one day wouldn't be
>> > > > right for the next day because of some of the faster moving trees.
>> > > >
>> > > >
>> > > > > Please do write a script and post that for review.
>> > > > >
>> > > >
>> > > > The all-in-one version of the script:
>> > > >
>> > > > #! /usr/bin/perl
>> > > >
>> > > > use strict;
>> > > > use IO::InSitu;
>> > > >
>> > > > sub processfile
>> > > > {
>> > > > my $fn = shift;
>> > > >
>> > > > my ($in, $out) = open_rw($fn, $fn);
>> > > >
>> > > > while (<$in>) {
>> > > > s|__devexit_p\(([^)]+)\)|$1|;
>> > > > s|\s__devexit\b||;
>> > > > s|\s__devinitconst\b||;
>> > > > s|\s__devinitdata\b||;
>> > > > s|\s__devinit\b||;
>> > >
>> > > Pretty straight forward, and works against the files I tried. :-)
>> > >
>> > > Greg, I'd much rather see the change applied all at once in this manner.
>> > > If that isn't possible, then at the least I'll use the script against
>> > > the code that I maintain and push th result out to Linus.
>> >
>> > Given that there are a lot of patches already in linux-next from Bill
>> > due to this work, I'm not going to do this for all files right now,
>> > sorry.
>> >
>> > But, if you want to use this for the files you maintain and push that
>> > out for 3.8-rc1, that would be great. I'll be walking the tree after
>> > 3.8-rc1 is out to catch the stragglers with a script like this.
>>
>> Okay. Can you drop any commits you have against drivers/{spi,gpio,of}?
>
> Hm, I only applied the gpio ones to my tree, you got an email when that
> happened. I didn't apply the spi or of ones.
>
>> Or are they in a tree that you will not rebase?
>
> They are in my driver-core.git tree, the driver-core-next branch, which
> will not be rebased, and has been in linux-next for a while now.
>
> I can revert the 5 gpio patches if you want me to, just let me know.
no. Don't revert. I won't have the gpio changes in my tree, but I'll
do spi since they aren't in your tree yet.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Fri, Dec 07, 2012 at 01:47:48PM +, Grant Likely wrote:
> On Wed, 5 Dec 2012 16:39:23 -0800, Greg KH wrote:
> > On Thu, Dec 06, 2012 at 12:27:42AM +, Grant Likely wrote:
> > > On Wed, 21 Nov 2012 20:07:23 -0500, wf...@viridian.itc.virginia.edu (Bill
> > > Pemberton) wrote:
> > > > Grant Likely writes:
> > > > >
> > > > > You mean this series wasn't created with a script? You did this by
> > > > > hand? If so then I must say kudos on your dedication!
> > > > >
> > > > > But it makes me more nervous about the series. Too easy to fat
> > > > > finger many things when touching that many files.
> > > > >
> > > >
> > > > No, I didn't do them by hand, it was a script. Originally, it was a
> > > > couple, all basically the same, but removing each __dev*. Then I'd do
> > > > a word diff to eyeball them to make sure the script didn't do
> > > > something goofy.
> > > >
> > > > The whack-a-mole part came along because I was working against
> > > > linux-next and whatever patch series was right for one day wouldn't be
> > > > right for the next day because of some of the faster moving trees.
> > > >
> > > >
> > > > > Please do write a script and post that for review.
> > > > >
> > > >
> > > > The all-in-one version of the script:
> > > >
> > > > #! /usr/bin/perl
> > > >
> > > > use strict;
> > > > use IO::InSitu;
> > > >
> > > > sub processfile
> > > > {
> > > > my $fn = shift;
> > > >
> > > > my ($in, $out) = open_rw($fn, $fn);
> > > >
> > > > while (<$in>) {
> > > > s|__devexit_p\(([^)]+)\)|$1|;
> > > > s|\s__devexit\b||;
> > > > s|\s__devinitconst\b||;
> > > > s|\s__devinitdata\b||;
> > > > s|\s__devinit\b||;
> > >
> > > Pretty straight forward, and works against the files I tried. :-)
> > >
> > > Greg, I'd much rather see the change applied all at once in this manner.
> > > If that isn't possible, then at the least I'll use the script against
> > > the code that I maintain and push th result out to Linus.
> >
> > Given that there are a lot of patches already in linux-next from Bill
> > due to this work, I'm not going to do this for all files right now,
> > sorry.
> >
> > But, if you want to use this for the files you maintain and push that
> > out for 3.8-rc1, that would be great. I'll be walking the tree after
> > 3.8-rc1 is out to catch the stragglers with a script like this.
>
> Okay. Can you drop any commits you have against drivers/{spi,gpio,of}?
Hm, I only applied the gpio ones to my tree, you got an email when that
happened. I didn't apply the spi or of ones.
> Or are they in a tree that you will not rebase?
They are in my driver-core.git tree, the driver-core-next branch, which
will not be rebased, and has been in linux-next for a while now.
I can revert the 5 gpio patches if you want me to, just let me know.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Wed, 5 Dec 2012 16:39:23 -0800, Greg KH wrote:
> On Thu, Dec 06, 2012 at 12:27:42AM +, Grant Likely wrote:
> > On Wed, 21 Nov 2012 20:07:23 -0500, wf...@viridian.itc.virginia.edu (Bill
> > Pemberton) wrote:
> > > Grant Likely writes:
> > > >
> > > > You mean this series wasn't created with a script? You did this by
> > > > hand? If so then I must say kudos on your dedication!
> > > >
> > > > But it makes me more nervous about the series. Too easy to fat
> > > > finger many things when touching that many files.
> > > >
> > >
> > > No, I didn't do them by hand, it was a script. Originally, it was a
> > > couple, all basically the same, but removing each __dev*. Then I'd do
> > > a word diff to eyeball them to make sure the script didn't do
> > > something goofy.
> > >
> > > The whack-a-mole part came along because I was working against
> > > linux-next and whatever patch series was right for one day wouldn't be
> > > right for the next day because of some of the faster moving trees.
> > >
> > >
> > > > Please do write a script and post that for review.
> > > >
> > >
> > > The all-in-one version of the script:
> > >
> > > #! /usr/bin/perl
> > >
> > > use strict;
> > > use IO::InSitu;
> > >
> > > sub processfile
> > > {
> > > my $fn = shift;
> > >
> > > my ($in, $out) = open_rw($fn, $fn);
> > >
> > > while (<$in>) {
> > > s|__devexit_p\(([^)]+)\)|$1|;
> > > s|\s__devexit\b||;
> > > s|\s__devinitconst\b||;
> > > s|\s__devinitdata\b||;
> > > s|\s__devinit\b||;
> >
> > Pretty straight forward, and works against the files I tried. :-)
> >
> > Greg, I'd much rather see the change applied all at once in this manner.
> > If that isn't possible, then at the least I'll use the script against
> > the code that I maintain and push th result out to Linus.
>
> Given that there are a lot of patches already in linux-next from Bill
> due to this work, I'm not going to do this for all files right now,
> sorry.
>
> But, if you want to use this for the files you maintain and push that
> out for 3.8-rc1, that would be great. I'll be walking the tree after
> 3.8-rc1 is out to catch the stragglers with a script like this.
Okay. Can you drop any commits you have against drivers/{spi,gpio,of}?
Or are they in a tree that you will not rebase?
g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Wed, 5 Dec 2012 16:39:23 -0800, Greg KH gre...@linuxfoundation.org wrote:
On Thu, Dec 06, 2012 at 12:27:42AM +, Grant Likely wrote:
On Wed, 21 Nov 2012 20:07:23 -0500, wf...@viridian.itc.virginia.edu (Bill
Pemberton) wrote:
Grant Likely writes:
You mean this series wasn't created with a script? You did this by
hand? If so then I must say kudos on your dedication!
But it makes me more nervous about the series. Too easy to fat
finger many things when touching that many files.
No, I didn't do them by hand, it was a script. Originally, it was a
couple, all basically the same, but removing each __dev*. Then I'd do
a word diff to eyeball them to make sure the script didn't do
something goofy.
The whack-a-mole part came along because I was working against
linux-next and whatever patch series was right for one day wouldn't be
right for the next day because of some of the faster moving trees.
Please do write a script and post that for review.
The all-in-one version of the script:
#! /usr/bin/perl
use strict;
use IO::InSitu;
sub processfile
{
my $fn = shift;
my ($in, $out) = open_rw($fn, $fn);
while ($in) {
s|__devexit_p\(([^)]+)\)|$1|;
s|\s__devexit\b||;
s|\s__devinitconst\b||;
s|\s__devinitdata\b||;
s|\s__devinit\b||;
Pretty straight forward, and works against the files I tried. :-)
Greg, I'd much rather see the change applied all at once in this manner.
If that isn't possible, then at the least I'll use the script against
the code that I maintain and push th result out to Linus.
Given that there are a lot of patches already in linux-next from Bill
due to this work, I'm not going to do this for all files right now,
sorry.
But, if you want to use this for the files you maintain and push that
out for 3.8-rc1, that would be great. I'll be walking the tree after
3.8-rc1 is out to catch the stragglers with a script like this.
Okay. Can you drop any commits you have against drivers/{spi,gpio,of}?
Or are they in a tree that you will not rebase?
g.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Fri, Dec 07, 2012 at 01:47:48PM +, Grant Likely wrote:
On Wed, 5 Dec 2012 16:39:23 -0800, Greg KH gre...@linuxfoundation.org wrote:
On Thu, Dec 06, 2012 at 12:27:42AM +, Grant Likely wrote:
On Wed, 21 Nov 2012 20:07:23 -0500, wf...@viridian.itc.virginia.edu (Bill
Pemberton) wrote:
Grant Likely writes:
You mean this series wasn't created with a script? You did this by
hand? If so then I must say kudos on your dedication!
But it makes me more nervous about the series. Too easy to fat
finger many things when touching that many files.
No, I didn't do them by hand, it was a script. Originally, it was a
couple, all basically the same, but removing each __dev*. Then I'd do
a word diff to eyeball them to make sure the script didn't do
something goofy.
The whack-a-mole part came along because I was working against
linux-next and whatever patch series was right for one day wouldn't be
right for the next day because of some of the faster moving trees.
Please do write a script and post that for review.
The all-in-one version of the script:
#! /usr/bin/perl
use strict;
use IO::InSitu;
sub processfile
{
my $fn = shift;
my ($in, $out) = open_rw($fn, $fn);
while ($in) {
s|__devexit_p\(([^)]+)\)|$1|;
s|\s__devexit\b||;
s|\s__devinitconst\b||;
s|\s__devinitdata\b||;
s|\s__devinit\b||;
Pretty straight forward, and works against the files I tried. :-)
Greg, I'd much rather see the change applied all at once in this manner.
If that isn't possible, then at the least I'll use the script against
the code that I maintain and push th result out to Linus.
Given that there are a lot of patches already in linux-next from Bill
due to this work, I'm not going to do this for all files right now,
sorry.
But, if you want to use this for the files you maintain and push that
out for 3.8-rc1, that would be great. I'll be walking the tree after
3.8-rc1 is out to catch the stragglers with a script like this.
Okay. Can you drop any commits you have against drivers/{spi,gpio,of}?
Hm, I only applied the gpio ones to my tree, you got an email when that
happened. I didn't apply the spi or of ones.
Or are they in a tree that you will not rebase?
They are in my driver-core.git tree, the driver-core-next branch, which
will not be rebased, and has been in linux-next for a while now.
I can revert the 5 gpio patches if you want me to, just let me know.
thanks,
greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Fri, Dec 7, 2012 at 5:16 PM, Greg KH gre...@linuxfoundation.org wrote:
On Fri, Dec 07, 2012 at 01:47:48PM +, Grant Likely wrote:
On Wed, 5 Dec 2012 16:39:23 -0800, Greg KH gre...@linuxfoundation.org
wrote:
On Thu, Dec 06, 2012 at 12:27:42AM +, Grant Likely wrote:
On Wed, 21 Nov 2012 20:07:23 -0500, wf...@viridian.itc.virginia.edu
(Bill Pemberton) wrote:
Grant Likely writes:
You mean this series wasn't created with a script? You did this by
hand? If so then I must say kudos on your dedication!
But it makes me more nervous about the series. Too easy to fat
finger many things when touching that many files.
No, I didn't do them by hand, it was a script. Originally, it was a
couple, all basically the same, but removing each __dev*. Then I'd do
a word diff to eyeball them to make sure the script didn't do
something goofy.
The whack-a-mole part came along because I was working against
linux-next and whatever patch series was right for one day wouldn't be
right for the next day because of some of the faster moving trees.
Please do write a script and post that for review.
The all-in-one version of the script:
#! /usr/bin/perl
use strict;
use IO::InSitu;
sub processfile
{
my $fn = shift;
my ($in, $out) = open_rw($fn, $fn);
while ($in) {
s|__devexit_p\(([^)]+)\)|$1|;
s|\s__devexit\b||;
s|\s__devinitconst\b||;
s|\s__devinitdata\b||;
s|\s__devinit\b||;
Pretty straight forward, and works against the files I tried. :-)
Greg, I'd much rather see the change applied all at once in this manner.
If that isn't possible, then at the least I'll use the script against
the code that I maintain and push th result out to Linus.
Given that there are a lot of patches already in linux-next from Bill
due to this work, I'm not going to do this for all files right now,
sorry.
But, if you want to use this for the files you maintain and push that
out for 3.8-rc1, that would be great. I'll be walking the tree after
3.8-rc1 is out to catch the stragglers with a script like this.
Okay. Can you drop any commits you have against drivers/{spi,gpio,of}?
Hm, I only applied the gpio ones to my tree, you got an email when that
happened. I didn't apply the spi or of ones.
Or are they in a tree that you will not rebase?
They are in my driver-core.git tree, the driver-core-next branch, which
will not be rebased, and has been in linux-next for a while now.
I can revert the 5 gpio patches if you want me to, just let me know.
no. Don't revert. I won't have the gpio changes in my tree, but I'll
do spi since they aren't in your tree yet.
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Thu, Dec 06, 2012 at 12:27:42AM +, Grant Likely wrote:
> On Wed, 21 Nov 2012 20:07:23 -0500, wf...@viridian.itc.virginia.edu (Bill
> Pemberton) wrote:
> > Grant Likely writes:
> > >
> > > You mean this series wasn't created with a script? You did this by
> > > hand? If so then I must say kudos on your dedication!
> > >
> > > But it makes me more nervous about the series. Too easy to fat
> > > finger many things when touching that many files.
> > >
> >
> > No, I didn't do them by hand, it was a script. Originally, it was a
> > couple, all basically the same, but removing each __dev*. Then I'd do
> > a word diff to eyeball them to make sure the script didn't do
> > something goofy.
> >
> > The whack-a-mole part came along because I was working against
> > linux-next and whatever patch series was right for one day wouldn't be
> > right for the next day because of some of the faster moving trees.
> >
> >
> > > Please do write a script and post that for review.
> > >
> >
> > The all-in-one version of the script:
> >
> > #! /usr/bin/perl
> >
> > use strict;
> > use IO::InSitu;
> >
> > sub processfile
> > {
> > my $fn = shift;
> >
> > my ($in, $out) = open_rw($fn, $fn);
> >
> > while (<$in>) {
> > s|__devexit_p\(([^)]+)\)|$1|;
> > s|\s__devexit\b||;
> > s|\s__devinitconst\b||;
> > s|\s__devinitdata\b||;
> > s|\s__devinit\b||;
>
> Pretty straight forward, and works against the files I tried. :-)
>
> Greg, I'd much rather see the change applied all at once in this manner.
> If that isn't possible, then at the least I'll use the script against
> the code that I maintain and push th result out to Linus.
Given that there are a lot of patches already in linux-next from Bill
due to this work, I'm not going to do this for all files right now,
sorry.
But, if you want to use this for the files you maintain and push that
out for 3.8-rc1, that would be great. I'll be walking the tree after
3.8-rc1 is out to catch the stragglers with a script like this.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Wed, 21 Nov 2012 20:07:23 -0500, wf...@viridian.itc.virginia.edu (Bill
Pemberton) wrote:
> Grant Likely writes:
> >
> > You mean this series wasn't created with a script? You did this by
> > hand? If so then I must say kudos on your dedication!
> >
> > But it makes me more nervous about the series. Too easy to fat
> > finger many things when touching that many files.
> >
>
> No, I didn't do them by hand, it was a script. Originally, it was a
> couple, all basically the same, but removing each __dev*. Then I'd do
> a word diff to eyeball them to make sure the script didn't do
> something goofy.
>
> The whack-a-mole part came along because I was working against
> linux-next and whatever patch series was right for one day wouldn't be
> right for the next day because of some of the faster moving trees.
>
>
> > Please do write a script and post that for review.
> >
>
> The all-in-one version of the script:
>
> #! /usr/bin/perl
>
> use strict;
> use IO::InSitu;
>
> sub processfile
> {
> my $fn = shift;
>
> my ($in, $out) = open_rw($fn, $fn);
>
> while (<$in>) {
> s|__devexit_p\(([^)]+)\)|$1|;
> s|\s__devexit\b||;
> s|\s__devinitconst\b||;
> s|\s__devinitdata\b||;
> s|\s__devinit\b||;
Pretty straight forward, and works against the files I tried. :-)
Greg, I'd much rather see the change applied all at once in this manner.
If that isn't possible, then at the least I'll use the script against
the code that I maintain and push th result out to Linus.
g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Wed, 21 Nov 2012 20:07:23 -0500, wf...@viridian.itc.virginia.edu (Bill
Pemberton) wrote:
Grant Likely writes:
You mean this series wasn't created with a script? You did this by
hand? If so then I must say kudos on your dedication!
But it makes me more nervous about the series. Too easy to fat
finger many things when touching that many files.
No, I didn't do them by hand, it was a script. Originally, it was a
couple, all basically the same, but removing each __dev*. Then I'd do
a word diff to eyeball them to make sure the script didn't do
something goofy.
The whack-a-mole part came along because I was working against
linux-next and whatever patch series was right for one day wouldn't be
right for the next day because of some of the faster moving trees.
Please do write a script and post that for review.
The all-in-one version of the script:
#! /usr/bin/perl
use strict;
use IO::InSitu;
sub processfile
{
my $fn = shift;
my ($in, $out) = open_rw($fn, $fn);
while ($in) {
s|__devexit_p\(([^)]+)\)|$1|;
s|\s__devexit\b||;
s|\s__devinitconst\b||;
s|\s__devinitdata\b||;
s|\s__devinit\b||;
Pretty straight forward, and works against the files I tried. :-)
Greg, I'd much rather see the change applied all at once in this manner.
If that isn't possible, then at the least I'll use the script against
the code that I maintain and push th result out to Linus.
g.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Thu, Dec 06, 2012 at 12:27:42AM +, Grant Likely wrote:
On Wed, 21 Nov 2012 20:07:23 -0500, wf...@viridian.itc.virginia.edu (Bill
Pemberton) wrote:
Grant Likely writes:
You mean this series wasn't created with a script? You did this by
hand? If so then I must say kudos on your dedication!
But it makes me more nervous about the series. Too easy to fat
finger many things when touching that many files.
No, I didn't do them by hand, it was a script. Originally, it was a
couple, all basically the same, but removing each __dev*. Then I'd do
a word diff to eyeball them to make sure the script didn't do
something goofy.
The whack-a-mole part came along because I was working against
linux-next and whatever patch series was right for one day wouldn't be
right for the next day because of some of the faster moving trees.
Please do write a script and post that for review.
The all-in-one version of the script:
#! /usr/bin/perl
use strict;
use IO::InSitu;
sub processfile
{
my $fn = shift;
my ($in, $out) = open_rw($fn, $fn);
while ($in) {
s|__devexit_p\(([^)]+)\)|$1|;
s|\s__devexit\b||;
s|\s__devinitconst\b||;
s|\s__devinitdata\b||;
s|\s__devinit\b||;
Pretty straight forward, and works against the files I tried. :-)
Greg, I'd much rather see the change applied all at once in this manner.
If that isn't possible, then at the least I'll use the script against
the code that I maintain and push th result out to Linus.
Given that there are a lot of patches already in linux-next from Bill
due to this work, I'm not going to do this for all files right now,
sorry.
But, if you want to use this for the files you maintain and push that
out for 3.8-rc1, that would be great. I'll be walking the tree after
3.8-rc1 is out to catch the stragglers with a script like this.
thanks,
greg k-h
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Mon, Nov 19, 2012 at 11:55:56AM -0800, Dmitry Torokhov wrote: > On Fri, Nov 16, 2012 at 07:19:10PM -0500, Bill Pemberton wrote: > > CONFIG_HOTPLUG is no longer an optional setting. In order to remove > > it as on option code paths that check CONFIG_HOTPLUG will removed > > along with the attributes __devexit_p, __devexit, __devinitconst, and > > __devinitdata. > > > > I'll save the list from the mailbomb of this huge patchset. The > > patches themselves are going to Greg KH for the driver core tree. > > > > _iff_ we are going to do this I'd prefer pushing input pieces through my > tree to limit clashes with other work. Applied all input-related patches to my 'next' branch, thank you Bill. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Mon, Nov 19, 2012 at 11:55:56AM -0800, Dmitry Torokhov wrote: On Fri, Nov 16, 2012 at 07:19:10PM -0500, Bill Pemberton wrote: CONFIG_HOTPLUG is no longer an optional setting. In order to remove it as on option code paths that check CONFIG_HOTPLUG will removed along with the attributes __devexit_p, __devexit, __devinitconst, and __devinitdata. I'll save the list from the mailbomb of this huge patchset. The patches themselves are going to Greg KH for the driver core tree. _iff_ we are going to do this I'd prefer pushing input pieces through my tree to limit clashes with other work. Applied all input-related patches to my 'next' branch, thank you Bill. -- Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
Greg KH wrote: >On Wed, Nov 21, 2012 at 01:41:46PM -0500, Bill Pemberton wrote: >> Andrew Morton writes: >> > >> > On Tue, 20 Nov 2012 10:46:11 + Grant Likely > wrote: >> > >> > > On Sat, Nov 17, 2012 at 12:19 AM, Bill Pemberton > wrote: >> > > > CONFIG_HOTPLUG is no longer an optional setting. In order to >remove >> > > > it as on option code paths that check CONFIG_HOTPLUG will >removed >> > > > along with the attributes __devexit_p, __devexit, >__devinitconst, and >> > > > __devinitdata. >> > > > >> > > > I'll save the list from the mailbomb of this huge patchset. >The >> > > > patches themselves are going to Greg KH for the driver core >tree. >> > > > >> > > > >> > > > Bill Pemberton (493): >> > > [...] >> > > > 2942 files changed, 11645 insertions(+), 12116 deletions(-) >> > > >> > > So, I've got no problem with the reason for the change and I >don't >> > > even think you need my ack for the bits that I maintain (though >you >> > > have it if you want it). However, this looks like it is going to >be >> > > /painful/. First of all it will touch a huge number of files in >the >> > > tree. Yes the change is trivial, but it will require manual >fixups on >> > > a lot of patches. >> > >> > Yeah, this is dopey. Send the script to Linus and ask him to run >it >> > seven seconds before he releases -rc1, when everyone's trees are >> > empty(ish). Or send him a single megapatch at that time. >> > >> >> I like the script idea for removing all the __dev markings. Creating >> the patches in the first place was a game of whack-a-mole as various >> trees changed. You mean this series wasn't created with a script? You did this by hand? If so then I must say kudos on your dedication! But it makes me more nervous about the series. Too easy to fat finger many things when touching that many files. Please do write a script and post that for review. g. > >Linus doesn't like to take scripts, I had planned on queueing all of >these up that different subsystems maintainers didn't take, and pushing >the ones that did merge cleanly into -rc1. Then, right after -rc1 is >out, go through the tree once more to get the stragglers. > >Sound reasonable? > >thanks, > >greg k-h -- Grant Likely, P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Wed, Nov 21, 2012 at 7:56 AM, Andrew Morton wrote: > On Tue, 20 Nov 2012 10:46:11 + Grant Likely > wrote: > >> On Sat, Nov 17, 2012 at 12:19 AM, Bill Pemberton wrote: >> > CONFIG_HOTPLUG is no longer an optional setting. In order to remove >> > it as on option code paths that check CONFIG_HOTPLUG will removed >> > along with the attributes __devexit_p, __devexit, __devinitconst, and >> > __devinitdata. >> > >> > I'll save the list from the mailbomb of this huge patchset. The >> > patches themselves are going to Greg KH for the driver core tree. >> > >> > >> > Bill Pemberton (493): >> [...] >> > 2942 files changed, 11645 insertions(+), 12116 deletions(-) >> >> So, I've got no problem with the reason for the change and I don't >> even think you need my ack for the bits that I maintain (though you >> have it if you want it). However, this looks like it is going to be >> /painful/. First of all it will touch a huge number of files in the >> tree. Yes the change is trivial, but it will require manual fixups on >> a lot of patches. > > Yeah, this is dopey. Send the script to Linus and ask him to run it > seven seconds before he releases -rc1, when everyone's trees are > empty(ish). Or send him a single megapatch at that time. Yes please. I'm all on board with doing this in one fell swoop. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
Grant Likely writes:
>
> You mean this series wasn't created with a script? You did this by
> hand? If so then I must say kudos on your dedication!
>
> But it makes me more nervous about the series. Too easy to fat
> finger many things when touching that many files.
>
No, I didn't do them by hand, it was a script. Originally, it was a
couple, all basically the same, but removing each __dev*. Then I'd do
a word diff to eyeball them to make sure the script didn't do
something goofy.
The whack-a-mole part came along because I was working against
linux-next and whatever patch series was right for one day wouldn't be
right for the next day because of some of the faster moving trees.
> Please do write a script and post that for review.
>
The all-in-one version of the script:
#! /usr/bin/perl
use strict;
use IO::InSitu;
sub processfile
{
my $fn = shift;
my ($in, $out) = open_rw($fn, $fn);
while (<$in>) {
s|__devexit_p\(([^)]+)\)|$1|;
s|\s__devexit\b||;
s|\s__devinitconst\b||;
s|\s__devinitdata\b||;
s|\s__devinit\b||;
print $out $_;
}
close $in;
close $out;
}
foreach my $fn (@ARGV) {
processfile($fn);
}
--
Bill
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
Grant Likely writes:
You mean this series wasn't created with a script? You did this by
hand? If so then I must say kudos on your dedication!
But it makes me more nervous about the series. Too easy to fat
finger many things when touching that many files.
No, I didn't do them by hand, it was a script. Originally, it was a
couple, all basically the same, but removing each __dev*. Then I'd do
a word diff to eyeball them to make sure the script didn't do
something goofy.
The whack-a-mole part came along because I was working against
linux-next and whatever patch series was right for one day wouldn't be
right for the next day because of some of the faster moving trees.
Please do write a script and post that for review.
The all-in-one version of the script:
#! /usr/bin/perl
use strict;
use IO::InSitu;
sub processfile
{
my $fn = shift;
my ($in, $out) = open_rw($fn, $fn);
while ($in) {
s|__devexit_p\(([^)]+)\)|$1|;
s|\s__devexit\b||;
s|\s__devinitconst\b||;
s|\s__devinitdata\b||;
s|\s__devinit\b||;
print $out $_;
}
close $in;
close $out;
}
foreach my $fn (@ARGV) {
processfile($fn);
}
--
Bill
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Wed, Nov 21, 2012 at 7:56 AM, Andrew Morton a...@linux-foundation.org wrote: On Tue, 20 Nov 2012 10:46:11 + Grant Likely grant.lik...@secretlab.ca wrote: On Sat, Nov 17, 2012 at 12:19 AM, Bill Pemberton wf...@virginia.edu wrote: CONFIG_HOTPLUG is no longer an optional setting. In order to remove it as on option code paths that check CONFIG_HOTPLUG will removed along with the attributes __devexit_p, __devexit, __devinitconst, and __devinitdata. I'll save the list from the mailbomb of this huge patchset. The patches themselves are going to Greg KH for the driver core tree. Bill Pemberton (493): [...] 2942 files changed, 11645 insertions(+), 12116 deletions(-) So, I've got no problem with the reason for the change and I don't even think you need my ack for the bits that I maintain (though you have it if you want it). However, this looks like it is going to be /painful/. First of all it will touch a huge number of files in the tree. Yes the change is trivial, but it will require manual fixups on a lot of patches. Yeah, this is dopey. Send the script to Linus and ask him to run it seven seconds before he releases -rc1, when everyone's trees are empty(ish). Or send him a single megapatch at that time. Yes please. I'm all on board with doing this in one fell swoop. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
Greg KH gre...@linuxfoundation.org wrote: On Wed, Nov 21, 2012 at 01:41:46PM -0500, Bill Pemberton wrote: Andrew Morton writes: On Tue, 20 Nov 2012 10:46:11 + Grant Likely grant.lik...@secretlab.ca wrote: On Sat, Nov 17, 2012 at 12:19 AM, Bill Pemberton wf...@virginia.edu wrote: CONFIG_HOTPLUG is no longer an optional setting. In order to remove it as on option code paths that check CONFIG_HOTPLUG will removed along with the attributes __devexit_p, __devexit, __devinitconst, and __devinitdata. I'll save the list from the mailbomb of this huge patchset. The patches themselves are going to Greg KH for the driver core tree. Bill Pemberton (493): [...] 2942 files changed, 11645 insertions(+), 12116 deletions(-) So, I've got no problem with the reason for the change and I don't even think you need my ack for the bits that I maintain (though you have it if you want it). However, this looks like it is going to be /painful/. First of all it will touch a huge number of files in the tree. Yes the change is trivial, but it will require manual fixups on a lot of patches. Yeah, this is dopey. Send the script to Linus and ask him to run it seven seconds before he releases -rc1, when everyone's trees are empty(ish). Or send him a single megapatch at that time. I like the script idea for removing all the __dev markings. Creating the patches in the first place was a game of whack-a-mole as various trees changed. You mean this series wasn't created with a script? You did this by hand? If so then I must say kudos on your dedication! But it makes me more nervous about the series. Too easy to fat finger many things when touching that many files. Please do write a script and post that for review. g. Linus doesn't like to take scripts, I had planned on queueing all of these up that different subsystems maintainers didn't take, and pushing the ones that did merge cleanly into -rc1. Then, right after -rc1 is out, go through the tree once more to get the stragglers. Sound reasonable? thanks, greg k-h -- Grant Likely, P.Eng. Secret Lab Technologies Ltd. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Wed, Nov 21, 2012 at 01:41:46PM -0500, Bill Pemberton wrote: > Andrew Morton writes: > > > > On Tue, 20 Nov 2012 10:46:11 + Grant Likely > > wrote: > > > > > On Sat, Nov 17, 2012 at 12:19 AM, Bill Pemberton > > > wrote: > > > > CONFIG_HOTPLUG is no longer an optional setting. In order to remove > > > > it as on option code paths that check CONFIG_HOTPLUG will removed > > > > along with the attributes __devexit_p, __devexit, __devinitconst, and > > > > __devinitdata. > > > > > > > > I'll save the list from the mailbomb of this huge patchset. The > > > > patches themselves are going to Greg KH for the driver core tree. > > > > > > > > > > > > Bill Pemberton (493): > > > [...] > > > > 2942 files changed, 11645 insertions(+), 12116 deletions(-) > > > > > > So, I've got no problem with the reason for the change and I don't > > > even think you need my ack for the bits that I maintain (though you > > > have it if you want it). However, this looks like it is going to be > > > /painful/. First of all it will touch a huge number of files in the > > > tree. Yes the change is trivial, but it will require manual fixups on > > > a lot of patches. > > > > Yeah, this is dopey. Send the script to Linus and ask him to run it > > seven seconds before he releases -rc1, when everyone's trees are > > empty(ish). Or send him a single megapatch at that time. > > > > I like the script idea for removing all the __dev markings. Creating > the patches in the first place was a game of whack-a-mole as various > trees changed. Linus doesn't like to take scripts, I had planned on queueing all of these up that different subsystems maintainers didn't take, and pushing the ones that did merge cleanly into -rc1. Then, right after -rc1 is out, go through the tree once more to get the stragglers. Sound reasonable? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
Andrew Morton writes: > > On Tue, 20 Nov 2012 10:46:11 + Grant Likely > wrote: > > > On Sat, Nov 17, 2012 at 12:19 AM, Bill Pemberton wrote: > > > CONFIG_HOTPLUG is no longer an optional setting. In order to remove > > > it as on option code paths that check CONFIG_HOTPLUG will removed > > > along with the attributes __devexit_p, __devexit, __devinitconst, and > > > __devinitdata. > > > > > > I'll save the list from the mailbomb of this huge patchset. The > > > patches themselves are going to Greg KH for the driver core tree. > > > > > > > > > Bill Pemberton (493): > > [...] > > > 2942 files changed, 11645 insertions(+), 12116 deletions(-) > > > > So, I've got no problem with the reason for the change and I don't > > even think you need my ack for the bits that I maintain (though you > > have it if you want it). However, this looks like it is going to be > > /painful/. First of all it will touch a huge number of files in the > > tree. Yes the change is trivial, but it will require manual fixups on > > a lot of patches. > > Yeah, this is dopey. Send the script to Linus and ask him to run it > seven seconds before he releases -rc1, when everyone's trees are > empty(ish). Or send him a single megapatch at that time. > I like the script idea for removing all the __dev markings. Creating the patches in the first place was a game of whack-a-mole as various trees changed. -- Bill -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
Andrew Morton writes: On Tue, 20 Nov 2012 10:46:11 + Grant Likely grant.lik...@secretlab.ca wrote: On Sat, Nov 17, 2012 at 12:19 AM, Bill Pemberton wf...@virginia.edu wrote: CONFIG_HOTPLUG is no longer an optional setting. In order to remove it as on option code paths that check CONFIG_HOTPLUG will removed along with the attributes __devexit_p, __devexit, __devinitconst, and __devinitdata. I'll save the list from the mailbomb of this huge patchset. The patches themselves are going to Greg KH for the driver core tree. Bill Pemberton (493): [...] 2942 files changed, 11645 insertions(+), 12116 deletions(-) So, I've got no problem with the reason for the change and I don't even think you need my ack for the bits that I maintain (though you have it if you want it). However, this looks like it is going to be /painful/. First of all it will touch a huge number of files in the tree. Yes the change is trivial, but it will require manual fixups on a lot of patches. Yeah, this is dopey. Send the script to Linus and ask him to run it seven seconds before he releases -rc1, when everyone's trees are empty(ish). Or send him a single megapatch at that time. I like the script idea for removing all the __dev markings. Creating the patches in the first place was a game of whack-a-mole as various trees changed. -- Bill -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Wed, Nov 21, 2012 at 01:41:46PM -0500, Bill Pemberton wrote: Andrew Morton writes: On Tue, 20 Nov 2012 10:46:11 + Grant Likely grant.lik...@secretlab.ca wrote: On Sat, Nov 17, 2012 at 12:19 AM, Bill Pemberton wf...@virginia.edu wrote: CONFIG_HOTPLUG is no longer an optional setting. In order to remove it as on option code paths that check CONFIG_HOTPLUG will removed along with the attributes __devexit_p, __devexit, __devinitconst, and __devinitdata. I'll save the list from the mailbomb of this huge patchset. The patches themselves are going to Greg KH for the driver core tree. Bill Pemberton (493): [...] 2942 files changed, 11645 insertions(+), 12116 deletions(-) So, I've got no problem with the reason for the change and I don't even think you need my ack for the bits that I maintain (though you have it if you want it). However, this looks like it is going to be /painful/. First of all it will touch a huge number of files in the tree. Yes the change is trivial, but it will require manual fixups on a lot of patches. Yeah, this is dopey. Send the script to Linus and ask him to run it seven seconds before he releases -rc1, when everyone's trees are empty(ish). Or send him a single megapatch at that time. I like the script idea for removing all the __dev markings. Creating the patches in the first place was a game of whack-a-mole as various trees changed. Linus doesn't like to take scripts, I had planned on queueing all of these up that different subsystems maintainers didn't take, and pushing the ones that did merge cleanly into -rc1. Then, right after -rc1 is out, go through the tree once more to get the stragglers. Sound reasonable? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Tue, 20 Nov 2012 10:46:11 + Grant Likely wrote: > On Sat, Nov 17, 2012 at 12:19 AM, Bill Pemberton wrote: > > CONFIG_HOTPLUG is no longer an optional setting. In order to remove > > it as on option code paths that check CONFIG_HOTPLUG will removed > > along with the attributes __devexit_p, __devexit, __devinitconst, and > > __devinitdata. > > > > I'll save the list from the mailbomb of this huge patchset. The > > patches themselves are going to Greg KH for the driver core tree. > > > > > > Bill Pemberton (493): > [...] > > 2942 files changed, 11645 insertions(+), 12116 deletions(-) > > So, I've got no problem with the reason for the change and I don't > even think you need my ack for the bits that I maintain (though you > have it if you want it). However, this looks like it is going to be > /painful/. First of all it will touch a huge number of files in the > tree. Yes the change is trivial, but it will require manual fixups on > a lot of patches. Yeah, this is dopey. Send the script to Linus and ask him to run it seven seconds before he releases -rc1, when everyone's trees are empty(ish). Or send him a single megapatch at that time. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Sat, Nov 17, 2012 at 12:19 AM, Bill Pemberton wrote: > CONFIG_HOTPLUG is no longer an optional setting. In order to remove > it as on option code paths that check CONFIG_HOTPLUG will removed > along with the attributes __devexit_p, __devexit, __devinitconst, and > __devinitdata. > > I'll save the list from the mailbomb of this huge patchset. The > patches themselves are going to Greg KH for the driver core tree. > > > Bill Pemberton (493): [...] > 2942 files changed, 11645 insertions(+), 12116 deletions(-) So, I've got no problem with the reason for the change and I don't even think you need my ack for the bits that I maintain (though you have it if you want it). However, this looks like it is going to be /painful/. First of all it will touch a huge number of files in the tree. Yes the change is trivial, but it will require manual fixups on a lot of patches. It also means that any in-flight patches (on mailing list, in linux-next, whatever) that use __devinit will get broken by this series. Second; this is nearly 500 commits for effectively 1 change. I do not want to wade through bisect after this goes through. I'm assuming this whole thing was generated by a script. Does it really need to be split out so aggressively? For example, I really don't need one patch to remove __devinit, another to remove __devexit and another still to remove __devexit_p all applied against each of my subsystems. Personally, I'd rather see this change be performed far less aggressively. Yes, remove CONFIG_HOTPLUG, but leave the __devinit* macros as unconditional empty no-ops. There are only 24 patches associated with CONFIG_HOTPLUG and that one is actually dangerous to drivers when it goes away. It is safe to leave the __devinit macros lie fallow for a bit. Change check-patch to warn against new users of the macros, but don't do a full tree clean yet. Even if you do clean them right away, there still needs to be no-op versions of __devinit* for a while to avoid pain on in-flight changes. I'd also like to see the changes to each subsystem squashed together. That at least will cut down the number of individual commits by a factor of 4. Greg, what is your plan for merging this series? I assume you wouldn't drop it dead in the middle of the merge window. g. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Sat, Nov 17, 2012 at 12:19 AM, Bill Pemberton wf...@virginia.edu wrote: CONFIG_HOTPLUG is no longer an optional setting. In order to remove it as on option code paths that check CONFIG_HOTPLUG will removed along with the attributes __devexit_p, __devexit, __devinitconst, and __devinitdata. I'll save the list from the mailbomb of this huge patchset. The patches themselves are going to Greg KH for the driver core tree. Bill Pemberton (493): [...] 2942 files changed, 11645 insertions(+), 12116 deletions(-) So, I've got no problem with the reason for the change and I don't even think you need my ack for the bits that I maintain (though you have it if you want it). However, this looks like it is going to be /painful/. First of all it will touch a huge number of files in the tree. Yes the change is trivial, but it will require manual fixups on a lot of patches. It also means that any in-flight patches (on mailing list, in linux-next, whatever) that use __devinit will get broken by this series. Second; this is nearly 500 commits for effectively 1 change. I do not want to wade through bisect after this goes through. I'm assuming this whole thing was generated by a script. Does it really need to be split out so aggressively? For example, I really don't need one patch to remove __devinit, another to remove __devexit and another still to remove __devexit_p all applied against each of my subsystems. Personally, I'd rather see this change be performed far less aggressively. Yes, remove CONFIG_HOTPLUG, but leave the __devinit* macros as unconditional empty no-ops. There are only 24 patches associated with CONFIG_HOTPLUG and that one is actually dangerous to drivers when it goes away. It is safe to leave the __devinit macros lie fallow for a bit. Change check-patch to warn against new users of the macros, but don't do a full tree clean yet. Even if you do clean them right away, there still needs to be no-op versions of __devinit* for a while to avoid pain on in-flight changes. I'd also like to see the changes to each subsystem squashed together. That at least will cut down the number of individual commits by a factor of 4. Greg, what is your plan for merging this series? I assume you wouldn't drop it dead in the middle of the merge window. g. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Tue, 20 Nov 2012 10:46:11 + Grant Likely grant.lik...@secretlab.ca wrote: On Sat, Nov 17, 2012 at 12:19 AM, Bill Pemberton wf...@virginia.edu wrote: CONFIG_HOTPLUG is no longer an optional setting. In order to remove it as on option code paths that check CONFIG_HOTPLUG will removed along with the attributes __devexit_p, __devexit, __devinitconst, and __devinitdata. I'll save the list from the mailbomb of this huge patchset. The patches themselves are going to Greg KH for the driver core tree. Bill Pemberton (493): [...] 2942 files changed, 11645 insertions(+), 12116 deletions(-) So, I've got no problem with the reason for the change and I don't even think you need my ack for the bits that I maintain (though you have it if you want it). However, this looks like it is going to be /painful/. First of all it will touch a huge number of files in the tree. Yes the change is trivial, but it will require manual fixups on a lot of patches. Yeah, this is dopey. Send the script to Linus and ask him to run it seven seconds before he releases -rc1, when everyone's trees are empty(ish). Or send him a single megapatch at that time. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Sat, Nov 17, 2012 at 5:49 AM, Bill Pemberton wrote: > CONFIG_HOTPLUG is no longer an optional setting. In order to remove > it as on option code paths that check CONFIG_HOTPLUG will removed > along with the attributes __devexit_p, __devexit, __devinitconst, and > __devinitdata. > > I'll save the list from the mailbomb of this huge patchset. The > patches themselves are going to Greg KH for the driver core tree. > Fed up for replying on all mails :( Acked-by: Viresh Kumar for all mails where i am in cc :) -- viresh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Mon, Nov 19, 2012 at 09:27:09PM +0100, Rafael J. Wysocki wrote: > On Monday, November 19, 2012 12:01:49 PM Greg KH wrote: > > On Mon, Nov 19, 2012 at 11:55:56AM -0800, Dmitry Torokhov wrote: > > > On Fri, Nov 16, 2012 at 07:19:10PM -0500, Bill Pemberton wrote: > > > > CONFIG_HOTPLUG is no longer an optional setting. In order to remove > > > > it as on option code paths that check CONFIG_HOTPLUG will removed > > > > along with the attributes __devexit_p, __devexit, __devinitconst, and > > > > __devinitdata. > > > > > > > > I'll save the list from the mailbomb of this huge patchset. The > > > > patches themselves are going to Greg KH for the driver core tree. > > > > > > > > > > _iff_ we are going to do this I'd prefer pushing input pieces through my > > > tree to limit clashes with other work. > > > > That's fine with me. I'll ignore any drivers/input/ patches then, is > > that ok? > > Please do the same for PM/ACPI. Ok, will do. > Do I need to pull anything for those patches to compile without problems? Nope, it's just the removal of a symbol, that for 3.7, is defined away to be an empty string anyway :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Monday, November 19, 2012 12:01:49 PM Greg KH wrote: > On Mon, Nov 19, 2012 at 11:55:56AM -0800, Dmitry Torokhov wrote: > > On Fri, Nov 16, 2012 at 07:19:10PM -0500, Bill Pemberton wrote: > > > CONFIG_HOTPLUG is no longer an optional setting. In order to remove > > > it as on option code paths that check CONFIG_HOTPLUG will removed > > > along with the attributes __devexit_p, __devexit, __devinitconst, and > > > __devinitdata. > > > > > > I'll save the list from the mailbomb of this huge patchset. The > > > patches themselves are going to Greg KH for the driver core tree. > > > > > > > _iff_ we are going to do this I'd prefer pushing input pieces through my > > tree to limit clashes with other work. > > That's fine with me. I'll ignore any drivers/input/ patches then, is > that ok? Please do the same for PM/ACPI. Do I need to pull anything for those patches to compile without problems? Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Mon, Nov 19, 2012 at 11:55:56AM -0800, Dmitry Torokhov wrote: > On Fri, Nov 16, 2012 at 07:19:10PM -0500, Bill Pemberton wrote: > > CONFIG_HOTPLUG is no longer an optional setting. In order to remove > > it as on option code paths that check CONFIG_HOTPLUG will removed > > along with the attributes __devexit_p, __devexit, __devinitconst, and > > __devinitdata. > > > > I'll save the list from the mailbomb of this huge patchset. The > > patches themselves are going to Greg KH for the driver core tree. > > > > _iff_ we are going to do this I'd prefer pushing input pieces through my > tree to limit clashes with other work. That's fine with me. I'll ignore any drivers/input/ patches then, is that ok? thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Fri, Nov 16, 2012 at 07:19:10PM -0500, Bill Pemberton wrote: > CONFIG_HOTPLUG is no longer an optional setting. In order to remove > it as on option code paths that check CONFIG_HOTPLUG will removed > along with the attributes __devexit_p, __devexit, __devinitconst, and > __devinitdata. > > I'll save the list from the mailbomb of this huge patchset. The > patches themselves are going to Greg KH for the driver core tree. > _iff_ we are going to do this I'd prefer pushing input pieces through my tree to limit clashes with other work. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Sat, Nov 17, 2012 at 5:49 AM, Bill Pemberton wf...@virginia.edu wrote: CONFIG_HOTPLUG is no longer an optional setting. In order to remove it as on option code paths that check CONFIG_HOTPLUG will removed along with the attributes __devexit_p, __devexit, __devinitconst, and __devinitdata. I'll save the list from the mailbomb of this huge patchset. The patches themselves are going to Greg KH for the driver core tree. Fed up for replying on all mails :( Acked-by: Viresh Kumar viresh.ku...@linaro.org for all mails where i am in cc :) -- viresh -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Fri, Nov 16, 2012 at 07:19:10PM -0500, Bill Pemberton wrote: CONFIG_HOTPLUG is no longer an optional setting. In order to remove it as on option code paths that check CONFIG_HOTPLUG will removed along with the attributes __devexit_p, __devexit, __devinitconst, and __devinitdata. I'll save the list from the mailbomb of this huge patchset. The patches themselves are going to Greg KH for the driver core tree. _iff_ we are going to do this I'd prefer pushing input pieces through my tree to limit clashes with other work. Thanks. -- Dmitry -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Mon, Nov 19, 2012 at 11:55:56AM -0800, Dmitry Torokhov wrote: On Fri, Nov 16, 2012 at 07:19:10PM -0500, Bill Pemberton wrote: CONFIG_HOTPLUG is no longer an optional setting. In order to remove it as on option code paths that check CONFIG_HOTPLUG will removed along with the attributes __devexit_p, __devexit, __devinitconst, and __devinitdata. I'll save the list from the mailbomb of this huge patchset. The patches themselves are going to Greg KH for the driver core tree. _iff_ we are going to do this I'd prefer pushing input pieces through my tree to limit clashes with other work. That's fine with me. I'll ignore any drivers/input/ patches then, is that ok? thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Monday, November 19, 2012 12:01:49 PM Greg KH wrote: On Mon, Nov 19, 2012 at 11:55:56AM -0800, Dmitry Torokhov wrote: On Fri, Nov 16, 2012 at 07:19:10PM -0500, Bill Pemberton wrote: CONFIG_HOTPLUG is no longer an optional setting. In order to remove it as on option code paths that check CONFIG_HOTPLUG will removed along with the attributes __devexit_p, __devexit, __devinitconst, and __devinitdata. I'll save the list from the mailbomb of this huge patchset. The patches themselves are going to Greg KH for the driver core tree. _iff_ we are going to do this I'd prefer pushing input pieces through my tree to limit clashes with other work. That's fine with me. I'll ignore any drivers/input/ patches then, is that ok? Please do the same for PM/ACPI. Do I need to pull anything for those patches to compile without problems? Rafael -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 000/493] remove CONFIG_HOTPLUG as an option
On Mon, Nov 19, 2012 at 09:27:09PM +0100, Rafael J. Wysocki wrote: On Monday, November 19, 2012 12:01:49 PM Greg KH wrote: On Mon, Nov 19, 2012 at 11:55:56AM -0800, Dmitry Torokhov wrote: On Fri, Nov 16, 2012 at 07:19:10PM -0500, Bill Pemberton wrote: CONFIG_HOTPLUG is no longer an optional setting. In order to remove it as on option code paths that check CONFIG_HOTPLUG will removed along with the attributes __devexit_p, __devexit, __devinitconst, and __devinitdata. I'll save the list from the mailbomb of this huge patchset. The patches themselves are going to Greg KH for the driver core tree. _iff_ we are going to do this I'd prefer pushing input pieces through my tree to limit clashes with other work. That's fine with me. I'll ignore any drivers/input/ patches then, is that ok? Please do the same for PM/ACPI. Ok, will do. Do I need to pull anything for those patches to compile without problems? Nope, it's just the removal of a symbol, that for 3.7, is defined away to be an empty string anyway :) thanks, greg k-h -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
