Re: [PATCH 01/13] ACPICA: Remove unnecessary conditional compilation.

2015-10-16 Thread Rafael J. Wysocki 
On Friday, October 16, 2015 12:59:53 AM Zheng, Lv wrote:
> OK. I'll check it.
> There is no issue detected in my local test.
> I'll re-send the series after fixing the build issue.
> So Rafael please ignore this series for now.

OK

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 01/13] ACPICA: Remove unnecessary conditional compilation.

2015-10-16 Thread Rafael J. Wysocki 
On Friday, October 16, 2015 12:59:53 AM Zheng, Lv wrote:
> OK. I'll check it.
> There is no issue detected in my local test.
> I'll re-send the series after fixing the build issue.
> So Rafael please ignore this series for now.

OK

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [PATCH 01/13] ACPICA: Remove unnecessary conditional compilation.

2015-10-15 Thread Zheng, Lv 
OK. I'll check it.
There is no issue detected in my local test.
I'll re-send the series after fixing the build issue.
So Rafael please ignore this series for now.

Thanks and best regards
-Lv

> From: Moore, Robert
> Sent: Friday, October 16, 2015 2:33 AM
> 
> This appears as though it is related to this conditional:
> 
> #if defined(ACPI_DEBUG_OUTPUT) || defined(ACPI_DEBUGGER)
> /*
>  * rsinfo
>  */
> extern ACPI_RSDUMP_INFO *AcpiGbl_DumpResourceDispatch[];
> extern ACPI_RSDUMP_INFO *AcpiGbl_DumpSerialBusDispatch[];
> 
> 
> So, I'm going to let Lv take a look at this.
> Bob
> 
> 
> 
> > -Original Message-
> > From: lkp
> > Sent: Thursday, October 15, 2015 8:51 AM
> > To: Zheng, Lv
> > Cc: kbuild-...@01.org; Wysocki, Rafael J; Brown, Len; Zheng, Lv; Lv Zheng;
> > linux-kernel@vger.kernel.org; linux-a...@vger.kernel.org; Moore, Robert
> > Subject: Re: [PATCH 01/13] ACPICA: Remove unnecessary conditional
> > compilation.
> >
> > Hi Bob,
> >
> > [auto build test ERROR on pm/linux-next -- if it's inappropriate base,
> > please suggest rules for selecting the more suitable base]
> >
> > url:https://github.com/0day-ci/linux/commits/Lv-Zheng/ACPICA-20150930-
> > Release/20151015-101636
> > config: x86_64-lkp (attached as .config)
> > reproduce:
> > # save the attached .config to linux build tree
> > make ARCH=x86_64
> >
> > All errors (new ones prefixed by >>):
> >
> >drivers/acpi/acpica/rsdump.c: In function 'acpi_rs_dump_resource_list':
> > >> drivers/acpi/acpica/rsdump.c:136:7: error:
> > >> 'acpi_gbl_dump_serial_bus_dispatch' undeclared (first use in this
> > >> function)
> >   acpi_gbl_dump_serial_bus_dispatch
> >   ^
> >drivers/acpi/acpica/rsdump.c:136:7: note: each undeclared identifier is
> > reported only once for each function it appears in
> > >> drivers/acpi/acpica/rsdump.c:141:7: error:
> > >> 'acpi_gbl_dump_resource_dispatch' undeclared (first use in this
> > >> function)
> >   acpi_gbl_dump_resource_dispatch
> >   ^
> >drivers/acpi/acpica/rsdump.c: In function 'acpi_rs_dump_irq_list':
> > >> drivers/acpi/acpica/rsdump.c:186:40: error: 'acpi_rs_dump_prt'
> > >> undeclared (first use in this function)
> >   acpi_rs_dump_descriptor(prt_element, acpi_rs_dump_prt);
> >^
> >drivers/acpi/acpica/rsdump.c: In function
> > 'acpi_rs_dump_address_common':
> > >> drivers/acpi/acpica/rsdump.c:445:37: error:
> > >> 'acpi_rs_dump_memory_flags' undeclared (first use in this function)
> >   acpi_rs_dump_descriptor(resource, acpi_rs_dump_memory_flags);
> > ^
> > >> drivers/acpi/acpica/rsdump.c:450:37: error: 'acpi_rs_dump_io_flags'
> > >> undeclared (first use in this function)
> >   acpi_rs_dump_descriptor(resource, acpi_rs_dump_io_flags);
> > ^
> > >> drivers/acpi/acpica/rsdump.c:467:36: error:
> > >> 'acpi_rs_dump_general_flags' undeclared (first use in this function)
> >  acpi_rs_dump_descriptor(resource, acpi_rs_dump_general_flags);
> >^
> >
> > vim +/acpi_gbl_dump_serial_bus_dispatch +136 drivers/acpi/acpica/rsdump.c
> >
> > 39239fed Bob Moore 2015-04-13  130  }
> > 39239fed Bob Moore 2015-04-13  131
> > 39239fed Bob Moore 2015-04-13  132  /* Dump the resource
> > descriptor */
> > 39239fed Bob Moore 2015-04-13  133
> > 39239fed Bob Moore 2015-04-13  134  if (type ==
> > ACPI_RESOURCE_TYPE_SERIAL_BUS) {
> > 39239fed Bob Moore 2015-04-13  135
> > acpi_rs_dump_descriptor(_list->data,
> > 39239fed Bob Moore 2015-04-13 @136
> > acpi_gbl_dump_serial_bus_dispatch
> > 39239fed Bob Moore 2015-04-13  137
> > [resource_list->data.
> > 39239fed Bob Moore 2015-04-13  138
> > common_serial_bus.type]);
> > 39239fed Bob Moore 2015-04-13  139  } else {
> > 39239fed Bob Moore 2015-04-13  140
> > acpi_rs_dump_descriptor(_list->data,
> > 39239fed Bob Moore 2015-04-13 @141
> > acpi_gbl_dump_resource_dispatch
> > 39239fed Bob Moore 2015-04-13  142
> > [type]);
> > 39239fed Bob Moore 2015-04-13  143  }
> > 39239fed Bob Moore 2015-04-13  144
> >

RE: [PATCH 01/13] ACPICA: Remove unnecessary conditional compilation.

2015-10-15 Thread Moore, Robert 
This appears as though it is related to this conditional:

#if defined(ACPI_DEBUG_OUTPUT) || defined(ACPI_DEBUGGER)
/*
 * rsinfo
 */
extern ACPI_RSDUMP_INFO *AcpiGbl_DumpResourceDispatch[];
extern ACPI_RSDUMP_INFO *AcpiGbl_DumpSerialBusDispatch[];


So, I'm going to let Lv take a look at this.
Bob



> -Original Message-
> From: lkp
> Sent: Thursday, October 15, 2015 8:51 AM
> To: Zheng, Lv
> Cc: kbuild-...@01.org; Wysocki, Rafael J; Brown, Len; Zheng, Lv; Lv Zheng;
> linux-kernel@vger.kernel.org; linux-a...@vger.kernel.org; Moore, Robert
> Subject: Re: [PATCH 01/13] ACPICA: Remove unnecessary conditional
> compilation.
> 
> Hi Bob,
> 
> [auto build test ERROR on pm/linux-next -- if it's inappropriate base,
> please suggest rules for selecting the more suitable base]
> 
> url:https://github.com/0day-ci/linux/commits/Lv-Zheng/ACPICA-20150930-
> Release/20151015-101636
> config: x86_64-lkp (attached as .config)
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
> 
> All errors (new ones prefixed by >>):
> 
>drivers/acpi/acpica/rsdump.c: In function 'acpi_rs_dump_resource_list':
> >> drivers/acpi/acpica/rsdump.c:136:7: error:
> >> 'acpi_gbl_dump_serial_bus_dispatch' undeclared (first use in this
> >> function)
>   acpi_gbl_dump_serial_bus_dispatch
>   ^
>drivers/acpi/acpica/rsdump.c:136:7: note: each undeclared identifier is
> reported only once for each function it appears in
> >> drivers/acpi/acpica/rsdump.c:141:7: error:
> >> 'acpi_gbl_dump_resource_dispatch' undeclared (first use in this
> >> function)
>   acpi_gbl_dump_resource_dispatch
>   ^
>drivers/acpi/acpica/rsdump.c: In function 'acpi_rs_dump_irq_list':
> >> drivers/acpi/acpica/rsdump.c:186:40: error: 'acpi_rs_dump_prt'
> >> undeclared (first use in this function)
>   acpi_rs_dump_descriptor(prt_element, acpi_rs_dump_prt);
>^
>drivers/acpi/acpica/rsdump.c: In function
> 'acpi_rs_dump_address_common':
> >> drivers/acpi/acpica/rsdump.c:445:37: error:
> >> 'acpi_rs_dump_memory_flags' undeclared (first use in this function)
>   acpi_rs_dump_descriptor(resource, acpi_rs_dump_memory_flags);
> ^
> >> drivers/acpi/acpica/rsdump.c:450:37: error: 'acpi_rs_dump_io_flags'
> >> undeclared (first use in this function)
>   acpi_rs_dump_descriptor(resource, acpi_rs_dump_io_flags);
> ^
> >> drivers/acpi/acpica/rsdump.c:467:36: error:
> >> 'acpi_rs_dump_general_flags' undeclared (first use in this function)
>  acpi_rs_dump_descriptor(resource, acpi_rs_dump_general_flags);
>^
> 
> vim +/acpi_gbl_dump_serial_bus_dispatch +136 drivers/acpi/acpica/rsdump.c
> 
> 39239fed Bob Moore 2015-04-13  130}
> 39239fed Bob Moore 2015-04-13  131
> 39239fed Bob Moore 2015-04-13  132/* Dump the resource
> descriptor */
> 39239fed Bob Moore 2015-04-13  133
> 39239fed Bob Moore 2015-04-13  134if (type ==
> ACPI_RESOURCE_TYPE_SERIAL_BUS) {
> 39239fed Bob Moore 2015-04-13  135
>   acpi_rs_dump_descriptor(_list->data,
> 39239fed Bob Moore 2015-04-13 @136
>   acpi_gbl_dump_serial_bus_dispatch
> 39239fed Bob Moore 2015-04-13  137
>   [resource_list->data.
> 39239fed Bob Moore 2015-04-13  138
> common_serial_bus.type]);
> 39239fed Bob Moore 2015-04-13  139} else {
> 39239fed Bob Moore 2015-04-13  140
>   acpi_rs_dump_descriptor(_list->data,
> 39239fed Bob Moore 2015-04-13 @141
>   acpi_gbl_dump_resource_dispatch
> 39239fed Bob Moore 2015-04-13  142
>   [type]);
> 39239fed Bob Moore 2015-04-13  143}
> 39239fed Bob Moore 2015-04-13  144
> 39239fed Bob Moore 2015-04-13  145/* Point to the next
> resource structure */
> 39239fed Bob Moore 2015-04-13  146
> 39239fed Bob Moore 2015-04-13  147resource_list =
> ACPI_NEXT_RESOURCE(resource_list);
> 39239fed Bob Moore 2015-04-13  148
> 39239fed Bob Moore 2015-04-13  149/* Exit when END_TAG
> descriptor is reached */
> 39239fed Bob Moore 2015-04-13  150
> 39239fed Bob Moore 2015-04-13  151} while (type !=
> ACPI_RESOURCE_TYPE_END_TAG);
> 39239fed Bob Moore 2015-04-13  152  }
> 39239fed Bob Moore 2015-04-13  153
> 39239fed Bob Moore 2015-04-13  154
> /*
> **
> 39239fed Bob Moore 2015-04-13  155   *
> 39239fed Bob Moore 2015-04-13  156   * FUNCTION:acpi_rs_dump_irq_

Re: [PATCH 01/13] ACPICA: Remove unnecessary conditional compilation.

2015-10-15 Thread kbuild test robot 
Hi Bob,

[auto build test ERROR on pm/linux-next -- if it's inappropriate base, please 
suggest rules for selecting the more suitable base]

url:
https://github.com/0day-ci/linux/commits/Lv-Zheng/ACPICA-20150930-Release/20151015-101636
config: x86_64-lkp (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/acpi/acpica/rsdump.c: In function 'acpi_rs_dump_resource_list':
>> drivers/acpi/acpica/rsdump.c:136:7: error: 
>> 'acpi_gbl_dump_serial_bus_dispatch' undeclared (first use in this function)
  acpi_gbl_dump_serial_bus_dispatch
  ^
   drivers/acpi/acpica/rsdump.c:136:7: note: each undeclared identifier is 
reported only once for each function it appears in
>> drivers/acpi/acpica/rsdump.c:141:7: error: 'acpi_gbl_dump_resource_dispatch' 
>> undeclared (first use in this function)
  acpi_gbl_dump_resource_dispatch
  ^
   drivers/acpi/acpica/rsdump.c: In function 'acpi_rs_dump_irq_list':
>> drivers/acpi/acpica/rsdump.c:186:40: error: 'acpi_rs_dump_prt' undeclared 
>> (first use in this function)
  acpi_rs_dump_descriptor(prt_element, acpi_rs_dump_prt);
   ^
   drivers/acpi/acpica/rsdump.c: In function 'acpi_rs_dump_address_common':
>> drivers/acpi/acpica/rsdump.c:445:37: error: 'acpi_rs_dump_memory_flags' 
>> undeclared (first use in this function)
  acpi_rs_dump_descriptor(resource, acpi_rs_dump_memory_flags);
^
>> drivers/acpi/acpica/rsdump.c:450:37: error: 'acpi_rs_dump_io_flags' 
>> undeclared (first use in this function)
  acpi_rs_dump_descriptor(resource, acpi_rs_dump_io_flags);
^
>> drivers/acpi/acpica/rsdump.c:467:36: error: 'acpi_rs_dump_general_flags' 
>> undeclared (first use in this function)
 acpi_rs_dump_descriptor(resource, acpi_rs_dump_general_flags);
   ^

vim +/acpi_gbl_dump_serial_bus_dispatch +136 drivers/acpi/acpica/rsdump.c

39239fed Bob Moore 2015-04-13  130  }
39239fed Bob Moore 2015-04-13  131  
39239fed Bob Moore 2015-04-13  132  /* Dump the resource descriptor 
*/
39239fed Bob Moore 2015-04-13  133  
39239fed Bob Moore 2015-04-13  134  if (type == 
ACPI_RESOURCE_TYPE_SERIAL_BUS) {
39239fed Bob Moore 2015-04-13  135  
acpi_rs_dump_descriptor(_list->data,
39239fed Bob Moore 2015-04-13 @136  
acpi_gbl_dump_serial_bus_dispatch
39239fed Bob Moore 2015-04-13  137  
[resource_list->data.
39239fed Bob Moore 2015-04-13  138  
 common_serial_bus.type]);
39239fed Bob Moore 2015-04-13  139  } else {
39239fed Bob Moore 2015-04-13  140  
acpi_rs_dump_descriptor(_list->data,
39239fed Bob Moore 2015-04-13 @141  
acpi_gbl_dump_resource_dispatch
39239fed Bob Moore 2015-04-13  142  
[type]);
39239fed Bob Moore 2015-04-13  143  }
39239fed Bob Moore 2015-04-13  144  
39239fed Bob Moore 2015-04-13  145  /* Point to the next resource 
structure */
39239fed Bob Moore 2015-04-13  146  
39239fed Bob Moore 2015-04-13  147  resource_list = 
ACPI_NEXT_RESOURCE(resource_list);
39239fed Bob Moore 2015-04-13  148  
39239fed Bob Moore 2015-04-13  149  /* Exit when END_TAG descriptor 
is reached */
39239fed Bob Moore 2015-04-13  150  
39239fed Bob Moore 2015-04-13  151  } while (type != 
ACPI_RESOURCE_TYPE_END_TAG);
39239fed Bob Moore 2015-04-13  152  }
39239fed Bob Moore 2015-04-13  153  
39239fed Bob Moore 2015-04-13  154  
/***
39239fed Bob Moore 2015-04-13  155   *
39239fed Bob Moore 2015-04-13  156   * FUNCTION:acpi_rs_dump_irq_list
39239fed Bob Moore 2015-04-13  157   *
39239fed Bob Moore 2015-04-13  158   * PARAMETERS:  route_table - Pointer 
to the routing table to dump.
39239fed Bob Moore 2015-04-13  159   *
39239fed Bob Moore 2015-04-13  160   * RETURN:  None
39239fed Bob Moore 2015-04-13  161   *
39239fed Bob Moore 2015-04-13  162   * DESCRIPTION: Print IRQ routing table
39239fed Bob Moore 2015-04-13  163   *
39239fed Bob Moore 2015-04-13  164   
**/
39239fed Bob Moore 2015-04-13  165  
39239fed Bob Moore 2015-04-13  166  void acpi_rs_dump_irq_list(u8 *route_table)
39239fed Bob Moore 2015-04-13  167  {
39239fed Bob Moore 2015-04-13  168  struct acpi_pci_routing_table 
*prt_element;
39239fed Bob Moore 2015-04-13  169  u8 count;
39239fed Bob Moore 2015-04-13  170  
39239fed Bob Moore 2015-04-13  171  ACPI_FUNCTION_ENTRY();
39239fed Bob Moore 2015-04-13  172

Re: [PATCH 01/13] ACPICA: Remove unnecessary conditional compilation.

2015-10-15 Thread kbuild test robot 
Hi Bob,

[auto build test ERROR on pm/linux-next -- if it's inappropriate base, please 
suggest rules for selecting the more suitable base]

url:
https://github.com/0day-ci/linux/commits/Lv-Zheng/ACPICA-20150930-Release/20151015-101636
config: x86_64-lkp (attached as .config)
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/acpi/acpica/rsdump.c: In function 'acpi_rs_dump_resource_list':
>> drivers/acpi/acpica/rsdump.c:136:7: error: 
>> 'acpi_gbl_dump_serial_bus_dispatch' undeclared (first use in this function)
  acpi_gbl_dump_serial_bus_dispatch
  ^
   drivers/acpi/acpica/rsdump.c:136:7: note: each undeclared identifier is 
reported only once for each function it appears in
>> drivers/acpi/acpica/rsdump.c:141:7: error: 'acpi_gbl_dump_resource_dispatch' 
>> undeclared (first use in this function)
  acpi_gbl_dump_resource_dispatch
  ^
   drivers/acpi/acpica/rsdump.c: In function 'acpi_rs_dump_irq_list':
>> drivers/acpi/acpica/rsdump.c:186:40: error: 'acpi_rs_dump_prt' undeclared 
>> (first use in this function)
  acpi_rs_dump_descriptor(prt_element, acpi_rs_dump_prt);
   ^
   drivers/acpi/acpica/rsdump.c: In function 'acpi_rs_dump_address_common':
>> drivers/acpi/acpica/rsdump.c:445:37: error: 'acpi_rs_dump_memory_flags' 
>> undeclared (first use in this function)
  acpi_rs_dump_descriptor(resource, acpi_rs_dump_memory_flags);
^
>> drivers/acpi/acpica/rsdump.c:450:37: error: 'acpi_rs_dump_io_flags' 
>> undeclared (first use in this function)
  acpi_rs_dump_descriptor(resource, acpi_rs_dump_io_flags);
^
>> drivers/acpi/acpica/rsdump.c:467:36: error: 'acpi_rs_dump_general_flags' 
>> undeclared (first use in this function)
 acpi_rs_dump_descriptor(resource, acpi_rs_dump_general_flags);
   ^

vim +/acpi_gbl_dump_serial_bus_dispatch +136 drivers/acpi/acpica/rsdump.c

39239fed Bob Moore 2015-04-13  130  }
39239fed Bob Moore 2015-04-13  131  
39239fed Bob Moore 2015-04-13  132  /* Dump the resource descriptor 
*/
39239fed Bob Moore 2015-04-13  133  
39239fed Bob Moore 2015-04-13  134  if (type == 
ACPI_RESOURCE_TYPE_SERIAL_BUS) {
39239fed Bob Moore 2015-04-13  135  
acpi_rs_dump_descriptor(_list->data,
39239fed Bob Moore 2015-04-13 @136  
acpi_gbl_dump_serial_bus_dispatch
39239fed Bob Moore 2015-04-13  137  
[resource_list->data.
39239fed Bob Moore 2015-04-13  138  
 common_serial_bus.type]);
39239fed Bob Moore 2015-04-13  139  } else {
39239fed Bob Moore 2015-04-13  140  
acpi_rs_dump_descriptor(_list->data,
39239fed Bob Moore 2015-04-13 @141  
acpi_gbl_dump_resource_dispatch
39239fed Bob Moore 2015-04-13  142  
[type]);
39239fed Bob Moore 2015-04-13  143  }
39239fed Bob Moore 2015-04-13  144  
39239fed Bob Moore 2015-04-13  145  /* Point to the next resource 
structure */
39239fed Bob Moore 2015-04-13  146  
39239fed Bob Moore 2015-04-13  147  resource_list = 
ACPI_NEXT_RESOURCE(resource_list);
39239fed Bob Moore 2015-04-13  148  
39239fed Bob Moore 2015-04-13  149  /* Exit when END_TAG descriptor 
is reached */
39239fed Bob Moore 2015-04-13  150  
39239fed Bob Moore 2015-04-13  151  } while (type != 
ACPI_RESOURCE_TYPE_END_TAG);
39239fed Bob Moore 2015-04-13  152  }
39239fed Bob Moore 2015-04-13  153  
39239fed Bob Moore 2015-04-13  154  
/***
39239fed Bob Moore 2015-04-13  155   *
39239fed Bob Moore 2015-04-13  156   * FUNCTION:acpi_rs_dump_irq_list
39239fed Bob Moore 2015-04-13  157   *
39239fed Bob Moore 2015-04-13  158   * PARAMETERS:  route_table - Pointer 
to the routing table to dump.
39239fed Bob Moore 2015-04-13  159   *
39239fed Bob Moore 2015-04-13  160   * RETURN:  None
39239fed Bob Moore 2015-04-13  161   *
39239fed Bob Moore 2015-04-13  162   * DESCRIPTION: Print IRQ routing table
39239fed Bob Moore 2015-04-13  163   *
39239fed Bob Moore 2015-04-13  164   
**/
39239fed Bob Moore 2015-04-13  165  
39239fed Bob Moore 2015-04-13  166  void acpi_rs_dump_irq_list(u8 *route_table)
39239fed Bob Moore 2015-04-13  167  {
39239fed Bob Moore 2015-04-13  168  struct acpi_pci_routing_table 
*prt_element;
39239fed Bob Moore 2015-04-13  169  u8 count;
39239fed Bob Moore 2015-04-13  170  
39239fed Bob Moore 2015-04-13  171  ACPI_FUNCTION_ENTRY();
39239fed Bob Moore 2015-04-13  172

RE: [PATCH 01/13] ACPICA: Remove unnecessary conditional compilation.

2015-10-15 Thread Zheng, Lv 
OK. I'll check it.
There is no issue detected in my local test.
I'll re-send the series after fixing the build issue.
So Rafael please ignore this series for now.

Thanks and best regards
-Lv

> From: Moore, Robert
> Sent: Friday, October 16, 2015 2:33 AM
> 
> This appears as though it is related to this conditional:
> 
> #if defined(ACPI_DEBUG_OUTPUT) || defined(ACPI_DEBUGGER)
> /*
>  * rsinfo
>  */
> extern ACPI_RSDUMP_INFO *AcpiGbl_DumpResourceDispatch[];
> extern ACPI_RSDUMP_INFO *AcpiGbl_DumpSerialBusDispatch[];
> 
> 
> So, I'm going to let Lv take a look at this.
> Bob
> 
> 
> 
> > -Original Message-
> > From: lkp
> > Sent: Thursday, October 15, 2015 8:51 AM
> > To: Zheng, Lv
> > Cc: kbuild-...@01.org; Wysocki, Rafael J; Brown, Len; Zheng, Lv; Lv Zheng;
> > linux-kernel@vger.kernel.org; linux-a...@vger.kernel.org; Moore, Robert
> > Subject: Re: [PATCH 01/13] ACPICA: Remove unnecessary conditional
> > compilation.
> >
> > Hi Bob,
> >
> > [auto build test ERROR on pm/linux-next -- if it's inappropriate base,
> > please suggest rules for selecting the more suitable base]
> >
> > url:https://github.com/0day-ci/linux/commits/Lv-Zheng/ACPICA-20150930-
> > Release/20151015-101636
> > config: x86_64-lkp (attached as .config)
> > reproduce:
> > # save the attached .config to linux build tree
> > make ARCH=x86_64
> >
> > All errors (new ones prefixed by >>):
> >
> >drivers/acpi/acpica/rsdump.c: In function 'acpi_rs_dump_resource_list':
> > >> drivers/acpi/acpica/rsdump.c:136:7: error:
> > >> 'acpi_gbl_dump_serial_bus_dispatch' undeclared (first use in this
> > >> function)
> >   acpi_gbl_dump_serial_bus_dispatch
> >   ^
> >drivers/acpi/acpica/rsdump.c:136:7: note: each undeclared identifier is
> > reported only once for each function it appears in
> > >> drivers/acpi/acpica/rsdump.c:141:7: error:
> > >> 'acpi_gbl_dump_resource_dispatch' undeclared (first use in this
> > >> function)
> >   acpi_gbl_dump_resource_dispatch
> >   ^
> >drivers/acpi/acpica/rsdump.c: In function 'acpi_rs_dump_irq_list':
> > >> drivers/acpi/acpica/rsdump.c:186:40: error: 'acpi_rs_dump_prt'
> > >> undeclared (first use in this function)
> >   acpi_rs_dump_descriptor(prt_element, acpi_rs_dump_prt);
> >^
> >drivers/acpi/acpica/rsdump.c: In function
> > 'acpi_rs_dump_address_common':
> > >> drivers/acpi/acpica/rsdump.c:445:37: error:
> > >> 'acpi_rs_dump_memory_flags' undeclared (first use in this function)
> >   acpi_rs_dump_descriptor(resource, acpi_rs_dump_memory_flags);
> > ^
> > >> drivers/acpi/acpica/rsdump.c:450:37: error: 'acpi_rs_dump_io_flags'
> > >> undeclared (first use in this function)
> >   acpi_rs_dump_descriptor(resource, acpi_rs_dump_io_flags);
> > ^
> > >> drivers/acpi/acpica/rsdump.c:467:36: error:
> > >> 'acpi_rs_dump_general_flags' undeclared (first use in this function)
> >  acpi_rs_dump_descriptor(resource, acpi_rs_dump_general_flags);
> >^
> >
> > vim +/acpi_gbl_dump_serial_bus_dispatch +136 drivers/acpi/acpica/rsdump.c
> >
> > 39239fed Bob Moore 2015-04-13  130  }
> > 39239fed Bob Moore 2015-04-13  131
> > 39239fed Bob Moore 2015-04-13  132  /* Dump the resource
> > descriptor */
> > 39239fed Bob Moore 2015-04-13  133
> > 39239fed Bob Moore 2015-04-13  134  if (type ==
> > ACPI_RESOURCE_TYPE_SERIAL_BUS) {
> > 39239fed Bob Moore 2015-04-13  135
> > acpi_rs_dump_descriptor(_list->data,
> > 39239fed Bob Moore 2015-04-13 @136
> > acpi_gbl_dump_serial_bus_dispatch
> > 39239fed Bob Moore 2015-04-13  137
> > [resource_list->data.
> > 39239fed Bob Moore 2015-04-13  138
> > common_serial_bus.type]);
> > 39239fed Bob Moore 2015-04-13  139  } else {
> > 39239fed Bob Moore 2015-04-13  140
> > acpi_rs_dump_descriptor(_list->data,
> > 39239fed Bob Moore 2015-04-13 @141
> > acpi_gbl_dump_resource_dispatch
> > 39239fed Bob Moore 2015-04-13  142
> > [type]);
> > 39239fed Bob Moore 2015-04-13  143  }
> > 39239fed Bob Moore 2015-04-13  144
> >

RE: [PATCH 01/13] ACPICA: Remove unnecessary conditional compilation.

2015-10-15 Thread Moore, Robert 
This appears as though it is related to this conditional:

#if defined(ACPI_DEBUG_OUTPUT) || defined(ACPI_DEBUGGER)
/*
 * rsinfo
 */
extern ACPI_RSDUMP_INFO *AcpiGbl_DumpResourceDispatch[];
extern ACPI_RSDUMP_INFO *AcpiGbl_DumpSerialBusDispatch[];


So, I'm going to let Lv take a look at this.
Bob



> -Original Message-
> From: lkp
> Sent: Thursday, October 15, 2015 8:51 AM
> To: Zheng, Lv
> Cc: kbuild-...@01.org; Wysocki, Rafael J; Brown, Len; Zheng, Lv; Lv Zheng;
> linux-kernel@vger.kernel.org; linux-a...@vger.kernel.org; Moore, Robert
> Subject: Re: [PATCH 01/13] ACPICA: Remove unnecessary conditional
> compilation.
> 
> Hi Bob,
> 
> [auto build test ERROR on pm/linux-next -- if it's inappropriate base,
> please suggest rules for selecting the more suitable base]
> 
> url:https://github.com/0day-ci/linux/commits/Lv-Zheng/ACPICA-20150930-
> Release/20151015-101636
> config: x86_64-lkp (attached as .config)
> reproduce:
> # save the attached .config to linux build tree
> make ARCH=x86_64
> 
> All errors (new ones prefixed by >>):
> 
>drivers/acpi/acpica/rsdump.c: In function 'acpi_rs_dump_resource_list':
> >> drivers/acpi/acpica/rsdump.c:136:7: error:
> >> 'acpi_gbl_dump_serial_bus_dispatch' undeclared (first use in this
> >> function)
>   acpi_gbl_dump_serial_bus_dispatch
>   ^
>drivers/acpi/acpica/rsdump.c:136:7: note: each undeclared identifier is
> reported only once for each function it appears in
> >> drivers/acpi/acpica/rsdump.c:141:7: error:
> >> 'acpi_gbl_dump_resource_dispatch' undeclared (first use in this
> >> function)
>   acpi_gbl_dump_resource_dispatch
>   ^
>drivers/acpi/acpica/rsdump.c: In function 'acpi_rs_dump_irq_list':
> >> drivers/acpi/acpica/rsdump.c:186:40: error: 'acpi_rs_dump_prt'
> >> undeclared (first use in this function)
>   acpi_rs_dump_descriptor(prt_element, acpi_rs_dump_prt);
>^
>drivers/acpi/acpica/rsdump.c: In function
> 'acpi_rs_dump_address_common':
> >> drivers/acpi/acpica/rsdump.c:445:37: error:
> >> 'acpi_rs_dump_memory_flags' undeclared (first use in this function)
>   acpi_rs_dump_descriptor(resource, acpi_rs_dump_memory_flags);
> ^
> >> drivers/acpi/acpica/rsdump.c:450:37: error: 'acpi_rs_dump_io_flags'
> >> undeclared (first use in this function)
>   acpi_rs_dump_descriptor(resource, acpi_rs_dump_io_flags);
> ^
> >> drivers/acpi/acpica/rsdump.c:467:36: error:
> >> 'acpi_rs_dump_general_flags' undeclared (first use in this function)
>  acpi_rs_dump_descriptor(resource, acpi_rs_dump_general_flags);
>^
> 
> vim +/acpi_gbl_dump_serial_bus_dispatch +136 drivers/acpi/acpica/rsdump.c
> 
> 39239fed Bob Moore 2015-04-13  130}
> 39239fed Bob Moore 2015-04-13  131
> 39239fed Bob Moore 2015-04-13  132/* Dump the resource
> descriptor */
> 39239fed Bob Moore 2015-04-13  133
> 39239fed Bob Moore 2015-04-13  134if (type ==
> ACPI_RESOURCE_TYPE_SERIAL_BUS) {
> 39239fed Bob Moore 2015-04-13  135
>   acpi_rs_dump_descriptor(_list->data,
> 39239fed Bob Moore 2015-04-13 @136
>   acpi_gbl_dump_serial_bus_dispatch
> 39239fed Bob Moore 2015-04-13  137
>   [resource_list->data.
> 39239fed Bob Moore 2015-04-13  138
> common_serial_bus.type]);
> 39239fed Bob Moore 2015-04-13  139} else {
> 39239fed Bob Moore 2015-04-13  140
>   acpi_rs_dump_descriptor(_list->data,
> 39239fed Bob Moore 2015-04-13 @141
>   acpi_gbl_dump_resource_dispatch
> 39239fed Bob Moore 2015-04-13  142
>   [type]);
> 39239fed Bob Moore 2015-04-13  143}
> 39239fed Bob Moore 2015-04-13  144
> 39239fed Bob Moore 2015-04-13  145/* Point to the next
> resource structure */
> 39239fed Bob Moore 2015-04-13  146
> 39239fed Bob Moore 2015-04-13  147resource_list =
> ACPI_NEXT_RESOURCE(resource_list);
> 39239fed Bob Moore 2015-04-13  148
> 39239fed Bob Moore 2015-04-13  149/* Exit when END_TAG
> descriptor is reached */
> 39239fed Bob Moore 2015-04-13  150
> 39239fed Bob Moore 2015-04-13  151} while (type !=
> ACPI_RESOURCE_TYPE_END_TAG);
> 39239fed Bob Moore 2015-04-13  152  }
> 39239fed Bob Moore 2015-04-13  153
> 39239fed Bob Moore 2015-04-13  154
> /*
> **
> 39239fed Bob Moore 2015-04-13  155   *
> 39239fed Bob Moore 2015-04-13  156   * FUNCTION:acpi_rs_dump_irq_

[PATCH 01/13] ACPICA: Remove unnecessary conditional compilation.

2015-10-14 Thread Lv Zheng 
From: Bob Moore 

ACPICA commit eea1f0e561893b6d6417913b2d224082fe3a0a5e

Remove use of ACPI_DEBUGGER and ACPI_DISASSEMBLER where these
defines are used around entire modules.

Note: This type of code also causes problems with IDEs.

Link: https://github.com/acpica/acpica/commit/eea1f0e5
Signed-off-by: Bob Moore 
Signed-off-by: Lv Zheng 
---
 drivers/acpi/acpica/acdebug.h |6 ++
 drivers/acpi/acpica/rsdump.c  |3 ---
 include/acpi/platform/acenv.h |2 +-
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/acpi/acpica/acdebug.h b/drivers/acpi/acpica/acdebug.h
index eb2e926..c928ba4 100644
--- a/drivers/acpi/acpica/acdebug.h
+++ b/drivers/acpi/acpica/acdebug.h
@@ -44,6 +44,12 @@
 #ifndef __ACDEBUG_H__
 #define __ACDEBUG_H__
 
+/* The debugger is used in conjunction with the disassembler most of time */
+
+#ifdef ACPI_DISASSEMBLER
+#include "acdisasm.h"
+#endif
+
 #define ACPI_DEBUG_BUFFER_SIZE  0x4000 /* 16K buffer for return objects */
 
 struct acpi_db_command_info {
diff --git a/drivers/acpi/acpica/rsdump.c b/drivers/acpi/acpica/rsdump.c
index c428bb3..2a09288 100644
--- a/drivers/acpi/acpica/rsdump.c
+++ b/drivers/acpi/acpica/rsdump.c
@@ -51,7 +51,6 @@ ACPI_MODULE_NAME("rsdump")
 /*
  * All functions in this module are used by the AML Debugger only
  */
-#if defined(ACPI_DEBUGGER)
 /* Local prototypes */
 static void acpi_rs_out_string(char *title, char *value);
 
@@ -565,5 +564,3 @@ static void acpi_rs_dump_word_list(u16 length, u16 *data)
acpi_os_printf("%25s%2.2X : %4.4X\n", "Word", i, data[i]);
}
 }
-
-#endif
diff --git a/include/acpi/platform/acenv.h b/include/acpi/platform/acenv.h
index ec00e2b..15ef08c 100644
--- a/include/acpi/platform/acenv.h
+++ b/include/acpi/platform/acenv.h
@@ -142,7 +142,7 @@
 
 #ifdef ACPI_LIBRARY
 #define ACPI_USE_LOCAL_CACHE
-#define ACPI_FUTURE_USAGE
+#define ACPI_FULL_DEBUG
 #endif
 
 /* Common for all ACPICA applications */
-- 
1.7.10

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 01/13] ACPICA: Remove unnecessary conditional compilation.

2015-10-14 Thread Lv Zheng 
From: Bob Moore 

ACPICA commit eea1f0e561893b6d6417913b2d224082fe3a0a5e

Remove use of ACPI_DEBUGGER and ACPI_DISASSEMBLER where these
defines are used around entire modules.

Note: This type of code also causes problems with IDEs.

Link: https://github.com/acpica/acpica/commit/eea1f0e5
Signed-off-by: Bob Moore 
Signed-off-by: Lv Zheng 
---
 drivers/acpi/acpica/acdebug.h |6 ++
 drivers/acpi/acpica/rsdump.c  |3 ---
 include/acpi/platform/acenv.h |2 +-
 3 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/acpi/acpica/acdebug.h b/drivers/acpi/acpica/acdebug.h
index eb2e926..c928ba4 100644
--- a/drivers/acpi/acpica/acdebug.h
+++ b/drivers/acpi/acpica/acdebug.h
@@ -44,6 +44,12 @@
 #ifndef __ACDEBUG_H__
 #define __ACDEBUG_H__
 
+/* The debugger is used in conjunction with the disassembler most of time */
+
+#ifdef ACPI_DISASSEMBLER
+#include "acdisasm.h"
+#endif
+
 #define ACPI_DEBUG_BUFFER_SIZE  0x4000 /* 16K buffer for return objects */
 
 struct acpi_db_command_info {
diff --git a/drivers/acpi/acpica/rsdump.c b/drivers/acpi/acpica/rsdump.c
index c428bb3..2a09288 100644
--- a/drivers/acpi/acpica/rsdump.c
+++ b/drivers/acpi/acpica/rsdump.c
@@ -51,7 +51,6 @@ ACPI_MODULE_NAME("rsdump")
 /*
  * All functions in this module are used by the AML Debugger only
  */
-#if defined(ACPI_DEBUGGER)
 /* Local prototypes */
 static void acpi_rs_out_string(char *title, char *value);
 
@@ -565,5 +564,3 @@ static void acpi_rs_dump_word_list(u16 length, u16 *data)
acpi_os_printf("%25s%2.2X : %4.4X\n", "Word", i, data[i]);
}
 }
-
-#endif
diff --git a/include/acpi/platform/acenv.h b/include/acpi/platform/acenv.h
index ec00e2b..15ef08c 100644
--- a/include/acpi/platform/acenv.h
+++ b/include/acpi/platform/acenv.h
@@ -142,7 +142,7 @@
 
 #ifdef ACPI_LIBRARY
 #define ACPI_USE_LOCAL_CACHE
-#define ACPI_FUTURE_USAGE
+#define ACPI_FULL_DEBUG
 #endif
 
 /* Common for all ACPICA applications */
-- 
1.7.10

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/