Re: [PATCH 01/45] Makefile: propagate verbose options

2015-03-10 Thread Mikko Rapeli
On Tue, Feb 17, 2015 at 04:18:12PM +0900, Masahiro Yamada wrote:
> Hi Mikko,
> 
> On Tue, 17 Feb 2015 00:05:04 +0100
> Mikko Rapeli  wrote:
> 
> > Usefull when debugging the make scripts.
> > 
> > Signed-off-by: Mikko Rapeli 
> > ---
> >  Makefile | 8 
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/Makefile b/Makefile
> > index 4e93284..c1b515d 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -912,13 +912,13 @@ quiet_cmd_link-vmlinux = LINK$@
> >  # execute if the rest of the kernel build went well.
> >  vmlinux: scripts/link-vmlinux.sh $(vmlinux-deps) FORCE
> >  ifdef CONFIG_HEADERS_CHECK
> > -   $(Q)$(MAKE) -f $(srctree)/Makefile headers_check
> > +   $(Q)$(MAKE) V=$(KBUILD_VERBOSE) -f $(srctree)/Makefile headers_check
> >  endif
> >  ifdef CONFIG_SAMPLES
> > -   $(Q)$(MAKE) $(build)=samples
> > +   $(Q)$(MAKE) V=$(KBUILD_VERBOSE) $(build)=samples
> >  endif
> >  ifdef CONFIG_BUILD_DOCSRC
> > -   $(Q)$(MAKE) $(build)=Documentation
> > +   $(Q)$(MAKE) V=$(KBUILD_VERBOSE) $(build)=Documentation
> >  endif
> > +$(call if_changed,link-vmlinux)
> >  
> > @@ -1069,7 +1069,7 @@ headers_check_all: headers_install_all
> >  PHONY += headers_check
> >  headers_check: headers_install
> > $(Q)$(MAKE) $(hdr-inst)=include/uapi HDRCHECK=1
> > -   $(Q)$(MAKE) $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) 
> > HDRCHECK=1
> > +   $(Q)$(MAKE) V=$(KBUILD_VERBOSE) 
> > $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) HDRCHECK=1
> >  
> >  # 
> > ---
> >  # Kernel selftest
> 
> 
> 
> If you give V=... from the command line, it is automatically propagated
> to its sub-makes.
> 
> I think this patch has no point.

You are right, I'll drop this patch.

-Mikko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 01/45] Makefile: propagate verbose options

2015-03-10 Thread Mikko Rapeli
On Tue, Feb 17, 2015 at 04:18:12PM +0900, Masahiro Yamada wrote:
 Hi Mikko,
 
 On Tue, 17 Feb 2015 00:05:04 +0100
 Mikko Rapeli mikko.rap...@iki.fi wrote:
 
  Usefull when debugging the make scripts.
  
  Signed-off-by: Mikko Rapeli mikko.rap...@iki.fi
  ---
   Makefile | 8 
   1 file changed, 4 insertions(+), 4 deletions(-)
  
  diff --git a/Makefile b/Makefile
  index 4e93284..c1b515d 100644
  --- a/Makefile
  +++ b/Makefile
  @@ -912,13 +912,13 @@ quiet_cmd_link-vmlinux = LINK$@
   # execute if the rest of the kernel build went well.
   vmlinux: scripts/link-vmlinux.sh $(vmlinux-deps) FORCE
   ifdef CONFIG_HEADERS_CHECK
  -   $(Q)$(MAKE) -f $(srctree)/Makefile headers_check
  +   $(Q)$(MAKE) V=$(KBUILD_VERBOSE) -f $(srctree)/Makefile headers_check
   endif
   ifdef CONFIG_SAMPLES
  -   $(Q)$(MAKE) $(build)=samples
  +   $(Q)$(MAKE) V=$(KBUILD_VERBOSE) $(build)=samples
   endif
   ifdef CONFIG_BUILD_DOCSRC
  -   $(Q)$(MAKE) $(build)=Documentation
  +   $(Q)$(MAKE) V=$(KBUILD_VERBOSE) $(build)=Documentation
   endif
  +$(call if_changed,link-vmlinux)
   
  @@ -1069,7 +1069,7 @@ headers_check_all: headers_install_all
   PHONY += headers_check
   headers_check: headers_install
  $(Q)$(MAKE) $(hdr-inst)=include/uapi HDRCHECK=1
  -   $(Q)$(MAKE) $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) 
  HDRCHECK=1
  +   $(Q)$(MAKE) V=$(KBUILD_VERBOSE) 
  $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) HDRCHECK=1
   
   # 
  ---
   # Kernel selftest
 
 
 
 If you give V=... from the command line, it is automatically propagated
 to its sub-makes.
 
 I think this patch has no point.

You are right, I'll drop this patch.

-Mikko
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 01/45] Makefile: propagate verbose options

2015-02-16 Thread Masahiro Yamada
Hi Mikko,

On Tue, 17 Feb 2015 00:05:04 +0100
Mikko Rapeli  wrote:

> Usefull when debugging the make scripts.
> 
> Signed-off-by: Mikko Rapeli 
> ---
>  Makefile | 8 
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 4e93284..c1b515d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -912,13 +912,13 @@ quiet_cmd_link-vmlinux = LINK$@
>  # execute if the rest of the kernel build went well.
>  vmlinux: scripts/link-vmlinux.sh $(vmlinux-deps) FORCE
>  ifdef CONFIG_HEADERS_CHECK
> - $(Q)$(MAKE) -f $(srctree)/Makefile headers_check
> + $(Q)$(MAKE) V=$(KBUILD_VERBOSE) -f $(srctree)/Makefile headers_check
>  endif
>  ifdef CONFIG_SAMPLES
> - $(Q)$(MAKE) $(build)=samples
> + $(Q)$(MAKE) V=$(KBUILD_VERBOSE) $(build)=samples
>  endif
>  ifdef CONFIG_BUILD_DOCSRC
> - $(Q)$(MAKE) $(build)=Documentation
> + $(Q)$(MAKE) V=$(KBUILD_VERBOSE) $(build)=Documentation
>  endif
>   +$(call if_changed,link-vmlinux)
>  
> @@ -1069,7 +1069,7 @@ headers_check_all: headers_install_all
>  PHONY += headers_check
>  headers_check: headers_install
>   $(Q)$(MAKE) $(hdr-inst)=include/uapi HDRCHECK=1
> - $(Q)$(MAKE) $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) 
> HDRCHECK=1
> + $(Q)$(MAKE) V=$(KBUILD_VERBOSE) 
> $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) HDRCHECK=1
>  
>  # ---
>  # Kernel selftest



If you give V=... from the command line, it is automatically propagated
to its sub-makes.

I think this patch has no point.


Best Regards
Masahiro Yamada

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 01/45] Makefile: propagate verbose options

2015-02-16 Thread Mikko Rapeli
Usefull when debugging the make scripts.

Signed-off-by: Mikko Rapeli 
---
 Makefile | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Makefile b/Makefile
index 4e93284..c1b515d 100644
--- a/Makefile
+++ b/Makefile
@@ -912,13 +912,13 @@ quiet_cmd_link-vmlinux = LINK$@
 # execute if the rest of the kernel build went well.
 vmlinux: scripts/link-vmlinux.sh $(vmlinux-deps) FORCE
 ifdef CONFIG_HEADERS_CHECK
-   $(Q)$(MAKE) -f $(srctree)/Makefile headers_check
+   $(Q)$(MAKE) V=$(KBUILD_VERBOSE) -f $(srctree)/Makefile headers_check
 endif
 ifdef CONFIG_SAMPLES
-   $(Q)$(MAKE) $(build)=samples
+   $(Q)$(MAKE) V=$(KBUILD_VERBOSE) $(build)=samples
 endif
 ifdef CONFIG_BUILD_DOCSRC
-   $(Q)$(MAKE) $(build)=Documentation
+   $(Q)$(MAKE) V=$(KBUILD_VERBOSE) $(build)=Documentation
 endif
+$(call if_changed,link-vmlinux)
 
@@ -1069,7 +1069,7 @@ headers_check_all: headers_install_all
 PHONY += headers_check
 headers_check: headers_install
$(Q)$(MAKE) $(hdr-inst)=include/uapi HDRCHECK=1
-   $(Q)$(MAKE) $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) 
HDRCHECK=1
+   $(Q)$(MAKE) V=$(KBUILD_VERBOSE) 
$(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) HDRCHECK=1
 
 # ---
 # Kernel selftest
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


[PATCH 01/45] Makefile: propagate verbose options

2015-02-16 Thread Mikko Rapeli
Usefull when debugging the make scripts.

Signed-off-by: Mikko Rapeli mikko.rap...@iki.fi
---
 Makefile | 8 
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/Makefile b/Makefile
index 4e93284..c1b515d 100644
--- a/Makefile
+++ b/Makefile
@@ -912,13 +912,13 @@ quiet_cmd_link-vmlinux = LINK$@
 # execute if the rest of the kernel build went well.
 vmlinux: scripts/link-vmlinux.sh $(vmlinux-deps) FORCE
 ifdef CONFIG_HEADERS_CHECK
-   $(Q)$(MAKE) -f $(srctree)/Makefile headers_check
+   $(Q)$(MAKE) V=$(KBUILD_VERBOSE) -f $(srctree)/Makefile headers_check
 endif
 ifdef CONFIG_SAMPLES
-   $(Q)$(MAKE) $(build)=samples
+   $(Q)$(MAKE) V=$(KBUILD_VERBOSE) $(build)=samples
 endif
 ifdef CONFIG_BUILD_DOCSRC
-   $(Q)$(MAKE) $(build)=Documentation
+   $(Q)$(MAKE) V=$(KBUILD_VERBOSE) $(build)=Documentation
 endif
+$(call if_changed,link-vmlinux)
 
@@ -1069,7 +1069,7 @@ headers_check_all: headers_install_all
 PHONY += headers_check
 headers_check: headers_install
$(Q)$(MAKE) $(hdr-inst)=include/uapi HDRCHECK=1
-   $(Q)$(MAKE) $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) 
HDRCHECK=1
+   $(Q)$(MAKE) V=$(KBUILD_VERBOSE) 
$(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) HDRCHECK=1
 
 # ---
 # Kernel selftest
-- 
2.1.4

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/


Re: [PATCH 01/45] Makefile: propagate verbose options

2015-02-16 Thread Masahiro Yamada
Hi Mikko,

On Tue, 17 Feb 2015 00:05:04 +0100
Mikko Rapeli mikko.rap...@iki.fi wrote:

 Usefull when debugging the make scripts.
 
 Signed-off-by: Mikko Rapeli mikko.rap...@iki.fi
 ---
  Makefile | 8 
  1 file changed, 4 insertions(+), 4 deletions(-)
 
 diff --git a/Makefile b/Makefile
 index 4e93284..c1b515d 100644
 --- a/Makefile
 +++ b/Makefile
 @@ -912,13 +912,13 @@ quiet_cmd_link-vmlinux = LINK$@
  # execute if the rest of the kernel build went well.
  vmlinux: scripts/link-vmlinux.sh $(vmlinux-deps) FORCE
  ifdef CONFIG_HEADERS_CHECK
 - $(Q)$(MAKE) -f $(srctree)/Makefile headers_check
 + $(Q)$(MAKE) V=$(KBUILD_VERBOSE) -f $(srctree)/Makefile headers_check
  endif
  ifdef CONFIG_SAMPLES
 - $(Q)$(MAKE) $(build)=samples
 + $(Q)$(MAKE) V=$(KBUILD_VERBOSE) $(build)=samples
  endif
  ifdef CONFIG_BUILD_DOCSRC
 - $(Q)$(MAKE) $(build)=Documentation
 + $(Q)$(MAKE) V=$(KBUILD_VERBOSE) $(build)=Documentation
  endif
   +$(call if_changed,link-vmlinux)
  
 @@ -1069,7 +1069,7 @@ headers_check_all: headers_install_all
  PHONY += headers_check
  headers_check: headers_install
   $(Q)$(MAKE) $(hdr-inst)=include/uapi HDRCHECK=1
 - $(Q)$(MAKE) $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) 
 HDRCHECK=1
 + $(Q)$(MAKE) V=$(KBUILD_VERBOSE) 
 $(hdr-inst)=arch/$(hdr-arch)/include/uapi/asm $(hdr-dst) HDRCHECK=1
  
  # ---
  # Kernel selftest



If you give V=... from the command line, it is automatically propagated
to its sub-makes.

I think this patch has no point.


Best Regards
Masahiro Yamada

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/