Re: [PATCH 02/10] blk-mq: make mq_ops a const pointer

2017-01-13 Thread Christoph Hellwig 
Looks fine, even totally independent of any sched work, like most
of the cleanups following this one

Reviewed-by: Christoph Hellwig

Re: [PATCH 02/10] blk-mq: make mq_ops a const pointer

2017-01-13 Thread Christoph Hellwig 
Looks fine, even totally independent of any sched work, like most
of the cleanups following this one

Reviewed-by: Christoph Hellwig

Re: [PATCH 02/10] blk-mq: make mq_ops a const pointer

2017-01-12 Thread Johannes Thumshirn 
On Wed, Jan 11, 2017 at 02:39:55PM -0700, Jens Axboe wrote:
> We never change it, make that clear.
> 
> Signed-off-by: Jens Axboe 
> Reviewed-by: Bart Van Assche 
> ---

Looks good,
Reviewed-by: Johannes Thumshirn 

-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Re: [PATCH 02/10] blk-mq: make mq_ops a const pointer

2017-01-12 Thread Johannes Thumshirn 
On Wed, Jan 11, 2017 at 02:39:55PM -0700, Jens Axboe wrote:
> We never change it, make that clear.
> 
> Signed-off-by: Jens Axboe 
> Reviewed-by: Bart Van Assche 
> ---

Looks good,
Reviewed-by: Johannes Thumshirn 

-- 
Johannes Thumshirn  Storage
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

[PATCH 02/10] blk-mq: make mq_ops a const pointer

2017-01-11 Thread Jens Axboe 
We never change it, make that clear.

Signed-off-by: Jens Axboe 
Reviewed-by: Bart Van Assche 
---
 block/blk-mq.c | 2 +-
 include/linux/blk-mq.h | 2 +-
 include/linux/blkdev.h | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/block/blk-mq.c b/block/blk-mq.c
index a8e67a155d04..79e1cb0f7b15 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -639,7 +639,7 @@ struct blk_mq_timeout_data {
 
 void blk_mq_rq_timed_out(struct request *req, bool reserved)
 {
-   struct blk_mq_ops *ops = req->q->mq_ops;
+   const struct blk_mq_ops *ops = req->q->mq_ops;
enum blk_eh_timer_return ret = BLK_EH_RESET_TIMER;
 
/*
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index 4a2ab5d99ff7..afc81d77e471 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -60,7 +60,7 @@ struct blk_mq_hw_ctx {
 
 struct blk_mq_tag_set {
unsigned int*mq_map;
-   struct blk_mq_ops   *ops;
+   const struct blk_mq_ops *ops;
unsigned intnr_hw_queues;
unsigned intqueue_depth;/* max hw supported */
unsigned intreserved_tags;
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 83695641bd5e..e19fc8e01fb2 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -407,7 +407,7 @@ struct request_queue {
dma_drain_needed_fn *dma_drain_needed;
lld_busy_fn *lld_busy_fn;
 
-   struct blk_mq_ops   *mq_ops;
+   const struct blk_mq_ops *mq_ops;
 
unsigned int*mq_map;
 
-- 
2.7.4

[PATCH 02/10] blk-mq: make mq_ops a const pointer

2017-01-11 Thread Jens Axboe 
We never change it, make that clear.

Signed-off-by: Jens Axboe 
Reviewed-by: Bart Van Assche 
---
 block/blk-mq.c | 2 +-
 include/linux/blk-mq.h | 2 +-
 include/linux/blkdev.h | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/block/blk-mq.c b/block/blk-mq.c
index a8e67a155d04..79e1cb0f7b15 100644
--- a/block/blk-mq.c
+++ b/block/blk-mq.c
@@ -639,7 +639,7 @@ struct blk_mq_timeout_data {
 
 void blk_mq_rq_timed_out(struct request *req, bool reserved)
 {
-   struct blk_mq_ops *ops = req->q->mq_ops;
+   const struct blk_mq_ops *ops = req->q->mq_ops;
enum blk_eh_timer_return ret = BLK_EH_RESET_TIMER;
 
/*
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index 4a2ab5d99ff7..afc81d77e471 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -60,7 +60,7 @@ struct blk_mq_hw_ctx {
 
 struct blk_mq_tag_set {
unsigned int*mq_map;
-   struct blk_mq_ops   *ops;
+   const struct blk_mq_ops *ops;
unsigned intnr_hw_queues;
unsigned intqueue_depth;/* max hw supported */
unsigned intreserved_tags;
diff --git a/include/linux/blkdev.h b/include/linux/blkdev.h
index 83695641bd5e..e19fc8e01fb2 100644
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -407,7 +407,7 @@ struct request_queue {
dma_drain_needed_fn *dma_drain_needed;
lld_busy_fn *lld_busy_fn;
 
-   struct blk_mq_ops   *mq_ops;
+   const struct blk_mq_ops *mq_ops;
 
unsigned int*mq_map;
 
-- 
2.7.4