[PATCH 02/10] mfd: wm5102: Mark only extant DSP registers volatile

2013-01-26 Thread Mark Brown 
Since regmap sometimes uses volatile as a proxy for readable simply
having a blanket condition can mark too many registers as readable.

Signed-off-by: Mark Brown 
---
 drivers/mfd/wm5102-tables.c |   11 +++
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/mfd/wm5102-tables.c b/drivers/mfd/wm5102-tables.c
index 4a01192..0317d11 100644
--- a/drivers/mfd/wm5102-tables.c
+++ b/drivers/mfd/wm5102-tables.c
@@ -1837,9 +1837,6 @@ static bool wm5102_readable_register(struct device *dev, 
unsigned int reg)
 
 static bool wm5102_volatile_register(struct device *dev, unsigned int reg)
 {
-   if (reg > 0x)
-   return true;
-
switch (reg) {
case ARIZONA_SOFTWARE_RESET:
case ARIZONA_DEVICE_REVISION:
@@ -1884,7 +1881,13 @@ static bool wm5102_volatile_register(struct device *dev, 
unsigned int reg)
case ARIZONA_MIC_DETECT_3:
return true;
default:
-   return false;
+   if ((reg >= 0x10 && reg < 0x106000) ||
+   (reg >= 0x18 && reg < 0x180800) ||
+   (reg >= 0x19 && reg < 0x194800) ||
+   (reg >= 0x1a8000 && reg < 0x1a9800))
+   return true;
+   else
+   return false;
}
 }
 
-- 
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 02/10] mfd: wm5102: Mark only extant DSP registers volatile

2013-01-26 Thread Mark Brown 
Since regmap sometimes uses volatile as a proxy for readable simply
having a blanket condition can mark too many registers as readable.

Signed-off-by: Mark Brown broo...@opensource.wolfsonmicro.com
---
 drivers/mfd/wm5102-tables.c |   11 +++
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/drivers/mfd/wm5102-tables.c b/drivers/mfd/wm5102-tables.c
index 4a01192..0317d11 100644
--- a/drivers/mfd/wm5102-tables.c
+++ b/drivers/mfd/wm5102-tables.c
@@ -1837,9 +1837,6 @@ static bool wm5102_readable_register(struct device *dev, 
unsigned int reg)
 
 static bool wm5102_volatile_register(struct device *dev, unsigned int reg)
 {
-   if (reg  0x)
-   return true;
-
switch (reg) {
case ARIZONA_SOFTWARE_RESET:
case ARIZONA_DEVICE_REVISION:
@@ -1884,7 +1881,13 @@ static bool wm5102_volatile_register(struct device *dev, 
unsigned int reg)
case ARIZONA_MIC_DETECT_3:
return true;
default:
-   return false;
+   if ((reg = 0x10  reg  0x106000) ||
+   (reg = 0x18  reg  0x180800) ||
+   (reg = 0x19  reg  0x194800) ||
+   (reg = 0x1a8000  reg  0x1a9800))
+   return true;
+   else
+   return false;
}
 }
 
-- 
1.7.10.4

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/