Re: [PATCH 02/18] drm/sun4i: Add if statement instead of depends on

2017-07-17 Thread Maxime Ripard 
On Fri, Jul 14, 2017 at 11:09:07AM +0800, Chen-Yu Tsai wrote:
> On Thu, Jul 13, 2017 at 10:12 PM, Maxime Ripard
>  wrote:
> > The depends on relationship is obvious, and using an if statement will
> > propagate it to every option without the need for each and every one of
> > them to define it.
> >
> > Signed-off-by: Maxime Ripard 
> 
> Reviewed-by: Chen-Yu Tsai 

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


signature.asc
Description: PGP signature

Re: [PATCH 02/18] drm/sun4i: Add if statement instead of depends on

2017-07-17 Thread Maxime Ripard 
On Fri, Jul 14, 2017 at 11:09:07AM +0800, Chen-Yu Tsai wrote:
> On Thu, Jul 13, 2017 at 10:12 PM, Maxime Ripard
>  wrote:
> > The depends on relationship is obvious, and using an if statement will
> > propagate it to every option without the need for each and every one of
> > them to define it.
> >
> > Signed-off-by: Maxime Ripard 
> 
> Reviewed-by: Chen-Yu Tsai 

Applied, thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com


signature.asc
Description: PGP signature

Re: [PATCH 02/18] drm/sun4i: Add if statement instead of depends on

2017-07-13 Thread Chen-Yu Tsai 
On Thu, Jul 13, 2017 at 10:12 PM, Maxime Ripard
 wrote:
> The depends on relationship is obvious, and using an if statement will
> propagate it to every option without the need for each and every one of
> them to define it.
>
> Signed-off-by: Maxime Ripard 

Reviewed-by: Chen-Yu Tsai

Re: [PATCH 02/18] drm/sun4i: Add if statement instead of depends on

2017-07-13 Thread Chen-Yu Tsai 
On Thu, Jul 13, 2017 at 10:12 PM, Maxime Ripard
 wrote:
> The depends on relationship is obvious, and using an if statement will
> propagate it to every option without the need for each and every one of
> them to define it.
>
> Signed-off-by: Maxime Ripard 

Reviewed-by: Chen-Yu Tsai

[PATCH 02/18] drm/sun4i: Add if statement instead of depends on

2017-07-13 Thread Maxime Ripard 
The depends on relationship is obvious, and using an if statement will
propagate it to every option without the need for each and every one of
them to define it.

Signed-off-by: Maxime Ripard 
---
 drivers/gpu/drm/sun4i/Kconfig | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/sun4i/Kconfig b/drivers/gpu/drm/sun4i/Kconfig
index 5bcad8f5fb4f..5cc116692913 100644
--- a/drivers/gpu/drm/sun4i/Kconfig
+++ b/drivers/gpu/drm/sun4i/Kconfig
@@ -13,9 +13,10 @@ config DRM_SUN4I
  Display Engine. If M is selected the module will be called
  sun4i-drm.
 
+if DRM_SUN4I
+
 config DRM_SUN4I_HDMI
tristate "Allwinner A10 HDMI Controller Support"
-   depends on DRM_SUN4I
default DRM_SUN4I
help
  Choose this option if you have an Allwinner SoC with an HDMI
@@ -23,7 +24,6 @@ config DRM_SUN4I_HDMI
 
 config DRM_SUN4I_BACKEND
tristate "Support for Allwinner A10 Display Engine Backend"
-   depends on DRM_SUN4I
default DRM_SUN4I
help
  Choose this option if you have an Allwinner SoC with the
@@ -33,10 +33,11 @@ config DRM_SUN4I_BACKEND
 
 config DRM_SUN8I_MIXER
tristate "Support for Allwinner Display Engine 2.0 Mixer"
-   depends on DRM_SUN4I
default MACH_SUN8I
help
  Choose this option if you have an Allwinner SoC with the
  Allwinner Display Engine 2.0, which has a mixer to do some
  graphics mixture and feed graphics to TCON, If M is
  selected the module will be called sun8i-mixer.
+
+endif
-- 
git-series 0.9.1

[PATCH 02/18] drm/sun4i: Add if statement instead of depends on

2017-07-13 Thread Maxime Ripard 
The depends on relationship is obvious, and using an if statement will
propagate it to every option without the need for each and every one of
them to define it.

Signed-off-by: Maxime Ripard 
---
 drivers/gpu/drm/sun4i/Kconfig | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/sun4i/Kconfig b/drivers/gpu/drm/sun4i/Kconfig
index 5bcad8f5fb4f..5cc116692913 100644
--- a/drivers/gpu/drm/sun4i/Kconfig
+++ b/drivers/gpu/drm/sun4i/Kconfig
@@ -13,9 +13,10 @@ config DRM_SUN4I
  Display Engine. If M is selected the module will be called
  sun4i-drm.
 
+if DRM_SUN4I
+
 config DRM_SUN4I_HDMI
tristate "Allwinner A10 HDMI Controller Support"
-   depends on DRM_SUN4I
default DRM_SUN4I
help
  Choose this option if you have an Allwinner SoC with an HDMI
@@ -23,7 +24,6 @@ config DRM_SUN4I_HDMI
 
 config DRM_SUN4I_BACKEND
tristate "Support for Allwinner A10 Display Engine Backend"
-   depends on DRM_SUN4I
default DRM_SUN4I
help
  Choose this option if you have an Allwinner SoC with the
@@ -33,10 +33,11 @@ config DRM_SUN4I_BACKEND
 
 config DRM_SUN8I_MIXER
tristate "Support for Allwinner Display Engine 2.0 Mixer"
-   depends on DRM_SUN4I
default MACH_SUN8I
help
  Choose this option if you have an Allwinner SoC with the
  Allwinner Display Engine 2.0, which has a mixer to do some
  graphics mixture and feed graphics to TCON, If M is
  selected the module will be called sun8i-mixer.
+
+endif
-- 
git-series 0.9.1