Re: [PATCH 02/19] amiflop: use bdev_check_media_change

2020-09-09 Thread Hannes Reinecke 
On 9/8/20 4:53 PM, Christoph Hellwig wrote:
> The Amiga floppy driver does not have a ->revalidate_disk method, so it
> can just use bdev_check_media_change without any additional changes.
> 
> Signed-off-by: Christoph Hellwig 
> Reviewed-by: Johannes Thumshirn 
> ---
>  drivers/block/amiflop.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/block/amiflop.c b/drivers/block/amiflop.c
> index 226219da3da6a7..71c2b156455860 100644
> --- a/drivers/block/amiflop.c
> +++ b/drivers/block/amiflop.c
> @@ -1670,7 +1670,7 @@ static int floppy_open(struct block_device *bdev, 
> fmode_t mode)
>   }
>  
>   if (mode & (FMODE_READ|FMODE_WRITE)) {
> - check_disk_change(bdev);
> + bdev_check_media_change(bdev);
>   if (mode & FMODE_WRITE) {
>   int wrprot;
>  
> 
Reviewed-by: Hannes Reinecke 

Cheers,

Hannes
-- 
Dr. Hannes ReineckeKernel Storage Architect
h...@suse.de  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), GF: Felix Imendörffer

[PATCH 02/19] amiflop: use bdev_check_media_change

2020-09-08 Thread Christoph Hellwig 
The Amiga floppy driver does not have a ->revalidate_disk method, so it
can just use bdev_check_media_change without any additional changes.

Signed-off-by: Christoph Hellwig 
Reviewed-by: Johannes Thumshirn 
---
 drivers/block/amiflop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/amiflop.c b/drivers/block/amiflop.c
index 226219da3da6a7..71c2b156455860 100644
--- a/drivers/block/amiflop.c
+++ b/drivers/block/amiflop.c
@@ -1670,7 +1670,7 @@ static int floppy_open(struct block_device *bdev, fmode_t 
mode)
}
 
if (mode & (FMODE_READ|FMODE_WRITE)) {
-   check_disk_change(bdev);
+   bdev_check_media_change(bdev);
if (mode & FMODE_WRITE) {
int wrprot;
 
-- 
2.28.0

Re: [PATCH 02/19] amiflop: use bdev_check_media_change

2020-09-02 Thread Johannes Thumshirn 
Looks good,
Reviewed-by: Johannes Thumshirn

[PATCH 02/19] amiflop: use bdev_check_media_change

2020-09-02 Thread Christoph Hellwig 
The Amiga floppy driver does not have a ->revalidate_disk method, so it
can just use bdev_check_media_change without any additional changes.

Signed-off-by: Christoph Hellwig 
---
 drivers/block/amiflop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/block/amiflop.c b/drivers/block/amiflop.c
index 226219da3da6a7..71c2b156455860 100644
--- a/drivers/block/amiflop.c
+++ b/drivers/block/amiflop.c
@@ -1670,7 +1670,7 @@ static int floppy_open(struct block_device *bdev, fmode_t 
mode)
}
 
if (mode & (FMODE_READ|FMODE_WRITE)) {
-   check_disk_change(bdev);
+   bdev_check_media_change(bdev);
if (mode & FMODE_WRITE) {
int wrprot;
 
-- 
2.28.0