Re: [PATCH 02/20] input: mouse: cyapa: Fix misnaming of 'cyapa_i2c_write's 'reg' param
On Wed, Nov 04, 2020 at 04:24:09PM +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/input/mouse/cyapa.c:130: warning: Function parameter or member 'reg' > not described in 'cyapa_i2c_write' > drivers/input/mouse/cyapa.c:130: warning: Excess function parameter 'ret' > description in 'cyapa_i2c_write' > > Cc: Dmitry Torokhov > Cc: Henrik Rydberg > Cc: Dudley Du > Cc: Daniel Kurtz > Cc: Benson Leung > Cc: linux-in...@vger.kernel.org > Signed-off-by: Lee Jones Applied, thank you. -- Dmitry
Re: [PATCH 02/20] input: mouse: cyapa: Fix misnaming of 'cyapa_i2c_write's 'reg' param
Hi Lee, On Wed, Nov 04, 2020 at 04:24:09PM +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/input/mouse/cyapa.c:130: warning: Function parameter or member 'reg' > not described in 'cyapa_i2c_write' > drivers/input/mouse/cyapa.c:130: warning: Excess function parameter 'ret' > description in 'cyapa_i2c_write' > > Cc: Dmitry Torokhov > Cc: Henrik Rydberg > Cc: Dudley Du > Cc: Daniel Kurtz > Cc: Benson Leung > Cc: linux-in...@vger.kernel.org > Signed-off-by: Lee Jones Reviewed-by: Benson Leung > --- > drivers/input/mouse/cyapa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c > index c675f156948b5..dacf7c0e43f98 100644 > --- a/drivers/input/mouse/cyapa.c > +++ b/drivers/input/mouse/cyapa.c > @@ -119,7 +119,7 @@ static ssize_t cyapa_i2c_read(struct cyapa *cyapa, u8 > reg, size_t len, > /** > * cyapa_i2c_write - Execute i2c block data write operation > * @cyapa: Handle to this driver > - * @ret: Offset of the data to written in the register map > + * @reg: Offset of the data to written in the register map > * @len: number of bytes to write > * @values: Data to be written > * > -- > 2.25.1 > -- Benson Leung Staff Software Engineer Chrome OS Kernel Google Inc. ble...@google.com Chromium OS Project ble...@chromium.org signature.asc Description: PGP signature
[PATCH 02/20] input: mouse: cyapa: Fix misnaming of 'cyapa_i2c_write's 'reg' param
Fixes the following W=1 kernel build warning(s): drivers/input/mouse/cyapa.c:130: warning: Function parameter or member 'reg' not described in 'cyapa_i2c_write' drivers/input/mouse/cyapa.c:130: warning: Excess function parameter 'ret' description in 'cyapa_i2c_write' Cc: Dmitry Torokhov Cc: Henrik Rydberg Cc: Dudley Du Cc: Daniel Kurtz Cc: Benson Leung Cc: linux-in...@vger.kernel.org Signed-off-by: Lee Jones --- drivers/input/mouse/cyapa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/mouse/cyapa.c b/drivers/input/mouse/cyapa.c index c675f156948b5..dacf7c0e43f98 100644 --- a/drivers/input/mouse/cyapa.c +++ b/drivers/input/mouse/cyapa.c @@ -119,7 +119,7 @@ static ssize_t cyapa_i2c_read(struct cyapa *cyapa, u8 reg, size_t len, /** * cyapa_i2c_write - Execute i2c block data write operation * @cyapa: Handle to this driver - * @ret: Offset of the data to written in the register map + * @reg: Offset of the data to written in the register map * @len: number of bytes to write * @values: Data to be written * -- 2.25.1
