Re: [PATCH 02/25] clk: Add CLK_HW_INIT_* macros using .parent_hws

[Stephen Boyd]

Quoting Chen-Yu Tsai (2019-05-20 01:03:58)
> A special CLK_HW_INIT_HWS macro is included, which takes an array of
> struct clk_hw *, but sets .num_parents to 1. This variant is to allow
> the reuse of the array, instead of having a compound literal allocated
> for each clk sharing the same parent.
> 
> Signed-off-by: Chen-Yu Tsai 
[...]
> diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
> index bb6118f79784..0c241b43a802 100644
> --- a/include/linux/clk-provider.h
> +++ b/include/linux/clk-provider.h
> @@ -904,6 +904,24 @@ extern struct of_device_id __clk_of_table;
> .ops= _ops, \
> })
>  
> +#define CLK_HW_INIT_HW(_name, _parent, _ops, _flags)   \
> +   (&(struct clk_init_data) {  \
> +   .flags  = _flags,   \
> +   .name   = _name,\
> +   .parent_hws = (const struct clk_hw*[]) { _parent }, \
> +   .num_parents= 1,\
> +   .ops= _ops, \
> +   })
> +
> +#define CLK_HW_INIT_HWS(_name, _parent, _ops, _flags)  \

Minor nitpick, please add a comment here to indicate that this is here
to share the same compound literal between multiple clks using the same
parent.

> +   (&(struct clk_init_data) {  \
> +   .flags  = _flags,   \
> +   .name   = _name,\
> +   .parent_hws = _parent,  \
> +   .num_parents= 1,\
> +   .ops= _ops, \
> +   })

[PATCH 02/25] clk: Add CLK_HW_INIT_* macros using .parent_hws

[Chen-Yu Tsai]

From: Chen-Yu Tsai 

With the new clk parenting code, struct clk_init_data was expanded to
include .parent_hws, for clk drivers to directly list parents by
pointing to their respective struct clk_hw's.

Add macros that can take either one single struct clk_hw *, or an array
of them, for drivers to use.

A special CLK_HW_INIT_HWS macro is included, which takes an array of
struct clk_hw *, but sets .num_parents to 1. This variant is to allow
the reuse of the array, instead of having a compound literal allocated
for each clk sharing the same parent.

Signed-off-by: Chen-Yu Tsai 
---
 include/linux/clk-provider.h | 27 +++
 1 file changed, 27 insertions(+)

diff --git a/include/linux/clk-provider.h b/include/linux/clk-provider.h
index bb6118f79784..0c241b43a802 100644
--- a/include/linux/clk-provider.h
+++ b/include/linux/clk-provider.h
@@ -904,6 +904,24 @@ extern struct of_device_id __clk_of_table;
.ops= _ops, \
})
 
+#define CLK_HW_INIT_HW(_name, _parent, _ops, _flags)   \
+   (&(struct clk_init_data) {  \
+   .flags  = _flags,   \
+   .name   = _name,\
+   .parent_hws = (const struct clk_hw*[]) { _parent }, \
+   .num_parents= 1,\
+   .ops= _ops, \
+   })
+
+#define CLK_HW_INIT_HWS(_name, _parent, _ops, _flags)  \
+   (&(struct clk_init_data) {  \
+   .flags  = _flags,   \
+   .name   = _name,\
+   .parent_hws = _parent,  \
+   .num_parents= 1,\
+   .ops= _ops, \
+   })
+
 #define CLK_HW_INIT_PARENTS(_name, _parents, _ops, _flags) \
(&(struct clk_init_data) {  \
.flags  = _flags,   \
@@ -913,6 +931,15 @@ extern struct of_device_id __clk_of_table;
.ops= _ops, \
})
 
+#define CLK_HW_INIT_PARENTS_HW(_name, _parents, _ops, _flags)  \
+   (&(struct clk_init_data) {  \
+   .flags  = _flags,   \
+   .name   = _name,\
+   .parent_hws = _parents, \
+   .num_parents= ARRAY_SIZE(_parents), \
+   .ops= _ops, \
+   })
+
 #define CLK_HW_INIT_NO_PARENT(_name, _ops, _flags) \
(&(struct clk_init_data) {  \
.flags  = _flags,   \
-- 
2.20.1