Re: [PATCH 04/12] ASoC: dt-bindings: add dt bindings for wcd9335 audio codec

2018-07-24 Thread Srinivas Kandagatla 




On 24/07/18 12:06, Mark Brown wrote:

On Mon, Jul 23, 2018 at 04:54:02PM +0100, Srinivas Kandagatla wrote:

This patch adds bindings for wcd9335 audio codec which can support both SLIMbus
and I2S/I2C interface.


...


+Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC,
+It supports both I2S/I2C and SLIMbus audio interfaces.


This is a standalone audio CODEC but it also has a MFD binding?  I'd
have just expected a single binding for a single device.


Thanks for the suggestion!

You are right, I should probably remove the mfd bindings totally.
and move them to codec bindings. And register codec and other blocks 
like soundwire controller as mfd cells. like wm8994.


--srini

Re: [PATCH 04/12] ASoC: dt-bindings: add dt bindings for wcd9335 audio codec

2018-07-24 Thread Mark Brown 
On Mon, Jul 23, 2018 at 04:54:02PM +0100, Srinivas Kandagatla wrote:
> This patch adds bindings for wcd9335 audio codec which can support both 
> SLIMbus
> and I2S/I2C interface.

...

> +Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC,
> +It supports both I2S/I2C and SLIMbus audio interfaces.

This is a standalone audio CODEC but it also has a MFD binding?  I'd
have just expected a single binding for a single device.


signature.asc
Description: PGP signature

[PATCH 04/12] ASoC: dt-bindings: add dt bindings for wcd9335 audio codec

2018-07-23 Thread Srinivas Kandagatla 
This patch adds bindings for wcd9335 audio codec which can support both SLIMbus
and I2S/I2C interface.

Signed-off-by: Srinivas Kandagatla 
---
 .../devicetree/bindings/sound/qcom,wcd9335.txt  | 21 +
 1 file changed, 21 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd9335.txt

diff --git a/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt 
b/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt
new file mode 100644
index ..55fcf7504fe1
--- /dev/null
+++ b/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt
@@ -0,0 +1,21 @@
+QCOM WCD9335 Audio Codec
+
+Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC,
+It supports both I2S/I2C and SLIMbus audio interfaces.
+
+- compatible:
+   Usage: required
+   Value type: 
+   Definition: "qcom,wcd9335-codec"
+
+- #sound-dai-cells
+   Usage: required
+   Value type: 
+   Definition: Must be 1
+
+= EXAMPLE
+
+codec {
+   compatible = "qcom,wcd9335-codec";
+   #sound-dai-cells = <1>;
+};
-- 
2.16.2