Re: [PATCH 04/25] arm: exynos/s3c: dts: Remove leading 0x and 0s from bindings notation
On Mon, Dec 18, 2017 at 11:17:24AM +0100, Mathieu Malaterre wrote: > On Mon, Dec 18, 2017 at 10:40 AM, Krzysztof Kozlowskiwrote: > > On Fri, Dec 15, 2017 at 1:46 PM, Mathieu Malaterre wrote: > >> Improve the DTS files by removing all the leading "0x" and zeros to fix the > >> following dtc warnings: > >> > >> Warning (unit_address_format): Node /XXX unit name should not have leading > >> "0x" > >> > >> and > >> > >> Warning (unit_address_format): Node /XXX unit name should not have leading > >> 0s > >> > >> Converted using the following command: > >> > >> find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e > >> "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e > >> "s/@0+\(.*\) {/@\1 {/g" {} +^C > >> > >> For simplicity, two sed expressions were used to solve each warnings > >> separately. > >> > >> To make the regex expression more robust a few other issues were resolved, > >> namely setting unit-address to lower case, and adding a whitespace before > >> the > >> the opening curly brace: > >> > >> https://elinux.org/Device_Tree_Linux#Linux_conventions > >> > >> This will solve as a side effect warning: > >> > >> Warning (simple_bus_reg): Node /XXX@ simple-bus unit address format > >> error, expected "" > >> > >> This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading > >> 0x from bindings notation") > >> > >> Reported-by: David Daney > >> Suggested-by: Rob Herring > >> Acked-by: Krzysztof Kozlowski > > > > Ack was for different patchset, touching only three files... > > So sorry, when I read your email: > > https://lkml.org/lkml/2017/12/15/152 > > I assumed you meant for all the Exynos* and S3C* DTS files, but I did > not check carefully which files were touched originally. > > >> Signed-off-by: Mathieu Malaterre > >> --- > >> arch/arm/boot/dts/exynos3250.dtsi | 34 ++-- > >> arch/arm/boot/dts/exynos4.dtsi| 56 +-- > >> arch/arm/boot/dts/exynos4210.dtsi | 8 +-- > >> arch/arm/boot/dts/exynos4412-pinctrl.dtsi | 2 +- > >> arch/arm/boot/dts/exynos4412.dtsi | 22 > >> arch/arm/boot/dts/exynos5.dtsi| 22 > >> arch/arm/boot/dts/exynos5250.dtsi | 64 +++--- > >> arch/arm/boot/dts/exynos5260.dtsi | 26 - > >> arch/arm/boot/dts/exynos5420.dtsi | 78 > >> +-- > >> arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 2 +- > >> arch/arm/boot/dts/exynos5440.dtsi | 14 ++--- > >> arch/arm/boot/dts/s3c2416.dtsi| 8 +-- > >> 12 files changed, 168 insertions(+), 168 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/exynos3250.dtsi > >> b/arch/arm/boot/dts/exynos3250.dtsi > >> index 2bd3872221a1..8d47571b3984 100644 > >> --- a/arch/arm/boot/dts/exynos3250.dtsi > >> +++ b/arch/arm/boot/dts/exynos3250.dtsi > >> @@ -164,31 +164,31 @@ > >> syscon = <_system_controller>; > >> }; > >> > >> - pd_cam: cam-power-domain@10023C00 { > >> + pd_cam: cam-power-domain@10023c00 { > > > > This is not related to this patch and it was not present in the > > version I acked. I also already fixed this here: > > https://patchwork.kernel.org/patch/10113323/ > > > > There is no changelog explaining the difference in patches. Original > > patch was okay, why changing it? > > Accept my sincere apologizes I really messed this series. I discover > my original ARM patch did not apply lower case to all unit-address > equally, so I added at last minute a sed expression to make all > unit-address lower case. > > I guess you can just drop this one for now. Hi Mathieu, Do you plan to resend this in its original form (removing 0)? Best regards, Krzysztof
Re: [PATCH 04/25] arm: exynos/s3c: dts: Remove leading 0x and 0s from bindings notation
On Mon, Dec 18, 2017 at 11:17:24AM +0100, Mathieu Malaterre wrote: > On Mon, Dec 18, 2017 at 10:40 AM, Krzysztof Kozlowski wrote: > > On Fri, Dec 15, 2017 at 1:46 PM, Mathieu Malaterre wrote: > >> Improve the DTS files by removing all the leading "0x" and zeros to fix the > >> following dtc warnings: > >> > >> Warning (unit_address_format): Node /XXX unit name should not have leading > >> "0x" > >> > >> and > >> > >> Warning (unit_address_format): Node /XXX unit name should not have leading > >> 0s > >> > >> Converted using the following command: > >> > >> find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e > >> "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e > >> "s/@0+\(.*\) {/@\1 {/g" {} +^C > >> > >> For simplicity, two sed expressions were used to solve each warnings > >> separately. > >> > >> To make the regex expression more robust a few other issues were resolved, > >> namely setting unit-address to lower case, and adding a whitespace before > >> the > >> the opening curly brace: > >> > >> https://elinux.org/Device_Tree_Linux#Linux_conventions > >> > >> This will solve as a side effect warning: > >> > >> Warning (simple_bus_reg): Node /XXX@ simple-bus unit address format > >> error, expected "" > >> > >> This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading > >> 0x from bindings notation") > >> > >> Reported-by: David Daney > >> Suggested-by: Rob Herring > >> Acked-by: Krzysztof Kozlowski > > > > Ack was for different patchset, touching only three files... > > So sorry, when I read your email: > > https://lkml.org/lkml/2017/12/15/152 > > I assumed you meant for all the Exynos* and S3C* DTS files, but I did > not check carefully which files were touched originally. > > >> Signed-off-by: Mathieu Malaterre > >> --- > >> arch/arm/boot/dts/exynos3250.dtsi | 34 ++-- > >> arch/arm/boot/dts/exynos4.dtsi| 56 +-- > >> arch/arm/boot/dts/exynos4210.dtsi | 8 +-- > >> arch/arm/boot/dts/exynos4412-pinctrl.dtsi | 2 +- > >> arch/arm/boot/dts/exynos4412.dtsi | 22 > >> arch/arm/boot/dts/exynos5.dtsi| 22 > >> arch/arm/boot/dts/exynos5250.dtsi | 64 +++--- > >> arch/arm/boot/dts/exynos5260.dtsi | 26 - > >> arch/arm/boot/dts/exynos5420.dtsi | 78 > >> +-- > >> arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 2 +- > >> arch/arm/boot/dts/exynos5440.dtsi | 14 ++--- > >> arch/arm/boot/dts/s3c2416.dtsi| 8 +-- > >> 12 files changed, 168 insertions(+), 168 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/exynos3250.dtsi > >> b/arch/arm/boot/dts/exynos3250.dtsi > >> index 2bd3872221a1..8d47571b3984 100644 > >> --- a/arch/arm/boot/dts/exynos3250.dtsi > >> +++ b/arch/arm/boot/dts/exynos3250.dtsi > >> @@ -164,31 +164,31 @@ > >> syscon = <_system_controller>; > >> }; > >> > >> - pd_cam: cam-power-domain@10023C00 { > >> + pd_cam: cam-power-domain@10023c00 { > > > > This is not related to this patch and it was not present in the > > version I acked. I also already fixed this here: > > https://patchwork.kernel.org/patch/10113323/ > > > > There is no changelog explaining the difference in patches. Original > > patch was okay, why changing it? > > Accept my sincere apologizes I really messed this series. I discover > my original ARM patch did not apply lower case to all unit-address > equally, so I added at last minute a sed expression to make all > unit-address lower case. > > I guess you can just drop this one for now. Hi Mathieu, Do you plan to resend this in its original form (removing 0)? Best regards, Krzysztof
Re: [PATCH 04/25] arm: exynos/s3c: dts: Remove leading 0x and 0s from bindings notation
On Mon, Dec 18, 2017 at 10:40 AM, Krzysztof Kozlowskiwrote: > On Fri, Dec 15, 2017 at 1:46 PM, Mathieu Malaterre wrote: >> Improve the DTS files by removing all the leading "0x" and zeros to fix the >> following dtc warnings: >> >> Warning (unit_address_format): Node /XXX unit name should not have leading >> "0x" >> >> and >> >> Warning (unit_address_format): Node /XXX unit name should not have leading 0s >> >> Converted using the following command: >> >> find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e >> "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e >> "s/@0+\(.*\) {/@\1 {/g" {} +^C >> >> For simplicity, two sed expressions were used to solve each warnings >> separately. >> >> To make the regex expression more robust a few other issues were resolved, >> namely setting unit-address to lower case, and adding a whitespace before the >> the opening curly brace: >> >> https://elinux.org/Device_Tree_Linux#Linux_conventions >> >> This will solve as a side effect warning: >> >> Warning (simple_bus_reg): Node /XXX@ simple-bus unit address format >> error, expected "" >> >> This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x >> from bindings notation") >> >> Reported-by: David Daney >> Suggested-by: Rob Herring >> Acked-by: Krzysztof Kozlowski > > Ack was for different patchset, touching only three files... So sorry, when I read your email: https://lkml.org/lkml/2017/12/15/152 I assumed you meant for all the Exynos* and S3C* DTS files, but I did not check carefully which files were touched originally. >> Signed-off-by: Mathieu Malaterre >> --- >> arch/arm/boot/dts/exynos3250.dtsi | 34 ++-- >> arch/arm/boot/dts/exynos4.dtsi| 56 +-- >> arch/arm/boot/dts/exynos4210.dtsi | 8 +-- >> arch/arm/boot/dts/exynos4412-pinctrl.dtsi | 2 +- >> arch/arm/boot/dts/exynos4412.dtsi | 22 >> arch/arm/boot/dts/exynos5.dtsi| 22 >> arch/arm/boot/dts/exynos5250.dtsi | 64 +++--- >> arch/arm/boot/dts/exynos5260.dtsi | 26 - >> arch/arm/boot/dts/exynos5420.dtsi | 78 >> +-- >> arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 2 +- >> arch/arm/boot/dts/exynos5440.dtsi | 14 ++--- >> arch/arm/boot/dts/s3c2416.dtsi| 8 +-- >> 12 files changed, 168 insertions(+), 168 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos3250.dtsi >> b/arch/arm/boot/dts/exynos3250.dtsi >> index 2bd3872221a1..8d47571b3984 100644 >> --- a/arch/arm/boot/dts/exynos3250.dtsi >> +++ b/arch/arm/boot/dts/exynos3250.dtsi >> @@ -164,31 +164,31 @@ >> syscon = <_system_controller>; >> }; >> >> - pd_cam: cam-power-domain@10023C00 { >> + pd_cam: cam-power-domain@10023c00 { > > This is not related to this patch and it was not present in the > version I acked. I also already fixed this here: > https://patchwork.kernel.org/patch/10113323/ > > There is no changelog explaining the difference in patches. Original > patch was okay, why changing it? Accept my sincere apologizes I really messed this series. I discover my original ARM patch did not apply lower case to all unit-address equally, so I added at last minute a sed expression to make all unit-address lower case. I guess you can just drop this one for now. -M
Re: [PATCH 04/25] arm: exynos/s3c: dts: Remove leading 0x and 0s from bindings notation
On Mon, Dec 18, 2017 at 10:40 AM, Krzysztof Kozlowski wrote: > On Fri, Dec 15, 2017 at 1:46 PM, Mathieu Malaterre wrote: >> Improve the DTS files by removing all the leading "0x" and zeros to fix the >> following dtc warnings: >> >> Warning (unit_address_format): Node /XXX unit name should not have leading >> "0x" >> >> and >> >> Warning (unit_address_format): Node /XXX unit name should not have leading 0s >> >> Converted using the following command: >> >> find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e >> "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e >> "s/@0+\(.*\) {/@\1 {/g" {} +^C >> >> For simplicity, two sed expressions were used to solve each warnings >> separately. >> >> To make the regex expression more robust a few other issues were resolved, >> namely setting unit-address to lower case, and adding a whitespace before the >> the opening curly brace: >> >> https://elinux.org/Device_Tree_Linux#Linux_conventions >> >> This will solve as a side effect warning: >> >> Warning (simple_bus_reg): Node /XXX@ simple-bus unit address format >> error, expected "" >> >> This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x >> from bindings notation") >> >> Reported-by: David Daney >> Suggested-by: Rob Herring >> Acked-by: Krzysztof Kozlowski > > Ack was for different patchset, touching only three files... So sorry, when I read your email: https://lkml.org/lkml/2017/12/15/152 I assumed you meant for all the Exynos* and S3C* DTS files, but I did not check carefully which files were touched originally. >> Signed-off-by: Mathieu Malaterre >> --- >> arch/arm/boot/dts/exynos3250.dtsi | 34 ++-- >> arch/arm/boot/dts/exynos4.dtsi| 56 +-- >> arch/arm/boot/dts/exynos4210.dtsi | 8 +-- >> arch/arm/boot/dts/exynos4412-pinctrl.dtsi | 2 +- >> arch/arm/boot/dts/exynos4412.dtsi | 22 >> arch/arm/boot/dts/exynos5.dtsi| 22 >> arch/arm/boot/dts/exynos5250.dtsi | 64 +++--- >> arch/arm/boot/dts/exynos5260.dtsi | 26 - >> arch/arm/boot/dts/exynos5420.dtsi | 78 >> +-- >> arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 2 +- >> arch/arm/boot/dts/exynos5440.dtsi | 14 ++--- >> arch/arm/boot/dts/s3c2416.dtsi| 8 +-- >> 12 files changed, 168 insertions(+), 168 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos3250.dtsi >> b/arch/arm/boot/dts/exynos3250.dtsi >> index 2bd3872221a1..8d47571b3984 100644 >> --- a/arch/arm/boot/dts/exynos3250.dtsi >> +++ b/arch/arm/boot/dts/exynos3250.dtsi >> @@ -164,31 +164,31 @@ >> syscon = <_system_controller>; >> }; >> >> - pd_cam: cam-power-domain@10023C00 { >> + pd_cam: cam-power-domain@10023c00 { > > This is not related to this patch and it was not present in the > version I acked. I also already fixed this here: > https://patchwork.kernel.org/patch/10113323/ > > There is no changelog explaining the difference in patches. Original > patch was okay, why changing it? Accept my sincere apologizes I really messed this series. I discover my original ARM patch did not apply lower case to all unit-address equally, so I added at last minute a sed expression to make all unit-address lower case. I guess you can just drop this one for now. -M
Re: [PATCH 04/25] arm: exynos/s3c: dts: Remove leading 0x and 0s from bindings notation
On Fri, Dec 15, 2017 at 1:46 PM, Mathieu Malaterrewrote: > Improve the DTS files by removing all the leading "0x" and zeros to fix the > following dtc warnings: > > Warning (unit_address_format): Node /XXX unit name should not have leading > "0x" > > and > > Warning (unit_address_format): Node /XXX unit name should not have leading 0s > > Converted using the following command: > > find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e > "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e > "s/@0+\(.*\) {/@\1 {/g" {} +^C > > For simplicity, two sed expressions were used to solve each warnings > separately. > > To make the regex expression more robust a few other issues were resolved, > namely setting unit-address to lower case, and adding a whitespace before the > the opening curly brace: > > https://elinux.org/Device_Tree_Linux#Linux_conventions > > This will solve as a side effect warning: > > Warning (simple_bus_reg): Node /XXX@ simple-bus unit address format > error, expected "" > > This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x > from bindings notation") > > Reported-by: David Daney > Suggested-by: Rob Herring > Acked-by: Krzysztof Kozlowski Ack was for different patchset, touching only three files... > Signed-off-by: Mathieu Malaterre > --- > arch/arm/boot/dts/exynos3250.dtsi | 34 ++-- > arch/arm/boot/dts/exynos4.dtsi| 56 +-- > arch/arm/boot/dts/exynos4210.dtsi | 8 +-- > arch/arm/boot/dts/exynos4412-pinctrl.dtsi | 2 +- > arch/arm/boot/dts/exynos4412.dtsi | 22 > arch/arm/boot/dts/exynos5.dtsi| 22 > arch/arm/boot/dts/exynos5250.dtsi | 64 +++--- > arch/arm/boot/dts/exynos5260.dtsi | 26 - > arch/arm/boot/dts/exynos5420.dtsi | 78 > +-- > arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 2 +- > arch/arm/boot/dts/exynos5440.dtsi | 14 ++--- > arch/arm/boot/dts/s3c2416.dtsi| 8 +-- > 12 files changed, 168 insertions(+), 168 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi > b/arch/arm/boot/dts/exynos3250.dtsi > index 2bd3872221a1..8d47571b3984 100644 > --- a/arch/arm/boot/dts/exynos3250.dtsi > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -164,31 +164,31 @@ > syscon = <_system_controller>; > }; > > - pd_cam: cam-power-domain@10023C00 { > + pd_cam: cam-power-domain@10023c00 { This is not related to this patch and it was not present in the version I acked. I also already fixed this here: https://patchwork.kernel.org/patch/10113323/ There is no changelog explaining the difference in patches. Original patch was okay, why changing it? Best regards, Krzysztof
Re: [PATCH 04/25] arm: exynos/s3c: dts: Remove leading 0x and 0s from bindings notation
On Fri, Dec 15, 2017 at 1:46 PM, Mathieu Malaterre wrote: > Improve the DTS files by removing all the leading "0x" and zeros to fix the > following dtc warnings: > > Warning (unit_address_format): Node /XXX unit name should not have leading > "0x" > > and > > Warning (unit_address_format): Node /XXX unit name should not have leading 0s > > Converted using the following command: > > find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e > "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e > "s/@0+\(.*\) {/@\1 {/g" {} +^C > > For simplicity, two sed expressions were used to solve each warnings > separately. > > To make the regex expression more robust a few other issues were resolved, > namely setting unit-address to lower case, and adding a whitespace before the > the opening curly brace: > > https://elinux.org/Device_Tree_Linux#Linux_conventions > > This will solve as a side effect warning: > > Warning (simple_bus_reg): Node /XXX@ simple-bus unit address format > error, expected "" > > This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x > from bindings notation") > > Reported-by: David Daney > Suggested-by: Rob Herring > Acked-by: Krzysztof Kozlowski Ack was for different patchset, touching only three files... > Signed-off-by: Mathieu Malaterre > --- > arch/arm/boot/dts/exynos3250.dtsi | 34 ++-- > arch/arm/boot/dts/exynos4.dtsi| 56 +-- > arch/arm/boot/dts/exynos4210.dtsi | 8 +-- > arch/arm/boot/dts/exynos4412-pinctrl.dtsi | 2 +- > arch/arm/boot/dts/exynos4412.dtsi | 22 > arch/arm/boot/dts/exynos5.dtsi| 22 > arch/arm/boot/dts/exynos5250.dtsi | 64 +++--- > arch/arm/boot/dts/exynos5260.dtsi | 26 - > arch/arm/boot/dts/exynos5420.dtsi | 78 > +-- > arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 2 +- > arch/arm/boot/dts/exynos5440.dtsi | 14 ++--- > arch/arm/boot/dts/s3c2416.dtsi| 8 +-- > 12 files changed, 168 insertions(+), 168 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi > b/arch/arm/boot/dts/exynos3250.dtsi > index 2bd3872221a1..8d47571b3984 100644 > --- a/arch/arm/boot/dts/exynos3250.dtsi > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -164,31 +164,31 @@ > syscon = <_system_controller>; > }; > > - pd_cam: cam-power-domain@10023C00 { > + pd_cam: cam-power-domain@10023c00 { This is not related to this patch and it was not present in the version I acked. I also already fixed this here: https://patchwork.kernel.org/patch/10113323/ There is no changelog explaining the difference in patches. Original patch was okay, why changing it? Best regards, Krzysztof
[PATCH 04/25] arm: exynos/s3c: dts: Remove leading 0x and 0s from bindings notation
Improve the DTS files by removing all the leading "0x" and zeros to fix the following dtc warnings: Warning (unit_address_format): Node /XXX unit name should not have leading "0x" and Warning (unit_address_format): Node /XXX unit name should not have leading 0s Converted using the following command: find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C For simplicity, two sed expressions were used to solve each warnings separately. To make the regex expression more robust a few other issues were resolved, namely setting unit-address to lower case, and adding a whitespace before the the opening curly brace: https://elinux.org/Device_Tree_Linux#Linux_conventions This will solve as a side effect warning: Warning (simple_bus_reg): Node /XXX@ simple-bus unit address format error, expected "" This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation") Reported-by: David DaneySuggested-by: Rob Herring Acked-by: Krzysztof Kozlowski Signed-off-by: Mathieu Malaterre --- arch/arm/boot/dts/exynos3250.dtsi | 34 ++-- arch/arm/boot/dts/exynos4.dtsi| 56 +-- arch/arm/boot/dts/exynos4210.dtsi | 8 +-- arch/arm/boot/dts/exynos4412-pinctrl.dtsi | 2 +- arch/arm/boot/dts/exynos4412.dtsi | 22 arch/arm/boot/dts/exynos5.dtsi| 22 arch/arm/boot/dts/exynos5250.dtsi | 64 +++--- arch/arm/boot/dts/exynos5260.dtsi | 26 - arch/arm/boot/dts/exynos5420.dtsi | 78 +-- arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 2 +- arch/arm/boot/dts/exynos5440.dtsi | 14 ++--- arch/arm/boot/dts/s3c2416.dtsi| 8 +-- 12 files changed, 168 insertions(+), 168 deletions(-) diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index 2bd3872221a1..8d47571b3984 100644 --- a/arch/arm/boot/dts/exynos3250.dtsi +++ b/arch/arm/boot/dts/exynos3250.dtsi @@ -164,31 +164,31 @@ syscon = <_system_controller>; }; - pd_cam: cam-power-domain@10023C00 { + pd_cam: cam-power-domain@10023c00 { compatible = "samsung,exynos4210-pd"; reg = <0x10023C00 0x20>; #power-domain-cells = <0>; }; - pd_mfc: mfc-power-domain@10023C40 { + pd_mfc: mfc-power-domain@10023c40 { compatible = "samsung,exynos4210-pd"; reg = <0x10023C40 0x20>; #power-domain-cells = <0>; }; - pd_g3d: g3d-power-domain@10023C60 { + pd_g3d: g3d-power-domain@10023c60 { compatible = "samsung,exynos4210-pd"; reg = <0x10023C60 0x20>; #power-domain-cells = <0>; }; - pd_lcd0: lcd0-power-domain@10023C80 { + pd_lcd0: lcd0-power-domain@10023c80 { compatible = "samsung,exynos4210-pd"; reg = <0x10023C80 0x20>; #power-domain-cells = <0>; }; - pd_isp: isp-power-domain@10023CA0 { + pd_isp: isp-power-domain@10023ca0 { compatible = "samsung,exynos4210-pd"; reg = <0x10023CA0 0x20>; #power-domain-cells = <0>; @@ -204,7 +204,7 @@ < CLK_FIN_PLL>; }; - cmu_dmc: clock-controller@105C { + cmu_dmc: clock-controller@105c { compatible = "samsung,exynos3250-cmu-dmc"; reg = <0x105C 0x2000>; #clock-cells = <1>; @@ -219,7 +219,7 @@ status = "disabled"; }; - tmu: tmu@100C { + tmu: tmu@100c { compatible = "samsung,exynos3250-tmu"; reg = <0x100C 0x100>; interrupts = ; @@ -287,7 +287,7 @@ status = "disabled"; }; - sysmmu_jpeg: sysmmu@11A6 { + sysmmu_jpeg: sysmmu@11a6 { compatible = "samsung,exynos-sysmmu"; reg = <0x11a6 0x1000>; interrupts = , @@ -313,7 +313,7 @@ status = "disabled"; }; - dsi_0: dsi@11C8 { + dsi_0: dsi@11c8 { compatible =
[PATCH 04/25] arm: exynos/s3c: dts: Remove leading 0x and 0s from bindings notation
Improve the DTS files by removing all the leading "0x" and zeros to fix the following dtc warnings: Warning (unit_address_format): Node /XXX unit name should not have leading "0x" and Warning (unit_address_format): Node /XXX unit name should not have leading 0s Converted using the following command: find . -type f \( -iname *.dts -o -iname *.dtsi \) -exec sed -i -e "s/@\([0-9a-fA-FxX\.;:#]+\)\s*{/@\L\1 {/g" -e "s/@0x\(.*\) {/@\1 {/g" -e "s/@0+\(.*\) {/@\1 {/g" {} +^C For simplicity, two sed expressions were used to solve each warnings separately. To make the regex expression more robust a few other issues were resolved, namely setting unit-address to lower case, and adding a whitespace before the the opening curly brace: https://elinux.org/Device_Tree_Linux#Linux_conventions This will solve as a side effect warning: Warning (simple_bus_reg): Node /XXX@ simple-bus unit address format error, expected "" This is a follow up to commit 4c9847b7375a ("dt-bindings: Remove leading 0x from bindings notation") Reported-by: David Daney Suggested-by: Rob Herring Acked-by: Krzysztof Kozlowski Signed-off-by: Mathieu Malaterre --- arch/arm/boot/dts/exynos3250.dtsi | 34 ++-- arch/arm/boot/dts/exynos4.dtsi| 56 +-- arch/arm/boot/dts/exynos4210.dtsi | 8 +-- arch/arm/boot/dts/exynos4412-pinctrl.dtsi | 2 +- arch/arm/boot/dts/exynos4412.dtsi | 22 arch/arm/boot/dts/exynos5.dtsi| 22 arch/arm/boot/dts/exynos5250.dtsi | 64 +++--- arch/arm/boot/dts/exynos5260.dtsi | 26 - arch/arm/boot/dts/exynos5420.dtsi | 78 +-- arch/arm/boot/dts/exynos5422-odroid-core.dtsi | 2 +- arch/arm/boot/dts/exynos5440.dtsi | 14 ++--- arch/arm/boot/dts/s3c2416.dtsi| 8 +-- 12 files changed, 168 insertions(+), 168 deletions(-) diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi index 2bd3872221a1..8d47571b3984 100644 --- a/arch/arm/boot/dts/exynos3250.dtsi +++ b/arch/arm/boot/dts/exynos3250.dtsi @@ -164,31 +164,31 @@ syscon = <_system_controller>; }; - pd_cam: cam-power-domain@10023C00 { + pd_cam: cam-power-domain@10023c00 { compatible = "samsung,exynos4210-pd"; reg = <0x10023C00 0x20>; #power-domain-cells = <0>; }; - pd_mfc: mfc-power-domain@10023C40 { + pd_mfc: mfc-power-domain@10023c40 { compatible = "samsung,exynos4210-pd"; reg = <0x10023C40 0x20>; #power-domain-cells = <0>; }; - pd_g3d: g3d-power-domain@10023C60 { + pd_g3d: g3d-power-domain@10023c60 { compatible = "samsung,exynos4210-pd"; reg = <0x10023C60 0x20>; #power-domain-cells = <0>; }; - pd_lcd0: lcd0-power-domain@10023C80 { + pd_lcd0: lcd0-power-domain@10023c80 { compatible = "samsung,exynos4210-pd"; reg = <0x10023C80 0x20>; #power-domain-cells = <0>; }; - pd_isp: isp-power-domain@10023CA0 { + pd_isp: isp-power-domain@10023ca0 { compatible = "samsung,exynos4210-pd"; reg = <0x10023CA0 0x20>; #power-domain-cells = <0>; @@ -204,7 +204,7 @@ < CLK_FIN_PLL>; }; - cmu_dmc: clock-controller@105C { + cmu_dmc: clock-controller@105c { compatible = "samsung,exynos3250-cmu-dmc"; reg = <0x105C 0x2000>; #clock-cells = <1>; @@ -219,7 +219,7 @@ status = "disabled"; }; - tmu: tmu@100C { + tmu: tmu@100c { compatible = "samsung,exynos3250-tmu"; reg = <0x100C 0x100>; interrupts = ; @@ -287,7 +287,7 @@ status = "disabled"; }; - sysmmu_jpeg: sysmmu@11A6 { + sysmmu_jpeg: sysmmu@11a6 { compatible = "samsung,exynos-sysmmu"; reg = <0x11a6 0x1000>; interrupts = , @@ -313,7 +313,7 @@ status = "disabled"; }; - dsi_0: dsi@11C8 { + dsi_0: dsi@11c8 { compatible = "samsung,exynos3250-mipi-dsi"; reg = <0x11C8 0x1>;