Re: [PATCH 05/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

[Coiby Xu]

On Thu, Oct 29, 2020 at 01:57:25PM +0200, Andy Shevchenko wrote:

On Thu, Oct 29, 2020 at 11:05 AM Coiby Xu  wrote:


SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.


Correct grammar and rethink about them.

NAK for all of them.



I'll add __maybe_unused, do the compiling testing for each changed
driver and also correct the typo in v2. Thank you for the feedback!


--
With Best Regards,
Andy Shevchenko


--
Best regards,
Coiby

Re: [PATCH 05/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

[Andy Shevchenko]

On Thu, Oct 29, 2020 at 11:05 AM Coiby Xu  wrote:
>
> SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.

Correct grammar and rethink about them.

NAK for all of them.

-- 
With Best Regards,
Andy Shevchenko

[PATCH 05/15] iio: accel: remove unnecessary CONFIG_PM_SLEEP

[Coiby Xu]

SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG.

Signed-off-by: Coiby Xu 
---
 drivers/iio/accel/mma9551.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/iio/accel/mma9551.c b/drivers/iio/accel/mma9551.c
index 08a2303cc9df..c3b7a1633907 100644
--- a/drivers/iio/accel/mma9551.c
+++ b/drivers/iio/accel/mma9551.c
@@ -558,7 +558,6 @@ static int mma9551_runtime_resume(struct device *dev)
 }
 #endif
 
-#ifdef CONFIG_PM_SLEEP
 static int mma9551_suspend(struct device *dev)
 {
struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
@@ -584,7 +583,6 @@ static int mma9551_resume(struct device *dev)
 
return ret;
 }
-#endif
 
 static const struct dev_pm_ops mma9551_pm_ops = {
SET_SYSTEM_SLEEP_PM_OPS(mma9551_suspend, mma9551_resume)
-- 
2.28.0