[PATCH 05/18] perf hists: Convert hist entry functions to use struct he_stat
From: Namhyung Kim hist_entry__add_cpumode_period() and hist_entry__decay() are dealing with hist_entry's stat fields only. So make them use the struct directly. Cc: Arun Sharma Cc: Frederic Weisbecker Signed-off-by: Namhyung Kim --- tools/perf/util/hist.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c index 63234e37583c..1f84314546a2 100644 --- a/tools/perf/util/hist.c +++ b/tools/perf/util/hist.c @@ -182,21 +182,21 @@ void hists__output_recalc_col_len(struct hists *hists, int max_rows) } } -static void hist_entry__add_cpumode_period(struct hist_entry *he, - unsigned int cpumode, u64 period) +static void he_stat__add_cpumode_period(struct he_stat *he_stat, + unsigned int cpumode, u64 period) { switch (cpumode) { case PERF_RECORD_MISC_KERNEL: - he->stat.period_sys += period; + he_stat->period_sys += period; break; case PERF_RECORD_MISC_USER: - he->stat.period_us += period; + he_stat->period_us += period; break; case PERF_RECORD_MISC_GUEST_KERNEL: - he->stat.period_guest_sys += period; + he_stat->period_guest_sys += period; break; case PERF_RECORD_MISC_GUEST_USER: - he->stat.period_guest_us += period; + he_stat->period_guest_us += period; break; default: break; @@ -223,10 +223,10 @@ static void he_stat__add_stat(struct he_stat *dest, struct he_stat *src) dest->weight+= src->weight; } -static void hist_entry__decay(struct hist_entry *he) +static void he_stat__decay(struct he_stat *he_stat) { - he->stat.period = (he->stat.period * 7) / 8; - he->stat.nr_events = (he->stat.nr_events * 7) / 8; + he_stat->period = (he_stat->period * 7) / 8; + he_stat->nr_events = (he_stat->nr_events * 7) / 8; /* XXX need decay for weight too? */ } @@ -237,7 +237,7 @@ static bool hists__decay_entry(struct hists *hists, struct hist_entry *he) if (prev_period == 0) return true; - hist_entry__decay(he); + he_stat__decay(>stat); if (!he->filtered) hists->stats.total_period -= prev_period - he->stat.period; @@ -403,7 +403,7 @@ static struct hist_entry *add_hist_entry(struct hists *hists, rb_link_node(>rb_node_in, parent, p); rb_insert_color(>rb_node_in, hists->entries_in); out: - hist_entry__add_cpumode_period(he, al->cpumode, period); + he_stat__add_cpumode_period(>stat, al->cpumode, period); return he; } -- 1.7.11.7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 05/18] perf hists: Convert hist entry functions to use struct he_stat
From: Namhyung Kim namhyung@lge.com hist_entry__add_cpumode_period() and hist_entry__decay() are dealing with hist_entry's stat fields only. So make them use the struct directly. Cc: Arun Sharma asha...@fb.com Cc: Frederic Weisbecker fweis...@gmail.com Signed-off-by: Namhyung Kim namhy...@kernel.org --- tools/perf/util/hist.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/tools/perf/util/hist.c b/tools/perf/util/hist.c index 63234e37583c..1f84314546a2 100644 --- a/tools/perf/util/hist.c +++ b/tools/perf/util/hist.c @@ -182,21 +182,21 @@ void hists__output_recalc_col_len(struct hists *hists, int max_rows) } } -static void hist_entry__add_cpumode_period(struct hist_entry *he, - unsigned int cpumode, u64 period) +static void he_stat__add_cpumode_period(struct he_stat *he_stat, + unsigned int cpumode, u64 period) { switch (cpumode) { case PERF_RECORD_MISC_KERNEL: - he-stat.period_sys += period; + he_stat-period_sys += period; break; case PERF_RECORD_MISC_USER: - he-stat.period_us += period; + he_stat-period_us += period; break; case PERF_RECORD_MISC_GUEST_KERNEL: - he-stat.period_guest_sys += period; + he_stat-period_guest_sys += period; break; case PERF_RECORD_MISC_GUEST_USER: - he-stat.period_guest_us += period; + he_stat-period_guest_us += period; break; default: break; @@ -223,10 +223,10 @@ static void he_stat__add_stat(struct he_stat *dest, struct he_stat *src) dest-weight+= src-weight; } -static void hist_entry__decay(struct hist_entry *he) +static void he_stat__decay(struct he_stat *he_stat) { - he-stat.period = (he-stat.period * 7) / 8; - he-stat.nr_events = (he-stat.nr_events * 7) / 8; + he_stat-period = (he_stat-period * 7) / 8; + he_stat-nr_events = (he_stat-nr_events * 7) / 8; /* XXX need decay for weight too? */ } @@ -237,7 +237,7 @@ static bool hists__decay_entry(struct hists *hists, struct hist_entry *he) if (prev_period == 0) return true; - hist_entry__decay(he); + he_stat__decay(he-stat); if (!he-filtered) hists-stats.total_period -= prev_period - he-stat.period; @@ -403,7 +403,7 @@ static struct hist_entry *add_hist_entry(struct hists *hists, rb_link_node(he-rb_node_in, parent, p); rb_insert_color(he-rb_node_in, hists-entries_in); out: - hist_entry__add_cpumode_period(he, al-cpumode, period); + he_stat__add_cpumode_period(he-stat, al-cpumode, period); return he; } -- 1.7.11.7 -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/