Re: [PATCH 06/32] IGET: Mark iget() and read_inode() as being obsolete [try #2]
On Fri, Oct 05, 2007 at 04:21:04PM +0100, David Howells wrote: > David Howells <[EMAIL PROTECTED]> wrote: > > > > Why do you move it out of line? > > > > Because otherwise every file that gets compiled that includes linux/fs.h > > will > > emit a warning that the implementation of that function is deprecated. > > Or, rather, that read_inode() is deprecated. So what about not actually marking it deprectated? The last patch in the series rips it out anyway (right so!) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/32] IGET: Mark iget() and read_inode() as being obsolete [try #2]
David Howells <[EMAIL PROTECTED]> wrote: > > Why do you move it out of line? > > Because otherwise every file that gets compiled that includes linux/fs.h will > emit a warning that the implementation of that function is deprecated. Or, rather, that read_inode() is deprecated. David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/32] IGET: Mark iget() and read_inode() as being obsolete [try #2]
Christoph Hellwig <[EMAIL PROTECTED]> wrote: > Why do you move it out of line? Because otherwise every file that gets compiled that includes linux/fs.h will emit a warning that the implementation of that function is deprecated. David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/32] IGET: Mark iget() and read_inode() as being obsolete [try #2]
Why do you move it out of line? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/32] IGET: Mark iget() and read_inode() as being obsolete [try #2]
Why do you move it out of line? - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/32] IGET: Mark iget() and read_inode() as being obsolete [try #2]
David Howells [EMAIL PROTECTED] wrote: Why do you move it out of line? Because otherwise every file that gets compiled that includes linux/fs.h will emit a warning that the implementation of that function is deprecated. Or, rather, that read_inode() is deprecated. David - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/32] IGET: Mark iget() and read_inode() as being obsolete [try #2]
Christoph Hellwig [EMAIL PROTECTED] wrote: Why do you move it out of line? Because otherwise every file that gets compiled that includes linux/fs.h will emit a warning that the implementation of that function is deprecated. David - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH 06/32] IGET: Mark iget() and read_inode() as being obsolete [try #2]
On Fri, Oct 05, 2007 at 04:21:04PM +0100, David Howells wrote: David Howells [EMAIL PROTECTED] wrote: Why do you move it out of line? Because otherwise every file that gets compiled that includes linux/fs.h will emit a warning that the implementation of that function is deprecated. Or, rather, that read_inode() is deprecated. So what about not actually marking it deprectated? The last patch in the series rips it out anyway (right so!) - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[PATCH 06/32] IGET: Mark iget() and read_inode() as being obsolete [try #2]
Mark iget() and read_inode() as being obsolete and remove references to them
from the documentation.
Typically a filesystem will be modified such that the read_inode function
becomes an internal iget function, for example the following:
void thingyfs_read_inode(struct inode *inode)
{
...
}
would be changed into something like:
struct inode *thingyfs_iget(struct super_block *sp, unsigned long ino)
{
struct inode *inode;
int ret;
inode = iget_locked(sb, ino);
if (!inode)
return ERR_PTR(-ENOMEM);
if (!(inode->i_state & I_NEW))
return inode;
...
unlock_new_inode(inode);
return inode;
error:
iget_failed(inode);
return ERR_PTR(ret);
}
and then thingyfs_iget() would be called rather than iget(), for example:
ret = -EINVAL;
inode = iget(sb, ino);
if (!inode || is_bad_inode(inode))
goto error;
becomes:
inode = thingyfs_iget(sb, ino);
if (IS_ERR(inode)) {
ret = PTR_ERR(inode);
goto error;
}
Signed-off-by: David Howells <[EMAIL PROTECTED]>
---
Documentation/filesystems/Exporting |5 -
Documentation/filesystems/Locking |3 ---
Documentation/filesystems/vfs.txt | 16 +---
fs/inode.c | 16
include/linux/fs.h | 16 +++-
5 files changed, 24 insertions(+), 32 deletions(-)
diff --git a/Documentation/filesystems/Exporting
b/Documentation/filesystems/Exporting
index 31047e0..22ce3b2 100644
--- a/Documentation/filesystems/Exporting
+++ b/Documentation/filesystems/Exporting
@@ -144,11 +144,6 @@ filesystem:
decode_fh passes two datums through find_exported_dentry. One that
should be used to identify the target object, and one that can be
used to identify the object's parent, should that be necessary.
-The default get_dentry function assumes that the datum contains an
-inode number and a generation number, and it attempts to get the
-inode using "iget" and check it's validity by matching the
-generation number. A filesystem should only depend on the default
-if iget can safely be used this way.
If decode_fh and/or encode_fh are left as NULL, then default
implementations are used. These defaults are suitable for ext2 and
diff --git a/Documentation/filesystems/Locking
b/Documentation/filesystems/Locking
index f0f8258..d155893 100644
--- a/Documentation/filesystems/Locking
+++ b/Documentation/filesystems/Locking
@@ -90,7 +90,6 @@ of the locking scheme for directory operations.
prototypes:
struct inode *(*alloc_inode)(struct super_block *sb);
void (*destroy_inode)(struct inode *);
- void (*read_inode) (struct inode *);
void (*dirty_inode) (struct inode *);
int (*write_inode) (struct inode *, int);
void (*put_inode) (struct inode *);
@@ -114,7 +113,6 @@ locking rules:
BKL s_lock s_umount
alloc_inode: no no no
destroy_inode: no
-read_inode:no (see below)
dirty_inode: no (must not sleep)
write_inode: no
put_inode: no
@@ -133,7 +131,6 @@ show_options: no
(vfsmount->sem)
quota_read:no no no (see below)
quota_write: no no no (see below)
-->read_inode() is not a method - it's a callback used in iget().
->remount_fs() will have the s_umount lock if it's already mounted.
When called from get_sb_single, it does NOT have the s_umount lock.
->quota_read() and ->quota_write() functions are both guaranteed to
diff --git a/Documentation/filesystems/vfs.txt
b/Documentation/filesystems/vfs.txt
index 045f3e0..63c7e91 100644
--- a/Documentation/filesystems/vfs.txt
+++ b/Documentation/filesystems/vfs.txt
@@ -242,14 +242,8 @@ or bottom half).
->alloc_inode was defined and simply undoes anything done by
->alloc_inode.
- read_inode: this method is called to read a specific inode from the
-mounted filesystem. The i_ino member in the struct inode is
- initialized by the VFS to indicate which inode to read. Other
- members are filled in by this method.
-
- You can set this to NULL and use iget5_locked() instead of iget()
- to read inodes. This is necessary for filesystems for which the
- inode number is not sufficient to identify an inode.
+ read_inode: deprecated, do not use. Use iget_locked() instead of iget() and
+ return a proper error value.
dirty_inode: this method is called by the VFS to mark an inode dirty.
[PATCH 06/32] IGET: Mark iget() and read_inode() as being obsolete [try #2]
Mark iget() and read_inode() as being obsolete and remove references to them
from the documentation.
Typically a filesystem will be modified such that the read_inode function
becomes an internal iget function, for example the following:
void thingyfs_read_inode(struct inode *inode)
{
...
}
would be changed into something like:
struct inode *thingyfs_iget(struct super_block *sp, unsigned long ino)
{
struct inode *inode;
int ret;
inode = iget_locked(sb, ino);
if (!inode)
return ERR_PTR(-ENOMEM);
if (!(inode-i_state I_NEW))
return inode;
...
unlock_new_inode(inode);
return inode;
error:
iget_failed(inode);
return ERR_PTR(ret);
}
and then thingyfs_iget() would be called rather than iget(), for example:
ret = -EINVAL;
inode = iget(sb, ino);
if (!inode || is_bad_inode(inode))
goto error;
becomes:
inode = thingyfs_iget(sb, ino);
if (IS_ERR(inode)) {
ret = PTR_ERR(inode);
goto error;
}
Signed-off-by: David Howells [EMAIL PROTECTED]
---
Documentation/filesystems/Exporting |5 -
Documentation/filesystems/Locking |3 ---
Documentation/filesystems/vfs.txt | 16 +---
fs/inode.c | 16
include/linux/fs.h | 16 +++-
5 files changed, 24 insertions(+), 32 deletions(-)
diff --git a/Documentation/filesystems/Exporting
b/Documentation/filesystems/Exporting
index 31047e0..22ce3b2 100644
--- a/Documentation/filesystems/Exporting
+++ b/Documentation/filesystems/Exporting
@@ -144,11 +144,6 @@ filesystem:
decode_fh passes two datums through find_exported_dentry. One that
should be used to identify the target object, and one that can be
used to identify the object's parent, should that be necessary.
-The default get_dentry function assumes that the datum contains an
-inode number and a generation number, and it attempts to get the
-inode using iget and check it's validity by matching the
-generation number. A filesystem should only depend on the default
-if iget can safely be used this way.
If decode_fh and/or encode_fh are left as NULL, then default
implementations are used. These defaults are suitable for ext2 and
diff --git a/Documentation/filesystems/Locking
b/Documentation/filesystems/Locking
index f0f8258..d155893 100644
--- a/Documentation/filesystems/Locking
+++ b/Documentation/filesystems/Locking
@@ -90,7 +90,6 @@ of the locking scheme for directory operations.
prototypes:
struct inode *(*alloc_inode)(struct super_block *sb);
void (*destroy_inode)(struct inode *);
- void (*read_inode) (struct inode *);
void (*dirty_inode) (struct inode *);
int (*write_inode) (struct inode *, int);
void (*put_inode) (struct inode *);
@@ -114,7 +113,6 @@ locking rules:
BKL s_lock s_umount
alloc_inode: no no no
destroy_inode: no
-read_inode:no (see below)
dirty_inode: no (must not sleep)
write_inode: no
put_inode: no
@@ -133,7 +131,6 @@ show_options: no
(vfsmount-sem)
quota_read:no no no (see below)
quota_write: no no no (see below)
--read_inode() is not a method - it's a callback used in iget().
-remount_fs() will have the s_umount lock if it's already mounted.
When called from get_sb_single, it does NOT have the s_umount lock.
-quota_read() and -quota_write() functions are both guaranteed to
diff --git a/Documentation/filesystems/vfs.txt
b/Documentation/filesystems/vfs.txt
index 045f3e0..63c7e91 100644
--- a/Documentation/filesystems/vfs.txt
+++ b/Documentation/filesystems/vfs.txt
@@ -242,14 +242,8 @@ or bottom half).
-alloc_inode was defined and simply undoes anything done by
-alloc_inode.
- read_inode: this method is called to read a specific inode from the
-mounted filesystem. The i_ino member in the struct inode is
- initialized by the VFS to indicate which inode to read. Other
- members are filled in by this method.
-
- You can set this to NULL and use iget5_locked() instead of iget()
- to read inodes. This is necessary for filesystems for which the
- inode number is not sufficient to identify an inode.
+ read_inode: deprecated, do not use. Use iget_locked() instead of iget() and
+ return a proper error value.
dirty_inode: this method is called by the VFS to mark an inode dirty.
@@ -308,9
