Re: [PATCH 07/22] gpiolib: cdev: remove pointless decrement of i

[Bartosz Golaszewski]

wt., 23 cze 2020 o 06:02 Kent Gibson  napisał(a):
>
> Remove pointless decrement of variable, and associated comment.
>
> While i is used subsequently, it is re-initialized so this decrement
> serves no purpose.
>
> Signed-off-by: Kent Gibson 
>

Reviewed-by: Bartosz Golaszewski 

[PATCH 07/22] gpiolib: cdev: remove pointless decrement of i

[Kent Gibson]

Remove pointless decrement of variable, and associated comment.

While i is used subsequently, it is re-initialized so this decrement
serves no purpose.

Signed-off-by: Kent Gibson 

---
 drivers/gpio/gpiolib-cdev.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpio/gpiolib-cdev.c b/drivers/gpio/gpiolib-cdev.c
index b39e7ef8c0d4..d50339ef6f05 100644
--- a/drivers/gpio/gpiolib-cdev.c
+++ b/drivers/gpio/gpiolib-cdev.c
@@ -331,8 +331,6 @@ static int linehandle_create(struct gpio_device *gdev, void 
__user *ip)
dev_dbg(>dev, "registered chardev handle for line %d\n",
offset);
}
-   /* Let i point at the last handle */
-   i--;
lh->num_descs = handlereq.lines;
 
fd = get_unused_fd_flags(O_RDONLY | O_CLOEXEC);
-- 
2.27.0