Re: [PATCH 08/10] dt-bindings: phy: Add compatible for Mediatek MT8195

2021-03-18 Thread Seiya Wang
On Thu, 2021-03-18 at 10:19 +0800, Chunfeng Yun wrote:
> On Tue, 2021-03-16 at 19:14 +0800, Seiya Wang wrote:
> > This commit adds dt-binding documentation of UFS M-Phy for Mediatek MT8195 
> > SoC
> > Platform.
> > 
> > Signed-off-by: Seiya Wang 
> > ---
> >  Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml 
> > b/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml
> > index 3a9be82e7f13..5235b1a0d188 100644
> > --- a/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml
> > @@ -22,6 +22,7 @@ properties:
> >  pattern: "^ufs-phy@[0-9a-f]+$"
> >  
> >compatible:
> > +enum: mediatek,mt8195-ufsphy
> >  const: mediatek,mt8183-ufsphy
> >  
> There is warning when I make dt_binding_check, if mt8195 is compatible
> with mt8183, will add it as following:
> 
> oneOf:
>   - items:
>   - enum:
>   - mediatek,mt8195-ufsphy
>   - const: mediatek,mt8183-ufsphy
>   - const: mediatek,mt8183-ufsphy
> 
> Due to Vinod already apply this patch, I'll send out a fix patch later
> 
> Thanks

I will update the patch after a new linux-next tag available.
Thank you very much.

> >reg:
> 
> 



Re: [PATCH 08/10] dt-bindings: phy: Add compatible for Mediatek MT8195

2021-03-17 Thread Chunfeng Yun
Hi Vinod,

On Wed, 2021-03-17 at 12:10 +0530, Vinod Koul wrote:
> On 16-03-21, 19:14, Seiya Wang wrote:
> > This commit adds dt-binding documentation of UFS M-Phy for Mediatek MT8195 
> > SoC
> > Platform.
> 
> Applied, thanks

Usually, we expect the dt-binding patch is acked or reviewed by Rob
before it's applied?

Thanks a lot

> 



Re: [PATCH 08/10] dt-bindings: phy: Add compatible for Mediatek MT8195

2021-03-17 Thread Chunfeng Yun
On Tue, 2021-03-16 at 19:14 +0800, Seiya Wang wrote:
> This commit adds dt-binding documentation of UFS M-Phy for Mediatek MT8195 SoC
> Platform.
> 
> Signed-off-by: Seiya Wang 
> ---
>  Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml 
> b/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml
> index 3a9be82e7f13..5235b1a0d188 100644
> --- a/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml
> +++ b/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml
> @@ -22,6 +22,7 @@ properties:
>  pattern: "^ufs-phy@[0-9a-f]+$"
>  
>compatible:
> +enum: mediatek,mt8195-ufsphy
>  const: mediatek,mt8183-ufsphy
>  
There is warning when I make dt_binding_check, if mt8195 is compatible
with mt8183, will add it as following:

oneOf:
  - items:
  - enum:
  - mediatek,mt8195-ufsphy
  - const: mediatek,mt8183-ufsphy
  - const: mediatek,mt8183-ufsphy

Due to Vinod already apply this patch, I'll send out a fix patch later

Thanks

>reg:



Re: [PATCH 08/10] dt-bindings: phy: Add compatible for Mediatek MT8195

2021-03-17 Thread Vinod Koul
On 16-03-21, 19:14, Seiya Wang wrote:
> This commit adds dt-binding documentation of UFS M-Phy for Mediatek MT8195 SoC
> Platform.

Applied, thanks

-- 
~Vinod


[PATCH 08/10] dt-bindings: phy: Add compatible for Mediatek MT8195

2021-03-16 Thread Seiya Wang
This commit adds dt-binding documentation of UFS M-Phy for Mediatek MT8195 SoC
Platform.

Signed-off-by: Seiya Wang 
---
 Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml 
b/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml
index 3a9be82e7f13..5235b1a0d188 100644
--- a/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/mediatek,ufs-phy.yaml
@@ -22,6 +22,7 @@ properties:
 pattern: "^ufs-phy@[0-9a-f]+$"
 
   compatible:
+enum: mediatek,mt8195-ufsphy
 const: mediatek,mt8183-ufsphy
 
   reg:
-- 
2.14.1