Re: [PATCH 09/10] f2fs: use MAX_BIO_BLOCKS(sbi)

2014-09-17 Thread Jaegeuk Kim 
Hi,

Thank you for the review.
I changed the return value of MAX_BIO_BLOCKS to int.
IMO, it's the best way that I can do for now.

Thanks,

>From f3bcd1d658d1c4aa8178ddc2d4e6a7e45d8405cd Mon Sep 17 00:00:00 2001
From: Jaegeuk Kim 
Date: Thu, 11 Sep 2014 14:37:35 -0700
Subject: [PATCH] f2fs: use MAX_BIO_BLOCKS(sbi)

Change log from v1:
 o change the return value of MAX_BIO_BLOCKS to int type.

This patch cleans up a simple macro.

Signed-off-by: Jaegeuk Kim 
---
 fs/f2fs/data.c | 2 +-
 fs/f2fs/node.c | 2 +-
 fs/f2fs/recovery.c | 4 ++--
 fs/f2fs/segment.c  | 2 +-
 fs/f2fs/segment.h  | 8 
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index fdc3dbe..7749f30 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -193,7 +193,7 @@ void f2fs_submit_page_mbio(struct f2fs_sb_info *sbi, struct 
page *page,
__submit_merged_bio(io);
 alloc_new:
if (io->bio == NULL) {
-   int bio_blocks = MAX_BIO_BLOCKS(max_hw_blocks(sbi));
+   int bio_blocks = MAX_BIO_BLOCKS(sbi);
 
io->bio = __bio_alloc(sbi, blk_addr, bio_blocks, is_read);
io->fio = *fio;
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 7a2d9c9..21ed91b 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1697,7 +1697,7 @@ int restore_node_summary(struct f2fs_sb_info *sbi,
struct f2fs_summary *sum_entry;
struct inode *inode = sbi->sb->s_bdev->bd_inode;
block_t addr;
-   int bio_blocks = MAX_BIO_BLOCKS(max_hw_blocks(sbi));
+   int bio_blocks = MAX_BIO_BLOCKS(sbi);
struct page *pages[bio_blocks];
int i, idx, last_offset, nrpages, err = 0;
 
diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
index 78ef10c..1ccee36 100644
--- a/fs/f2fs/recovery.c
+++ b/fs/f2fs/recovery.c
@@ -180,7 +180,7 @@ static int find_fsync_dnodes(struct f2fs_sb_info *sbi, 
struct list_head *head)
page = get_meta_page(sbi, blkaddr);
 
ra_meta_pages(sbi, next_blkaddr_of_node(page),
-   MAX_BIO_BLOCKS(max_hw_blocks(sbi)), META_POR);
+   MAX_BIO_BLOCKS(sbi), META_POR);
 
if (cp_ver != cpver_of_node(page))
break;
@@ -444,7 +444,7 @@ static int recover_data(struct f2fs_sb_info *sbi,
page = get_meta_page(sbi, blkaddr);
 
ra_meta_pages(sbi, next_blkaddr_of_node(page),
-   MAX_BIO_BLOCKS(max_hw_blocks(sbi)), META_POR);
+   MAX_BIO_BLOCKS(sbi), META_POR);
 
if (cp_ver != cpver_of_node(page)) {
f2fs_put_page(page, 1);
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index c6f627b..4ea53aa 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1757,7 +1757,7 @@ static void build_sit_entries(struct f2fs_sb_info *sbi)
int sit_blk_cnt = SIT_BLK_CNT(sbi);
unsigned int i, start, end;
unsigned int readed, start_blk = 0;
-   int nrpages = MAX_BIO_BLOCKS(max_hw_blocks(sbi));
+   int nrpages = MAX_BIO_BLOCKS(sbi);
 
do {
readed = ra_meta_pages(sbi, start_blk, nrpages, META_SIT);
diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h
index c6f37f2..633e822 100644
--- a/fs/f2fs/segment.h
+++ b/fs/f2fs/segment.h
@@ -93,8 +93,8 @@
(((sector_t)blk_addr) << (sbi)->log_sectors_per_block)
 #define SECTOR_TO_BLOCK(sbi, sectors)  \
(sectors >> (sbi)->log_sectors_per_block)
-#define MAX_BIO_BLOCKS(max_hw_blocks)  \
-   (min((int)max_hw_blocks, BIO_MAX_PAGES))
+#define MAX_BIO_BLOCKS(sbi)\
+   ((int)min(max_hw_blocks(sbi), BIO_MAX_PAGES))
 
 /*
  * indicate a block allocation direction: RIGHT and LEFT.
@@ -728,7 +728,7 @@ static inline int nr_pages_to_skip(struct f2fs_sb_info 
*sbi, int type)
else if (type == NODE)
return 3 * sbi->blocks_per_seg;
else if (type == META)
-   return MAX_BIO_BLOCKS(max_hw_blocks(sbi));
+   return MAX_BIO_BLOCKS(sbi);
else
return 0;
 }
@@ -751,7 +751,7 @@ static inline long nr_pages_to_write(struct f2fs_sb_info 
*sbi, int type,
else if (type == NODE)
desired = 3 * max_hw_blocks(sbi);
else
-   desired = MAX_BIO_BLOCKS(max_hw_blocks(sbi));
+   desired = MAX_BIO_BLOCKS(sbi);
 
wbc->nr_to_write = desired;
return desired - nr_to_write;
-- 
1.8.5.2 (Apple Git-48)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 09/10] f2fs: use MAX_BIO_BLOCKS(sbi)

2014-09-17 Thread Jaegeuk Kim 
Hi,

Thank you for the review.
I changed the return value of MAX_BIO_BLOCKS to int.
IMO, it's the best way that I can do for now.

Thanks,

From f3bcd1d658d1c4aa8178ddc2d4e6a7e45d8405cd Mon Sep 17 00:00:00 2001
From: Jaegeuk Kim jaeg...@kernel.org
Date: Thu, 11 Sep 2014 14:37:35 -0700
Subject: [PATCH] f2fs: use MAX_BIO_BLOCKS(sbi)

Change log from v1:
 o change the return value of MAX_BIO_BLOCKS to int type.

This patch cleans up a simple macro.

Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
 fs/f2fs/data.c | 2 +-
 fs/f2fs/node.c | 2 +-
 fs/f2fs/recovery.c | 4 ++--
 fs/f2fs/segment.c  | 2 +-
 fs/f2fs/segment.h  | 8 
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index fdc3dbe..7749f30 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -193,7 +193,7 @@ void f2fs_submit_page_mbio(struct f2fs_sb_info *sbi, struct 
page *page,
__submit_merged_bio(io);
 alloc_new:
if (io-bio == NULL) {
-   int bio_blocks = MAX_BIO_BLOCKS(max_hw_blocks(sbi));
+   int bio_blocks = MAX_BIO_BLOCKS(sbi);
 
io-bio = __bio_alloc(sbi, blk_addr, bio_blocks, is_read);
io-fio = *fio;
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 7a2d9c9..21ed91b 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1697,7 +1697,7 @@ int restore_node_summary(struct f2fs_sb_info *sbi,
struct f2fs_summary *sum_entry;
struct inode *inode = sbi-sb-s_bdev-bd_inode;
block_t addr;
-   int bio_blocks = MAX_BIO_BLOCKS(max_hw_blocks(sbi));
+   int bio_blocks = MAX_BIO_BLOCKS(sbi);
struct page *pages[bio_blocks];
int i, idx, last_offset, nrpages, err = 0;
 
diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
index 78ef10c..1ccee36 100644
--- a/fs/f2fs/recovery.c
+++ b/fs/f2fs/recovery.c
@@ -180,7 +180,7 @@ static int find_fsync_dnodes(struct f2fs_sb_info *sbi, 
struct list_head *head)
page = get_meta_page(sbi, blkaddr);
 
ra_meta_pages(sbi, next_blkaddr_of_node(page),
-   MAX_BIO_BLOCKS(max_hw_blocks(sbi)), META_POR);
+   MAX_BIO_BLOCKS(sbi), META_POR);
 
if (cp_ver != cpver_of_node(page))
break;
@@ -444,7 +444,7 @@ static int recover_data(struct f2fs_sb_info *sbi,
page = get_meta_page(sbi, blkaddr);
 
ra_meta_pages(sbi, next_blkaddr_of_node(page),
-   MAX_BIO_BLOCKS(max_hw_blocks(sbi)), META_POR);
+   MAX_BIO_BLOCKS(sbi), META_POR);
 
if (cp_ver != cpver_of_node(page)) {
f2fs_put_page(page, 1);
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index c6f627b..4ea53aa 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1757,7 +1757,7 @@ static void build_sit_entries(struct f2fs_sb_info *sbi)
int sit_blk_cnt = SIT_BLK_CNT(sbi);
unsigned int i, start, end;
unsigned int readed, start_blk = 0;
-   int nrpages = MAX_BIO_BLOCKS(max_hw_blocks(sbi));
+   int nrpages = MAX_BIO_BLOCKS(sbi);
 
do {
readed = ra_meta_pages(sbi, start_blk, nrpages, META_SIT);
diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h
index c6f37f2..633e822 100644
--- a/fs/f2fs/segment.h
+++ b/fs/f2fs/segment.h
@@ -93,8 +93,8 @@
(((sector_t)blk_addr)  (sbi)-log_sectors_per_block)
 #define SECTOR_TO_BLOCK(sbi, sectors)  \
(sectors  (sbi)-log_sectors_per_block)
-#define MAX_BIO_BLOCKS(max_hw_blocks)  \
-   (min((int)max_hw_blocks, BIO_MAX_PAGES))
+#define MAX_BIO_BLOCKS(sbi)\
+   ((int)min(max_hw_blocks(sbi), BIO_MAX_PAGES))
 
 /*
  * indicate a block allocation direction: RIGHT and LEFT.
@@ -728,7 +728,7 @@ static inline int nr_pages_to_skip(struct f2fs_sb_info 
*sbi, int type)
else if (type == NODE)
return 3 * sbi-blocks_per_seg;
else if (type == META)
-   return MAX_BIO_BLOCKS(max_hw_blocks(sbi));
+   return MAX_BIO_BLOCKS(sbi);
else
return 0;
 }
@@ -751,7 +751,7 @@ static inline long nr_pages_to_write(struct f2fs_sb_info 
*sbi, int type,
else if (type == NODE)
desired = 3 * max_hw_blocks(sbi);
else
-   desired = MAX_BIO_BLOCKS(max_hw_blocks(sbi));
+   desired = MAX_BIO_BLOCKS(sbi);
 
wbc-nr_to_write = desired;
return desired - nr_to_write;
-- 
1.8.5.2 (Apple Git-48)

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 09/10] f2fs: use MAX_BIO_BLOCKS(sbi)

2014-09-14 Thread Joe Perches 
On Sun, 2014-09-14 at 15:14 -0700, Jaegeuk Kim wrote:
> This patch cleans up a simple macro.

There seems to be many different types used here.

MAX_BIO_BLOCKS returns unsigned int
bio_blocks is int,
blocks_per_seg is unsigned int,
ra_meta_pages(,,int,)
nr_pages_to_skip uses int
nr_pages_to_write returns a long

Perhaps it'd be nicer to standardize the type
so there'd be fewer promotions/implicit casts.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 09/10] f2fs: use MAX_BIO_BLOCKS(sbi)

2014-09-14 Thread Jaegeuk Kim 
This patch cleans up a simple macro.

Signed-off-by: Jaegeuk Kim 
---
 fs/f2fs/data.c | 2 +-
 fs/f2fs/node.c | 2 +-
 fs/f2fs/recovery.c | 4 ++--
 fs/f2fs/segment.c  | 2 +-
 fs/f2fs/segment.h  | 8 
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 6637741..e800d71 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -193,7 +193,7 @@ void f2fs_submit_page_mbio(struct f2fs_sb_info *sbi, struct 
page *page,
__submit_merged_bio(io);
 alloc_new:
if (io->bio == NULL) {
-   int bio_blocks = MAX_BIO_BLOCKS(max_hw_blocks(sbi));
+   int bio_blocks = MAX_BIO_BLOCKS(sbi);
 
io->bio = __bio_alloc(sbi, blk_addr, bio_blocks, is_read);
io->fio = *fio;
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 653aa71..e38343d 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1692,7 +1692,7 @@ int restore_node_summary(struct f2fs_sb_info *sbi,
struct f2fs_summary *sum_entry;
struct inode *inode = sbi->sb->s_bdev->bd_inode;
block_t addr;
-   int bio_blocks = MAX_BIO_BLOCKS(max_hw_blocks(sbi));
+   int bio_blocks = MAX_BIO_BLOCKS(sbi);
struct page *pages[bio_blocks];
int i, idx, last_offset, nrpages, err = 0;
 
diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
index 95d9dc9..dbeb32d 100644
--- a/fs/f2fs/recovery.c
+++ b/fs/f2fs/recovery.c
@@ -181,7 +181,7 @@ static int find_fsync_dnodes(struct f2fs_sb_info *sbi, 
struct list_head *head)
return PTR_ERR(page);
 
ra_meta_pages(sbi, next_blkaddr_of_node(page),
-   MAX_BIO_BLOCKS(max_hw_blocks(sbi)), META_POR);
+   MAX_BIO_BLOCKS(sbi), META_POR);
 
if (cp_ver != cpver_of_node(page))
break;
@@ -433,7 +433,7 @@ static int recover_data(struct f2fs_sb_info *sbi,
return PTR_ERR(page);
 
ra_meta_pages(sbi, next_blkaddr_of_node(page),
-   MAX_BIO_BLOCKS(max_hw_blocks(sbi)), META_POR);
+   MAX_BIO_BLOCKS(sbi), META_POR);
 
if (cp_ver != cpver_of_node(page))
break;
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index c6f627b..4ea53aa 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1757,7 +1757,7 @@ static void build_sit_entries(struct f2fs_sb_info *sbi)
int sit_blk_cnt = SIT_BLK_CNT(sbi);
unsigned int i, start, end;
unsigned int readed, start_blk = 0;
-   int nrpages = MAX_BIO_BLOCKS(max_hw_blocks(sbi));
+   int nrpages = MAX_BIO_BLOCKS(sbi);
 
do {
readed = ra_meta_pages(sbi, start_blk, nrpages, META_SIT);
diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h
index c6f37f2..1ae6c35 100644
--- a/fs/f2fs/segment.h
+++ b/fs/f2fs/segment.h
@@ -93,8 +93,8 @@
(((sector_t)blk_addr) << (sbi)->log_sectors_per_block)
 #define SECTOR_TO_BLOCK(sbi, sectors)  \
(sectors >> (sbi)->log_sectors_per_block)
-#define MAX_BIO_BLOCKS(max_hw_blocks)  \
-   (min((int)max_hw_blocks, BIO_MAX_PAGES))
+#define MAX_BIO_BLOCKS(sbi)\
+   (min((int)max_hw_blocks(sbi), BIO_MAX_PAGES))
 
 /*
  * indicate a block allocation direction: RIGHT and LEFT.
@@ -728,7 +728,7 @@ static inline int nr_pages_to_skip(struct f2fs_sb_info 
*sbi, int type)
else if (type == NODE)
return 3 * sbi->blocks_per_seg;
else if (type == META)
-   return MAX_BIO_BLOCKS(max_hw_blocks(sbi));
+   return MAX_BIO_BLOCKS(sbi);
else
return 0;
 }
@@ -751,7 +751,7 @@ static inline long nr_pages_to_write(struct f2fs_sb_info 
*sbi, int type,
else if (type == NODE)
desired = 3 * max_hw_blocks(sbi);
else
-   desired = MAX_BIO_BLOCKS(max_hw_blocks(sbi));
+   desired = MAX_BIO_BLOCKS(sbi);
 
wbc->nr_to_write = desired;
return desired - nr_to_write;
-- 
1.8.5.2 (Apple Git-48)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[PATCH 09/10] f2fs: use MAX_BIO_BLOCKS(sbi)

2014-09-14 Thread Jaegeuk Kim 
This patch cleans up a simple macro.

Signed-off-by: Jaegeuk Kim jaeg...@kernel.org
---
 fs/f2fs/data.c | 2 +-
 fs/f2fs/node.c | 2 +-
 fs/f2fs/recovery.c | 4 ++--
 fs/f2fs/segment.c  | 2 +-
 fs/f2fs/segment.h  | 8 
 5 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 6637741..e800d71 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -193,7 +193,7 @@ void f2fs_submit_page_mbio(struct f2fs_sb_info *sbi, struct 
page *page,
__submit_merged_bio(io);
 alloc_new:
if (io-bio == NULL) {
-   int bio_blocks = MAX_BIO_BLOCKS(max_hw_blocks(sbi));
+   int bio_blocks = MAX_BIO_BLOCKS(sbi);
 
io-bio = __bio_alloc(sbi, blk_addr, bio_blocks, is_read);
io-fio = *fio;
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 653aa71..e38343d 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -1692,7 +1692,7 @@ int restore_node_summary(struct f2fs_sb_info *sbi,
struct f2fs_summary *sum_entry;
struct inode *inode = sbi-sb-s_bdev-bd_inode;
block_t addr;
-   int bio_blocks = MAX_BIO_BLOCKS(max_hw_blocks(sbi));
+   int bio_blocks = MAX_BIO_BLOCKS(sbi);
struct page *pages[bio_blocks];
int i, idx, last_offset, nrpages, err = 0;
 
diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
index 95d9dc9..dbeb32d 100644
--- a/fs/f2fs/recovery.c
+++ b/fs/f2fs/recovery.c
@@ -181,7 +181,7 @@ static int find_fsync_dnodes(struct f2fs_sb_info *sbi, 
struct list_head *head)
return PTR_ERR(page);
 
ra_meta_pages(sbi, next_blkaddr_of_node(page),
-   MAX_BIO_BLOCKS(max_hw_blocks(sbi)), META_POR);
+   MAX_BIO_BLOCKS(sbi), META_POR);
 
if (cp_ver != cpver_of_node(page))
break;
@@ -433,7 +433,7 @@ static int recover_data(struct f2fs_sb_info *sbi,
return PTR_ERR(page);
 
ra_meta_pages(sbi, next_blkaddr_of_node(page),
-   MAX_BIO_BLOCKS(max_hw_blocks(sbi)), META_POR);
+   MAX_BIO_BLOCKS(sbi), META_POR);
 
if (cp_ver != cpver_of_node(page))
break;
diff --git a/fs/f2fs/segment.c b/fs/f2fs/segment.c
index c6f627b..4ea53aa 100644
--- a/fs/f2fs/segment.c
+++ b/fs/f2fs/segment.c
@@ -1757,7 +1757,7 @@ static void build_sit_entries(struct f2fs_sb_info *sbi)
int sit_blk_cnt = SIT_BLK_CNT(sbi);
unsigned int i, start, end;
unsigned int readed, start_blk = 0;
-   int nrpages = MAX_BIO_BLOCKS(max_hw_blocks(sbi));
+   int nrpages = MAX_BIO_BLOCKS(sbi);
 
do {
readed = ra_meta_pages(sbi, start_blk, nrpages, META_SIT);
diff --git a/fs/f2fs/segment.h b/fs/f2fs/segment.h
index c6f37f2..1ae6c35 100644
--- a/fs/f2fs/segment.h
+++ b/fs/f2fs/segment.h
@@ -93,8 +93,8 @@
(((sector_t)blk_addr)  (sbi)-log_sectors_per_block)
 #define SECTOR_TO_BLOCK(sbi, sectors)  \
(sectors  (sbi)-log_sectors_per_block)
-#define MAX_BIO_BLOCKS(max_hw_blocks)  \
-   (min((int)max_hw_blocks, BIO_MAX_PAGES))
+#define MAX_BIO_BLOCKS(sbi)\
+   (min((int)max_hw_blocks(sbi), BIO_MAX_PAGES))
 
 /*
  * indicate a block allocation direction: RIGHT and LEFT.
@@ -728,7 +728,7 @@ static inline int nr_pages_to_skip(struct f2fs_sb_info 
*sbi, int type)
else if (type == NODE)
return 3 * sbi-blocks_per_seg;
else if (type == META)
-   return MAX_BIO_BLOCKS(max_hw_blocks(sbi));
+   return MAX_BIO_BLOCKS(sbi);
else
return 0;
 }
@@ -751,7 +751,7 @@ static inline long nr_pages_to_write(struct f2fs_sb_info 
*sbi, int type,
else if (type == NODE)
desired = 3 * max_hw_blocks(sbi);
else
-   desired = MAX_BIO_BLOCKS(max_hw_blocks(sbi));
+   desired = MAX_BIO_BLOCKS(sbi);
 
wbc-nr_to_write = desired;
return desired - nr_to_write;
-- 
1.8.5.2 (Apple Git-48)

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [PATCH 09/10] f2fs: use MAX_BIO_BLOCKS(sbi)

2014-09-14 Thread Joe Perches 
On Sun, 2014-09-14 at 15:14 -0700, Jaegeuk Kim wrote:
 This patch cleans up a simple macro.

There seems to be many different types used here.

MAX_BIO_BLOCKS returns unsigned int
bio_blocks is int,
blocks_per_seg is unsigned int,
ra_meta_pages(,,int,)
nr_pages_to_skip uses int
nr_pages_to_write returns a long

Perhaps it'd be nicer to standardize the type
so there'd be fewer promotions/implicit casts.


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/